New issue
Advanced search Search tips

Issue 613023 link

Starred by 2 users
Status: Fixed
Owner:
sclit...@chromium.org
Closed: May 2016
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: ----



Sign in to add a comment

DataReductionProxy.ProbeURLNetError histogram should count failures caused by captive portal redirects.

Project Member Reported by sclit...@chromium.org, May 19 2016 
Currently, the DataReductionProxy.ProbeURLNetError UMA histogram doesn't count failures caused by captive portal redirects, since those are technically surfaced as cancellations, not failures, because the URLFetcher decided not to follow the redirect.

These cancellations should be counted together with the other possible causes of failure in that histogram.
Project Member

Comment 1 by bugdroid1@chromium.org, May 20 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/75d1dec0ee01ea02d8267d1e09cba0d958d80540

commit 75d1dec0ee01ea02d8267d1e09cba0d958d80540
Author: sclittle <sclittle@chromium.org>
Date: Fri May 20 03:37:45 2016

Record histograms for DRP secure proxy check failures caused by CPs.

When the user is on a network with a captive portal, oftentimes the Data
Reduction Proxy's secure proxy check will fail when it receives a
redirect to the captive portal's login page. This CL causes these
failures to be recorded in the existing
DataReductionProxy.ProbeURLNetError histogram, together with the other
possible causes of failure.

BUG= 613023 

Review-Url: https://codereview.chromium.org/1996513002
Cr-Commit-Position: refs/heads/master@{#394984}

[modify] https://crrev.com/75d1dec0ee01ea02d8267d1e09cba0d958d80540/components/data_reduction_proxy/core/browser/data_reduction_proxy_config.cc
[modify] https://crrev.com/75d1dec0ee01ea02d8267d1e09cba0d958d80540/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_unittest.cc

Comment 2 by sclit...@chromium.org, May 20 2016

Status: Fixed (was: Started)
►

Sign in to add a comment