New issue
Advanced search Search tips

Issue 613021 link

Starred by 2 users
Status: Fixed
Owner:
sclit...@chromium.org
Closed: May 2016
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: ----



Sign in to add a comment

Remove TestDataReductionProxyConfigurator class that serves no real purpose

Project Member Reported by sclit...@chromium.org, May 19 2016 
The TestDataReductionProxyConfigurator class doesn't really serve any real purpose anymore, as all uses of its test functionality should be checking the configured proxy list instead of checking flags to see what arguments were passed to DRPConfigurator::Enable().

This class should be removed and all uses of it should be replaced with an ordinary DataReductionProxyConfigurator.

https://code.google.com/p/chromium/codesearch#chromium/src/components/data_reduction_proxy/core/browser/data_reduction_proxy_configurator_test_utils.h
Project Member

Comment 1 by bugdroid1@chromium.org, May 20 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/be89059015aa60b12762b5858be2ad98203b7319

commit be89059015aa60b12762b5858be2ad98203b7319
Author: sclittle <sclittle@chromium.org>
Date: Fri May 20 00:35:13 2016

Remove unnecessary DRPConfiguratorTestUtils and add more DRPConfig tests

The TestDRPConfigurator served no purpose, so this CL removes it. This
CL also changes some of the DRPConfig tests around the secure proxy
check to test that HTTPS proxies are removed from the effective proxy
lists. This CL also contains miscellaneous cleanup of DRPConfig that
doesn't affect the functionality of that class, only the performance and
readability.

BUG= 613021 

Review-Url: https://codereview.chromium.org/1989393004
Cr-Commit-Position: refs/heads/master@{#394929}

[modify] https://crrev.com/be89059015aa60b12762b5858be2ad98203b7319/components/data_reduction_proxy.gypi
[modify] https://crrev.com/be89059015aa60b12762b5858be2ad98203b7319/components/data_reduction_proxy/core/browser/BUILD.gn
[modify] https://crrev.com/be89059015aa60b12762b5858be2ad98203b7319/components/data_reduction_proxy/core/browser/data_reduction_proxy_config.cc
[modify] https://crrev.com/be89059015aa60b12762b5858be2ad98203b7319/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_client_unittest.cc
[modify] https://crrev.com/be89059015aa60b12762b5858be2ad98203b7319/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_unittest.cc
[delete] https://crrev.com/6156d89a02285efbd053bb7922d2432295a6872d/components/data_reduction_proxy/core/browser/data_reduction_proxy_configurator_test_utils.cc
[delete] https://crrev.com/6156d89a02285efbd053bb7922d2432295a6872d/components/data_reduction_proxy/core/browser/data_reduction_proxy_configurator_test_utils.h
[modify] https://crrev.com/be89059015aa60b12762b5858be2ad98203b7319/components/data_reduction_proxy/core/browser/data_reduction_proxy_delegate_unittest.cc
[modify] https://crrev.com/be89059015aa60b12762b5858be2ad98203b7319/components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data_unittest.cc
[modify] https://crrev.com/be89059015aa60b12762b5858be2ad98203b7319/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_unittest.cc
[modify] https://crrev.com/be89059015aa60b12762b5858be2ad98203b7319/components/data_reduction_proxy/core/browser/data_reduction_proxy_test_utils.cc
[modify] https://crrev.com/be89059015aa60b12762b5858be2ad98203b7319/components/data_reduction_proxy/core/browser/data_reduction_proxy_test_utils.h

Comment 2 by sclit...@chromium.org, May 20 2016

Status: Fixed (was: Started)
►

Sign in to add a comment