views_mus_unittests failing fairly consistently on linux_chromium_rel_ng |
|||||
Issue descriptionhttps://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng?numbuilds=200 It doesn't seem to be failing on the waterfall (https://build.chromium.org/p/chromium.linux/builders). Log excerpt: DisplayListTest.AddUpdateRemove (run #1): [ RUN ] DisplayListTest.AddUpdateRemove [ OK ] DisplayListTest.AddUpdateRemove (0 ms) [----------] 1 test from DisplayListTest (0 ms total) [----------] Global test environment tear-down [==========] 1 test from 1 test case ran. (0 ms total) [ PASSED ] 1 test. [25320:25320:0518/162533:6867398097:FATAL:window_manager_connection.cc(48)] Check failed: connection. #0 0x000000d5318e base::debug::StackTrace::StackTrace() #1 0x000000d5f37b logging::LogMessage::~LogMessage() #2 0x000000493af5 views::WindowManagerConnection::Get() #3 0x000000493ba9 views::WindowManagerConnection::Reset() #4 0x000000496265 views::ShellConnection::~ShellConnection() #5 0x000000495c50 views::ViewsMusTestSuite::Shutdown() #6 0x000000cd44aa base::TestSuite::Run() #7 0x000000ce00ff base::(anonymous namespace)::LaunchUnitTestsInternal() #8 0x000000cdffc4 base::LaunchUnitTests() #9 0x000000495576 views::ViewsTestSuite::RunTests() #10 0x000000487d24 MasterProcessMain() #11 0x7fe5a539b76d __libc_start_main #12 0x00000043b9c9 <unknown> sky@, do you know why this might happen? Note: haibinlu@'s patch is blocked on this
,
May 19 2016
,
May 19 2016
Issue 613076 has been merged into this issue.
,
May 19 2016
,
May 19 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/56172f6d40ecf4dc259a05d37df4bd2ac8789846 commit 56172f6d40ecf4dc259a05d37df4bd2ac8789846 Author: sky <sky@chromium.org> Date: Thu May 19 16:42:51 2016 Fixes crash in ~ShellConnection Code was assuming a WindowManagerConnection has been created, which is not necessarily the case. In particular if you run a single test and the test doesn't talk to mus you hit the check. BUG= 613018 TEST=test only change R=sadrul@chromium.org Review-Url: https://codereview.chromium.org/1998543004 Cr-Commit-Position: refs/heads/master@{#394795} [modify] https://crrev.com/56172f6d40ecf4dc259a05d37df4bd2ac8789846/ui/views/mus/display_list_unittest.cc [modify] https://crrev.com/56172f6d40ecf4dc259a05d37df4bd2ac8789846/ui/views/mus/views_mus_test_suite.cc
,
May 19 2016
,
Jan 24 2018
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by bugdroid1@chromium.org
, May 19 2016