New issue
Advanced search Search tips

Issue 613014 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2016
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: ----



Sign in to add a comment

Deprecate notifiactionId for download

Project Member Reported by qin...@chromium.org, May 19 2016

Issue description

NotificationId comes from downloadId, which is being deprecated.
 
Status: Assigned (was: Unconfirmed)
Project Member

Comment 2 by bugdroid1@chromium.org, May 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b935b5d8c1675d06e6733483ba5ff56ed22906ae

commit b935b5d8c1675d06e6733483ba5ff56ed22906ae
Author: qinmin <qinmin@chromium.org>
Date: Thu May 26 19:33:04 2016

deprecate notificationId for downloads

The downloadId is going to be deprecated, and it is replaced by downloadGuid.
Android currently use the downloadId as notificationId.
This should also be deprecated.
This change generates a new notificationId for each newly added
download.
And a SharedPref entry is used to record the next notificationId to be generated

BUG= 613014 

Review-Url: https://codereview.chromium.org/1993873003
Cr-Commit-Position: refs/heads/master@{#396254}

[modify] https://crrev.com/b935b5d8c1675d06e6733483ba5ff56ed22906ae/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadItem.java
[modify] https://crrev.com/b935b5d8c1675d06e6733483ba5ff56ed22906ae/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java
[modify] https://crrev.com/b935b5d8c1675d06e6733483ba5ff56ed22906ae/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java
[modify] https://crrev.com/b935b5d8c1675d06e6733483ba5ff56ed22906ae/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotifier.java
[modify] https://crrev.com/b935b5d8c1675d06e6733483ba5ff56ed22906ae/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadSharedPreferenceEntry.java
[modify] https://crrev.com/b935b5d8c1675d06e6733483ba5ff56ed22906ae/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadSnackbarController.java
[modify] https://crrev.com/b935b5d8c1675d06e6733483ba5ff56ed22906ae/chrome/android/java/src/org/chromium/chrome/browser/download/SystemDownloadNotifier.java
[modify] https://crrev.com/b935b5d8c1675d06e6733483ba5ff56ed22906ae/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadManagerServiceTest.java
[modify] https://crrev.com/b935b5d8c1675d06e6733483ba5ff56ed22906ae/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadNotificationServiceTest.java
[modify] https://crrev.com/b935b5d8c1675d06e6733483ba5ff56ed22906ae/chrome/android/javatests/src/org/chromium/chrome/browser/download/MockDownloadNotificationService.java
[modify] https://crrev.com/b935b5d8c1675d06e6733483ba5ff56ed22906ae/chrome/android/javatests/src/org/chromium/chrome/browser/download/SystemDownloadNotifierTest.java
[modify] https://crrev.com/b935b5d8c1675d06e6733483ba5ff56ed22906ae/content/browser/android/download_controller_android_impl.cc
[modify] https://crrev.com/b935b5d8c1675d06e6733483ba5ff56ed22906ae/content/public/android/java/src/org/chromium/content/browser/DownloadController.java
[modify] https://crrev.com/b935b5d8c1675d06e6733483ba5ff56ed22906ae/content/public/android/java/src/org/chromium/content/browser/DownloadInfo.java

Comment 3 by suherv...@gmail.com, May 28 2016

Pada tanggal 27 Mei 2016 02.35, "bugdroid1@chromium.org via Monorail" <
monorail@chromium.org> menulis:

Comment 4 by qin...@chromium.org, Aug 18 2016

Status: Fixed (was: Assigned)

Sign in to add a comment