Ninja update broke x86 crashpad bots |
||
Issue descriptionSince bug 607268 https://build.chromium.org/p/client.crashpad/console has been broken on x86, because some rando let the x64 ninja build slide https://bugs.chromium.org/p/chromium/issues/detail?id=607268#c1. https://build.chromium.org/p/client.crashpad/builders/crashpad_win_x86_dbg client.crashpad doesn't have access to all the swarming setup that chromium has, so it's non-trivial to build on x64 and run on x86. These tests are specifically testing x86 on x86 host (separate from x86 running under Wow64 on x64 host for which there's another bot). I'm not sure what we should do. Maybe put Windows ninja back to x86? Or maybe we could add a ninja32.exe?
,
May 19 2016
Builder/tester split feasible?
,
May 19 2016
Per #0, it's not very easy to split things up between multiple machines, as all the swarming/split stuff lives in "chrome" recipes.
,
May 19 2016
I thought that the swarming and triggering logic is mostly done in separate recipe modules. I haven't tried it myself, but I don't think it should be that hard to get working?
,
May 19 2016
Swarming does, but builder/tester is fairly simple and predates recipes (it's in one of those _factory thingies in tools/scripts/master).
,
May 19 2016
builder/tester waterfall bots are pretty straightforward; builder/tester tryjobs, less so.
,
May 19 2016
OK. I thought it was you (Dirk) that suggested running on the same bot because the swarming/triggering was tricky in client. :) But that was a while ago, I might be misremembering. I think these bots are recipes, so I guess I'll try that then.
,
May 19 2016
That sounds like something I might've said at some point, all right. It seems like adding a 32-bit ninja binary is by far the easiest thing to do.
,
May 19 2016
Oops, missed #6. Well, we wanted trybots, but I never got around to deciphering the required config, so I'll setting for taking a shot at resurrecting the x86 waterfall bots. Thanks! (Any examples to copy-paste?)
,
May 19 2016
Adding a 32-bit ninja binary is easy-ish, but signing up for supporting 32-bit windows hosts seems like a bad idea in general. I'd prefer if we could not add this dependency, especially if it's only for the crashpad waterfall.
,
May 19 2016
I don't know of any obvious examples for swarming or triggering w/o using the chromium recipe, but +nodir and +martiniss might.
,
May 19 2016
Triggering without recipes can be done the way it was originally designed in buildbot http://docs.buildbot.net/0.8.4p2/Triggering-Schedulers.html You can schedule a swarming task by executing https://chromium.googlesource.com/chromium/tools/swarm_client/+/54f416f4038978e3f550c28332f0a21b5f6d49fc/isolate.py but it requires fetching the script and having credentials on the bot
,
May 19 2016
@nodir - crashpad uses builders.pyl and recipes.
,
May 19 2016
trigger recipe module implements triggering https://chromium.googlesource.com/chromium/tools/build/+/master/scripts/slave/recipe_modules/trigger/README.md examples of triggering w/o using the chromium recipe: https://code.google.com/p/chromium/codesearch#search/&q=api.trigger%5C(&sq=package:chromium&type=cs
,
Sep 6
,
Sep 6
It's closed as per the *bug title*. If you want to do other AIs, please file a separate bug. |
||
►
Sign in to add a comment |
||
Comment 1 by dpranke@chromium.org
, May 18 2016