New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 613006 link

Starred by 5 users

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Add spacer between suggested corrections and "Add word to dictionary"

Project Member Reported by groby@chromium.org, May 18 2016

Issue description

Currently, it is very easy to just add a word to the dictionary by accident - adding a spacer would reduce the chance of that accident. 

+rpop for appropriate UX people looping-innery. 
 

Comment 1 by rpop@chromium.org, May 20 2016

Could you attach a screenshot when you next see this?

Comment 2 by groby@chromium.org, May 20 2016

Only have OSX handy right now...

Screenshot #1: Current menu on Chrome OSX Version 52.0.2730.0 canary
Screenshot #2: Menu with separator between suggestions and add (default behavior in OSX apps)

Screen Shot 2016-05-19 at 6.21.58 PM.png
49.7 KB View Download
Screen Shot 2016-05-19 at 6.22.24 PM.png
65.2 KB View Download

Comment 3 by groby@chromium.org, Aug 23 2016

Issue 630594 has been merged into this issue.

Comment 4 by k...@chromium.org, Aug 26 2016

Here is what it would look like with a separator. A trivial code change, and I think it looks nice.
spellcheck-menu.png
18.4 KB View Download
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/698795cdd68c0d2c4fdc4c13d331f41ec7cd47e1

commit 698795cdd68c0d2c4fdc4c13d331f41ec7cd47e1
Author: krb <krb@chromium.org>
Date: Tue Aug 30 13:29:27 2016

[SpellCheck] Add separator if we add "Add to dictionary" option

Add a separator between spelling corrections and "Add to dictionary" so that it's more difficult to accidentally do one or the other.

BUG=613006

Review-Url: https://codereview.chromium.org/2280113002
Cr-Commit-Position: refs/heads/master@{#415283}

[modify] https://crrev.com/698795cdd68c0d2c4fdc4c13d331f41ec7cd47e1/chrome/browser/renderer_context_menu/spelling_menu_observer.cc
[modify] https://crrev.com/698795cdd68c0d2c4fdc4c13d331f41ec7cd47e1/chrome/browser/renderer_context_menu/spelling_menu_observer_browsertest.cc

Components: -UI>Browser>Spellcheck UI>Browser>Language>Spellcheck

Sign in to add a comment