New issue
Advanced search Search tips

Issue 612990 link

Starred by 7 users

Issue metadata

Status: Archived
Owner:
Closed: Sep 18
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Remove old shortcuts that were moved to Search

Project Member Reported by w...@chromium.org, May 18 2016

Issue description

Version: 52.0.2727.0
OS: ChromeOS

What steps will reproduce the problem?
(1) Configure ChromeOS with two or more input languages.
(2) Press Alt+Shift+i to report feedback.

What is the expected output?

Expect that feedback gets reported.

What do you see instead?

The feedback dialog may or may not show (see  issue 612907 ) but the language will also switch.

Please use labels and text to provide additional information.

 

Comment 1 by w...@chromium.org, May 18 2016

Components: UI>Internationalization
Cc: abodenha@chromium.org
Components: Platform>Apps>Feedback
Owner: tbuck...@chromium.org
Status: Assigned (was: Untriaged)
Summary: Alt+Shift should be removed (was: Alt+Shift+i is the shortcut for both "next language" and "report issue")
A new key combo to trigger keyboard switch was introduced in bug 492454 in order to prevent exactly this failure.

tbuckley@ I don't see a bug filed tracking the eventual removal of the old key combos. I know there are other things we need to accomplish first.

If there's already an issue please dupe this one into it.
Blockedon: 608625
Summary: Remove old shortcuts that were moved to Search (was: Alt+Shift should be removed)
Making this a general bug for that removing the old shortcuts, which is blocked on remapping settings for other keys.
Cc: tbuck...@chromium.org michae...@chromium.org
Owner: afakhry@chromium.org
#4: wait really? which shortcuts are blocked on remapping settings?

alt+shift at least should be removable already.
We're holding off on removing old keyboard shortcuts (Ctrl+Shift+L, Shift+Alt, Shift+Esc) because we moved them all to use Search, which some users have remapped. Given the unsymmetric nature of our existing keyboard mapping settings, it's not possible for these users to access the new shortcuts by remapping a lesser-used key to Search.
Project Member

Comment 8 by sheriffbot@chromium.org, Jun 1 2016

Labels: -M-52 M-53 MovedFrom-52
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
The deprecated shortcut "Alt+Shift" to switch keyboard layouts has been disabled in the upcoming M-53. "Ctrl+Shift+Space" should be used from now on.

commit	25174475a4ad63208a3dfc0755b4ced719ac2dfd	[log] [tgz]
author	afakhry <afakhry@chromium.org>	Thu Jun 16 20:14:43 2016
committer	Commit bot <commit-bot@chromium.org>	Thu Jun 16 20:16:29 2016
tree	c137aed3ae8187a2f8bb20d68f419d922c31351e
parent	5e31e870bc40f674c3f9bc074f43e5ddd63e3154 [diff]
Disable the deprecated Alt+Shift for NEXT_IME

Due to its many conflicts, we decided to remove it for M-53. We will
keep the notification so as not to confuse users.

R=oshima@chromium.org
BUG= 612990 ,  593633  
TEST=ash_unittests --gtest_filter=DeprecatedAcceleratorTester.*
TEST=ash_unittests --gtest_filter=AcceleratorControllerTest.*

Review-Url: https://codereview.chromium.org/2068333002
Cr-Commit-Position: refs/heads/master@{#400245}
For other deprecated shortcuts that moved to new Search-based accelerators, They will be disabled once work on  issue 608625  has been completed. 
Project Member

Comment 11 by sheriffbot@chromium.org, Jul 9 2016

Labels: -M-53 -Pri-1 M-54 MovedFrom-53 Pri-2
This issue is Pri-1 but has already been moved once. Lowering the priority and moving to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Blockedon: -608625
Could you guys please provide any revert mechanism for Alt-Shift? 

I've been using this shortcut since 1995 for hundreds of times a day, which is a norm for anyone works daily with a non-latin keyboard. 

And then you suddenly remove it with absolutely no way to change or roll it back. Maybe a Chrome extension or experimental flag. This is a terrible usability regression. 
Project Member

Comment 14 by bugdroid1@chromium.org, Nov 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1b1e927b139a713c966719345846631e0e72f308

commit 1b1e927b139a713c966719345846631e0e72f308
Author: afakhry <afakhry@chromium.org>
Date: Mon Nov 14 23:06:05 2016

Disable the old lock-screen shortcut

Disbale the shortcut but keeps the notification for another milestone.

BUG= 612990 
TEST=ash_unittests --gtest_filter=AcceleratorControllerTest.*
TEST=ash_unittests --gtest_filter=DeprecatedAcceleratorTester.*

Review-Url: https://codereview.chromium.org/2501123002
Cr-Commit-Position: refs/heads/master@{#431946}

[modify] https://crrev.com/1b1e927b139a713c966719345846631e0e72f308/ash/accelerators/accelerator_controller_unittest.cc
[modify] https://crrev.com/1b1e927b139a713c966719345846631e0e72f308/ash/common/accelerators/accelerator_table.cc
[modify] https://crrev.com/1b1e927b139a713c966719345846631e0e72f308/ash/mus/accelerators/accelerator_controller_unittest.cc

Status: Archived (was: Assigned)
Archiving old bugs that have only received trivial updates for some time.

If you feel this issue should still be addressed, feel free to reopen it or to file a new issue. Thanks!

Sign in to add a comment