[Device] Mouse settings |
||||||||||
Issue descriptionThe mouse-and-touchpad sub-page should show touchpad settings, mouse settings, or both, depending on what pointers are attached. How should the sub-page be divided when both mouse and touchpad are present? Options has a sub-header for each section (Touchpad and Mouse); see attached. Is there a spec for similar sub-headers in MD Settings? Touchpad has a bunch of settings (see mocks: https://folio.googleplex.com/chrome-ux-specs-and-sources/Chrome%20Inner%20Pages/03-Settings/preview/cards#%2FPREVIEW-Device.png%3Fz=width). Mouse only has one, a checkbox labelled "Swap primary mouse button". Questions: 1. How should we separate the Mouse and Touchpad sections when both are present? Sub-headers? (are there specs for that style?) Dividers? 2. If only one pointer is attached (e.g., Touchpad), should we still include its sub-header ("Touchpad"), or leave it out (like in the mocks) and only show the sub-headers when both are present?
,
May 24 2016
,
May 25 2016
,
May 25 2016
,
May 25 2016
,
May 25 2016
,
May 26 2016
1. Let's display Mouse first. I've updated the specs for subpages and sub-headers 2. If only one pointer is attached, it'd be great if we could remove the sub-headers. That's the ideal at least. ** I realize there's some open questions about sliders so just use the same slider as touchpad for now. Specs https://folio.googleplex.com/chrome-ux-specs-and-sources/Chrome%20Inner%20Pages/03-Settings/specs#%2FSPEC-settings_structure-subpage.png Mocks https://folio.googleplex.com/chrome-ux-specs-and-sources/Chrome%20Inner%20Pages/03-Settings/preview/cards#%2FPREVIEW-Device.png%3Fz=width
,
May 26 2016
Great, thanks Alan!
,
May 26 2016
,
Jun 29 2016
screenshots attached. I don't have the scrolling radio buttons indented yet, although it's unclear whether we still want that. Also, much of the page doesn't look great when it's this wide, see issue 622454 .
,
Jun 30 2016
Looks good! A couple comments: 1) It looks like the sliders may need to be updated to match the spec described in Issue 598879 . 2) I defer to Alan, but I think keeping the radios for "scrolling" unindented in both cases would look fine. Regardless, very happy that we don't get the double-indentation when it's mouse/trackpad settings.
,
Jun 30 2016
Thanks Tom! Yes, this uses the same styling we have elsewhere. We'll go through all the sliders in one pass to conform to issue 598879 .
,
Jul 19 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e6d83603c47a932ea7d4822dd65442456ee26280 commit e6d83603c47a932ea7d4822dd65442456ee26280 Author: michaelpg <michaelpg@chromium.org> Date: Tue Jul 19 20:17:20 2016 add aria-labelledby to options device sliders Not doing so yields accessibility errors in browser tests when a mouse or touchpad are present (as they will be once enabling fake pointers in crrev.com/2006083002) R=stevenjb@chromium.org BUG= 612986 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2161183002 Cr-Commit-Position: refs/heads/master@{#406365} [modify] https://crrev.com/e6d83603c47a932ea7d4822dd65442456ee26280/chrome/browser/resources/options/browser_options.html
,
Jul 19 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fe807f4f43fc317d93df7a8e48a7c62caf42fb4b commit fe807f4f43fc317d93df7a8e48a7c62caf42fb4b Author: michaelpg <michaelpg@chromium.org> Date: Tue Jul 19 22:16:38 2016 MD Settings: Add mouse settings, update pointer settings Adds mouse settings and touchpad sensitivity settings. Updates the pointer icon and title in the device page based on whether a mouse, touchpad, or both are connected. Shows headers separating the mouse and touchpad sections on the pointers subpage when both are visible. If the subpage is open and all mice/touchpads are disconnected, the subpage closes. Also address some flakiness I found in the tests. Screenshots in the bug. BUG= 612986 , 598901 R=stevenjb@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2110833003 Cr-Commit-Position: refs/heads/master@{#406396} [modify] https://crrev.com/fe807f4f43fc317d93df7a8e48a7c62caf42fb4b/chrome/app/settings_strings.grdp [modify] https://crrev.com/fe807f4f43fc317d93df7a8e48a7c62caf42fb4b/chrome/browser/extensions/api/settings_private/prefs_util.cc [modify] https://crrev.com/fe807f4f43fc317d93df7a8e48a7c62caf42fb4b/chrome/browser/resources/settings/device_page/compiled_resources2.gyp [modify] https://crrev.com/fe807f4f43fc317d93df7a8e48a7c62caf42fb4b/chrome/browser/resources/settings/device_page/device_page.html [modify] https://crrev.com/fe807f4f43fc317d93df7a8e48a7c62caf42fb4b/chrome/browser/resources/settings/device_page/device_page.js [modify] https://crrev.com/fe807f4f43fc317d93df7a8e48a7c62caf42fb4b/chrome/browser/resources/settings/device_page/device_page_browser_proxy.js [add] https://crrev.com/fe807f4f43fc317d93df7a8e48a7c62caf42fb4b/chrome/browser/resources/settings/device_page/pointers.html [add] https://crrev.com/fe807f4f43fc317d93df7a8e48a7c62caf42fb4b/chrome/browser/resources/settings/device_page/pointers.js [delete] https://crrev.com/5aa2d8c58b4dbb74437652c32dcdfec5a323db44/chrome/browser/resources/settings/device_page/touchpad.html [delete] https://crrev.com/5aa2d8c58b4dbb74437652c32dcdfec5a323db44/chrome/browser/resources/settings/device_page/touchpad.js [modify] https://crrev.com/fe807f4f43fc317d93df7a8e48a7c62caf42fb4b/chrome/browser/resources/settings/icons.html [modify] https://crrev.com/fe807f4f43fc317d93df7a8e48a7c62caf42fb4b/chrome/browser/resources/settings/route.js [modify] https://crrev.com/fe807f4f43fc317d93df7a8e48a7c62caf42fb4b/chrome/browser/resources/settings/settings_resources.grd [add] https://crrev.com/fe807f4f43fc317d93df7a8e48a7c62caf42fb4b/chrome/browser/ui/webui/settings/chromeos/device_pointer_handler.cc [add] https://crrev.com/fe807f4f43fc317d93df7a8e48a7c62caf42fb4b/chrome/browser/ui/webui/settings/chromeos/device_pointer_handler.h [modify] https://crrev.com/fe807f4f43fc317d93df7a8e48a7c62caf42fb4b/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc [modify] https://crrev.com/fe807f4f43fc317d93df7a8e48a7c62caf42fb4b/chrome/browser/ui/webui/settings/md_settings_ui.cc [modify] https://crrev.com/fe807f4f43fc317d93df7a8e48a7c62caf42fb4b/chrome/chrome_browser_ui.gypi [modify] https://crrev.com/fe807f4f43fc317d93df7a8e48a7c62caf42fb4b/chrome/test/data/webui/settings/cr_settings_browsertest.js [modify] https://crrev.com/fe807f4f43fc317d93df7a8e48a7c62caf42fb4b/chrome/test/data/webui/settings/device_page_tests.js
,
Jul 21 2016
,
Aug 12 2016
|
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by michae...@chromium.org
, May 18 2016