New issue
Advanced search Search tips

Issue 612983 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome
Pri: 1
Type: Bug

Blocking:
issue 495654
issue 609929



Sign in to add a comment

New EV/keyword search/blocked popup treatment on Views

Project Member Reported by pkasting@chromium.org, May 18 2016

Issue description

Comment 1 by est...@chromium.org, May 20 2016

Cc: sgabr...@chromium.org maxwalker@chromium.org
sgabriel/maxwalker, can you verify the width of the post-ev separator at 200% scale factor? Is it 1dp (i.e. 2px) or 1px (1px)?
I'd be inclined to use a constant 1px, even in @2x because it's what we use everythere else, including for the omnibox stroke.

Final decision is up the Max though.
Yes, 1px like everywhere else, please. Sorry, I forgot to include this in the spec (updated: https://drive.google.com/corp/drive/folders/0B6Wxmj9LZL6XZjJURlVaN1hUTzQ).
Project Member

Comment 4 by bugdroid1@chromium.org, May 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/397c9b9f1eb15e4bf7dff5d0d10d9727479f6f4a

commit 397c9b9f1eb15e4bf7dff5d0d10d9727479f6f4a
Author: estade <estade@chromium.org>
Date: Thu May 26 15:28:58 2016

Update omnibox chips in MD

BUG= 612983 

Review-Url: https://codereview.chromium.org/1998493002
Cr-Commit-Position: refs/heads/master@{#396176}

[modify] https://crrev.com/397c9b9f1eb15e4bf7dff5d0d10d9727479f6f4a/chrome/app/generated_resources.grd
[modify] https://crrev.com/397c9b9f1eb15e4bf7dff5d0d10d9727479f6f4a/chrome/browser/ui/layout_constants.cc
[modify] https://crrev.com/397c9b9f1eb15e4bf7dff5d0d10d9727479f6f4a/chrome/browser/ui/views/location_bar/icon_label_bubble_view.cc
[modify] https://crrev.com/397c9b9f1eb15e4bf7dff5d0d10d9727479f6f4a/chrome/browser/ui/views/location_bar/icon_label_bubble_view.h
[modify] https://crrev.com/397c9b9f1eb15e4bf7dff5d0d10d9727479f6f4a/chrome/browser/ui/views/location_bar/keyword_hint_view.cc
[modify] https://crrev.com/397c9b9f1eb15e4bf7dff5d0d10d9727479f6f4a/chrome/browser/ui/views/location_bar/location_bar_view.cc
[modify] https://crrev.com/397c9b9f1eb15e4bf7dff5d0d10d9727479f6f4a/chrome/browser/ui/views/location_bar/selected_keyword_view.cc
[modify] https://crrev.com/397c9b9f1eb15e4bf7dff5d0d10d9727479f6f4a/chrome/browser/ui/views/omnibox/omnibox_view_views.cc
[modify] https://crrev.com/397c9b9f1eb15e4bf7dff5d0d10d9727479f6f4a/ui/gfx/canvas.cc
[modify] https://crrev.com/397c9b9f1eb15e4bf7dff5d0d10d9727479f6f4a/ui/gfx/canvas.h

Comment 5 by f...@chromium.org, Jun 1 2016

(estade, can we mark this as fixed now?)
Status: Fixed (was: Assigned)
This is done, I filed a followup bug for a couple tiny issues but that doesn't need to be tracked on this bug.

Sign in to add a comment