Issue 612979 link

Starred by 1 user

Issue metadata

Status:	Verified
Owner:	chanli@chromium.org
Closed:	May 2016
Cc:	lijeffrey@chromium.org st...@chromium.org █ robert...@chromium.org chanli@chromium.org liaoyuke@chromium.org
Components:	Tools>Test>FindIt
EstimatedDays:	----
NextAction:	----
OS:	----
Pri:	2
Type:	----
Findit

[Findit] test list too long to start try job

Project Member Reported by chanli@chromium.org, May 18 2016

Issue description

Url to the build Failure:
https://build.chromium.org/p/chromium.win/builders/Win7 Tests (dbg)(1)/builds/48776

What is the bug or feature:
The value of property "tests" in build 1463455509875560 exceeds 1024 char limit and causes an exception in buildbot master.

Solution:
After discussion with nodir@ and stgao@, will move list of tests from build property to build parameter, fetch build definition in the recipe using buildbucket recipe module and read test list from there.

Project Member

Comment 1 by bugdroid1@chromium.org, May 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/b0e4f1b8847a1000c25c97bab59005d505049270

commit b0e4f1b8847a1000c25c97bab59005d505049270
Author: chanli <chanli@chromium.org>
Date: Fri May 20 21:14:18 2016

[Findit] Send targeted_tests to try-job in build_parameter instend of build_property.

When the test list exceeds the 1024 char limit it will raise an exception and the try job won't start. Send tests as build_parameter instead to avoid this limit.

BUG= 612979 

Review-Url: https://codereview.chromium.org/1991333002

[modify] https://crrev.com/b0e4f1b8847a1000c25c97bab59005d505049270/appengine/findit/common/waterfall/buildbucket_client.py
[modify] https://crrev.com/b0e4f1b8847a1000c25c97bab59005d505049270/appengine/findit/common/waterfall/test/buildbucket_client_test.py
[modify] https://crrev.com/b0e4f1b8847a1000c25c97bab59005d505049270/appengine/findit/waterfall/schedule_try_job_pipeline.py
[modify] https://crrev.com/b0e4f1b8847a1000c25c97bab59005d505049270/appengine/findit/waterfall/test/schedule_try_job_pipeline_test.py

Project Member

Comment 2 by bugdroid1@chromium.org, May 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/3aa19451a821eb7e1d161e542aa6d0fc17ba416c

commit 3aa19451a821eb7e1d161e542aa6d0fc17ba416c
Author: chanli <chanli@chromium.org>
Date: Sat May 21 00:10:16 2016

Use build_parameter to pass tests, and in recipe use buildbucket recipe module and read test list from there.

BUG= 612979 

Review-Url: https://codereview.chromium.org/1995153002

[add] https://crrev.com/3aa19451a821eb7e1d161e542aa6d0fc17ba416c/scripts/slave/recipes/findit/chromium/test.expected/use_build_parameter_for_tests.json
[modify] https://crrev.com/3aa19451a821eb7e1d161e542aa6d0fc17ba416c/scripts/slave/recipes/findit/chromium/test.py

Comment 3 by chanli@chromium.org, May 25 2016

Status: Verified (was: Assigned)

Project Member

Comment 4 by bugdroid1@chromium.org, Jun 17 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/tools/build_limited/scripts/slave/+/191ee8c114ef207e15bd3be3364c2ad2a7903fbc

commit 191ee8c114ef207e15bd3be3364c2ad2a7903fbc
Author: recipe-roller <recipe-roller@chromium.org>
Date: Sat May 21 00:18:11 2016

►

Issue 612979 link

Issue metadata

[Findit] test list too long to start try job

Issue description

Comment 1 by bugdroid1@chromium.org, May 20 2016

Comment 1 Deleted

Comment 2 by bugdroid1@chromium.org, May 21 2016

Comment 2 Deleted

Comment 3 by chanli@chromium.org, May 25 2016

Comment 3 Deleted

Comment 4 by bugdroid1@chromium.org, Jun 17 2016

Comment 4 Deleted

Sign in to add a comment