New issue
Advanced search Search tips

Issue 612962 link

Starred by 33 users
Status: Started
Owner:
atotic@chromium.org
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Task

Blocked on:
issue 674520

Show other hotlists

Hotlists containing this issue:
Nice-to-haves-for-Project-V


Sign in to add a comment

Resize Observer

Project Member Reported by atotic@chromium.org, May 18 2016 
Change description:
The Resize Observer API can be used to observe changes to Element's clientWidth and clientHeight.

Changes to API surface:
* A new interface ResizeObserver, and related Entry and Callback interfaces.

Links:

Spec: https://wicg.github.io/ResizeObserver/
Repository: https://github.com/WICG/ResizeObserver/

Public standards discussion: https://github.com/WICG/ResizeObserver/issues

Support in other browsers:
Microsoft: positive https://developer.microsoft.com/en-us/microsoft-edge/platform/status/resizeobserver/
Firefox: positive https://bugzilla.mozilla.org/show_bug.cgi?id=1272409
Safari: positive https://bugs.webkit.org/show_bug.cgi?id=157743

Comment 1 by atotic@chromium.org, May 18 2016

Labels: OWP-Standards-MailingList OWP-Design-No M-53

Comment 2 by atotic@chromium.org, May 18 2016 

Regarding support in other browsers:
we had a good discussion in CSSWG f2f. They did not hate it, and we got tracking bugs. None of the browsers signaled intent to implement.
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 19 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7d1f9d52e374d32549ace497895d3d2c7b5667b4

commit 7d1f9d52e374d32549ace497895d3d2c7b5667b4
Author: atotic <atotic@google.com>
Date: Tue Jul 19 18:45:19 2016

ResizeObserver pt1: IDLs with stubs

Full ResizeObserver implementation has been split into 7 parts for
cleaner review.

Part 1 is just ResizeObserver IDLs + stubs

Original patch archived at https://codereview.chromium.org/2005593002

BUG=612962

Review-Url: https://codereview.chromium.org/2159883003
Cr-Commit-Position: refs/heads/master@{#406333}

[modify] https://crrev.com/7d1f9d52e374d32549ace497895d3d2c7b5667b4/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/7d1f9d52e374d32549ace497895d3d2c7b5667b4/third_party/WebKit/Source/core/core.gypi
[add] https://crrev.com/7d1f9d52e374d32549ace497895d3d2c7b5667b4/third_party/WebKit/Source/core/observer/ResizeObserver.cpp
[add] https://crrev.com/7d1f9d52e374d32549ace497895d3d2c7b5667b4/third_party/WebKit/Source/core/observer/ResizeObserver.h
[add] https://crrev.com/7d1f9d52e374d32549ace497895d3d2c7b5667b4/third_party/WebKit/Source/core/observer/ResizeObserver.idl
[add] https://crrev.com/7d1f9d52e374d32549ace497895d3d2c7b5667b4/third_party/WebKit/Source/core/observer/ResizeObserverCallback.h
[add] https://crrev.com/7d1f9d52e374d32549ace497895d3d2c7b5667b4/third_party/WebKit/Source/core/observer/ResizeObserverCallback.idl
[add] https://crrev.com/7d1f9d52e374d32549ace497895d3d2c7b5667b4/third_party/WebKit/Source/core/observer/ResizeObserverEntry.cpp
[add] https://crrev.com/7d1f9d52e374d32549ace497895d3d2c7b5667b4/third_party/WebKit/Source/core/observer/ResizeObserverEntry.h
[add] https://crrev.com/7d1f9d52e374d32549ace497895d3d2c7b5667b4/third_party/WebKit/Source/core/observer/ResizeObserverEntry.idl
[modify] https://crrev.com/7d1f9d52e374d32549ace497895d3d2c7b5667b4/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 22 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6c23d97a65d8568329a386bd1da1df27d8d0a893

commit 6c23d97a65d8568329a386bd1da1df27d8d0a893
Author: atotic <atotic@google.com>
Date: Fri Jul 22 06:50:33 2016

ResizeObserver implementation, part 2: lifetime

The plot thickens:

This checkin introduces all the classes, and the links
between them. The links are important for object
lifetime management. Lifetime architecture is described
at
https://docs.google.com/document/d/1G4OmqqlFY3H3erQAUmteKES02-bIECikDjWBrDKH9PA/edit?usp=sharing

BUG=612962

ResizeObserver: conecting Objects
Review-Url: https://codereview.chromium.org/2161313002
Cr-Commit-Position: refs/heads/master@{#407088}

[modify] https://crrev.com/6c23d97a65d8568329a386bd1da1df27d8d0a893/third_party/WebKit/Source/core/core.gypi
[modify] https://crrev.com/6c23d97a65d8568329a386bd1da1df27d8d0a893/third_party/WebKit/Source/core/dom/Document.cpp
[modify] https://crrev.com/6c23d97a65d8568329a386bd1da1df27d8d0a893/third_party/WebKit/Source/core/dom/Document.h
[modify] https://crrev.com/6c23d97a65d8568329a386bd1da1df27d8d0a893/third_party/WebKit/Source/core/dom/Element.cpp
[modify] https://crrev.com/6c23d97a65d8568329a386bd1da1df27d8d0a893/third_party/WebKit/Source/core/dom/Element.h
[modify] https://crrev.com/6c23d97a65d8568329a386bd1da1df27d8d0a893/third_party/WebKit/Source/core/dom/ElementRareData.cpp
[modify] https://crrev.com/6c23d97a65d8568329a386bd1da1df27d8d0a893/third_party/WebKit/Source/core/dom/ElementRareData.h
[add] https://crrev.com/6c23d97a65d8568329a386bd1da1df27d8d0a893/third_party/WebKit/Source/core/observer/ResizeObservation.cpp
[add] https://crrev.com/6c23d97a65d8568329a386bd1da1df27d8d0a893/third_party/WebKit/Source/core/observer/ResizeObservation.h
[modify] https://crrev.com/6c23d97a65d8568329a386bd1da1df27d8d0a893/third_party/WebKit/Source/core/observer/ResizeObserver.cpp
[modify] https://crrev.com/6c23d97a65d8568329a386bd1da1df27d8d0a893/third_party/WebKit/Source/core/observer/ResizeObserver.h
[add] https://crrev.com/6c23d97a65d8568329a386bd1da1df27d8d0a893/third_party/WebKit/Source/core/observer/ResizeObserverController.cpp
[add] https://crrev.com/6c23d97a65d8568329a386bd1da1df27d8d0a893/third_party/WebKit/Source/core/observer/ResizeObserverController.h
[modify] https://crrev.com/6c23d97a65d8568329a386bd1da1df27d8d0a893/third_party/WebKit/Source/core/observer/ResizeObserverEntry.cpp
[modify] https://crrev.com/6c23d97a65d8568329a386bd1da1df27d8d0a893/third_party/WebKit/Source/core/observer/ResizeObserverEntry.h
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 26 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/03e20c08515f228ac05c74aca0645d3bf6ab1598

commit 03e20c08515f228ac05c74aca0645d3bf6ab1598
Author: atotic <atotic@google.com>
Date: Tue Jul 26 08:29:07 2016

ResizeObserver pt3: observation computation

This patch fills in ResizeObservation functionality:
- computing/setting observation size
- determining target depth

ResizeObservation::getTargetSize is static because it will also
get used by ResizeObserverEntry

I've also included basic C++ tests.

BUG=612962

Review-Url: https://codereview.chromium.org/2173203002
Cr-Commit-Position: refs/heads/master@{#407736}

[modify] https://crrev.com/03e20c08515f228ac05c74aca0645d3bf6ab1598/third_party/WebKit/Source/core/observer/ResizeObservation.cpp
[modify] https://crrev.com/03e20c08515f228ac05c74aca0645d3bf6ab1598/third_party/WebKit/Source/core/observer/ResizeObservation.h
[modify] https://crrev.com/03e20c08515f228ac05c74aca0645d3bf6ab1598/third_party/WebKit/Source/core/observer/ResizeObserver.h
[add] https://crrev.com/03e20c08515f228ac05c74aca0645d3bf6ab1598/third_party/WebKit/Source/web/tests/ResizeObserverTest.cpp
[modify] https://crrev.com/03e20c08515f228ac05c74aca0645d3bf6ab1598/third_party/WebKit/Source/web/web.gypi
Project Member

Comment 6 by bugdroid1@chromium.org, Jul 26 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a254bd8afdb92836a9b626cd5ff0789bb932d2ce

commit a254bd8afdb92836a9b626cd5ff0789bb932d2ce
Author: atotic <atotic@google.com>
Date: Tue Jul 26 23:42:03 2016

ResizeObserver pt4: IDL methods

Implements ResizeObserver and ResizeObserverEntry IDL calls.

observe/unobserver connect ResizeObserver and Element through ElementRareData.
ElementRareData has a map (ResizeObserver->ResizeObservation)

Design doc at: https://docs.google.com/document/d/1G4OmqqlFY3H3erQAUmteKES02-bIECikDjWBrDKH9PA/edit?usp=sharing
BUG=612962

Review-Url: https://codereview.chromium.org/2185533004
Cr-Commit-Position: refs/heads/master@{#407973}

[modify] https://crrev.com/a254bd8afdb92836a9b626cd5ff0789bb932d2ce/third_party/WebKit/Source/core/observer/ResizeObserver.cpp
[modify] https://crrev.com/a254bd8afdb92836a9b626cd5ff0789bb932d2ce/third_party/WebKit/Source/core/observer/ResizeObserverEntry.cpp
[modify] https://crrev.com/a254bd8afdb92836a9b626cd5ff0789bb932d2ce/third_party/WebKit/Source/core/observer/ResizeObserverEntry.h
Project Member

Comment 7 by bugdroid1@chromium.org, Jul 30 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3d5b99673799a3067e9a5b8621f2b9ef2ff5d5d5

commit 3d5b99673799a3067e9a5b8621f2b9ef2ff5d5d5
Author: atotic <atotic@google.com>
Date: Sat Jul 30 07:03:29 2016

ResizeObserver pt5: size change notification

This change implements size change notification algorithm.
Design doc at https://docs.google.com/document/d/1G4OmqqlFY3H3erQAUmteKES02-bIECikDjWBrDKH9PA/edit?usp=sharing

Size change notification
We collect and deliver notifications about all Elements
whose size has changed inside the event loop.
The algorithm loops until all notifications are delivered,
or it hits the depth limit.

c = ResizeObserverController();
for (limit = c.gatherObservations(0);
      limit != ResizeObserverController::kDepthLimit;
      limit = c.gatherObservations(limit)) {
      	c.deliverObservations();
      }
      if (c.skippedObservations()) {
        c.clearObservations();
        sendError()
      }

For efficiency, we avoid continuosly polling all elements
for size changes. Instead, an Element notifies ResizeObservation
when its size might have changed. ResizeObservation propagates
this change to ResizeObserver, which propagates to
ResizeObserverController. All of them set a flag indicating that
they might have been changed.
The flag is cleared when observations are delivered.

BUG=612962

Review-Url: https://codereview.chromium.org/2188983003
Cr-Commit-Position: refs/heads/master@{#408867}

[modify] https://crrev.com/3d5b99673799a3067e9a5b8621f2b9ef2ff5d5d5/third_party/WebKit/Source/core/observer/ResizeObservation.cpp
[modify] https://crrev.com/3d5b99673799a3067e9a5b8621f2b9ef2ff5d5d5/third_party/WebKit/Source/core/observer/ResizeObservation.h
[modify] https://crrev.com/3d5b99673799a3067e9a5b8621f2b9ef2ff5d5d5/third_party/WebKit/Source/core/observer/ResizeObserver.cpp
[modify] https://crrev.com/3d5b99673799a3067e9a5b8621f2b9ef2ff5d5d5/third_party/WebKit/Source/core/observer/ResizeObserver.h
[modify] https://crrev.com/3d5b99673799a3067e9a5b8621f2b9ef2ff5d5d5/third_party/WebKit/Source/core/observer/ResizeObserverController.cpp
[modify] https://crrev.com/3d5b99673799a3067e9a5b8621f2b9ef2ff5d5d5/third_party/WebKit/Source/core/observer/ResizeObserverController.h
Project Member

Comment 8 by bugdroid1@chromium.org, Aug 12 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5b49641e336ba9be7789cc0eb2511d415f4e6d5d

commit 5b49641e336ba9be7789cc0eb2511d415f4e6d5d
Author: atotic <atotic@google.com>
Date: Fri Aug 12 17:42:46 2016

ResizeObserver pt6: integration

Integrates ResizeObserver with the browser.

1) Element notifies ResizeObserver when its size might have changed.

Operations that might change Element's observed size are trapped:
Element::detachLayoutTree traps Element removal from DOM tree
LayoutObject::setMayNeedPaintInvalidation traps size changes

2) Event loop integration

FrameView::notifyResizeObserver implements it per spec.
https://wicg.github.io/ResizeObserver/#html-event-loop

3) Tests

LayoutTests/resize-observer is a comprehensive test suite.

BUG=612962

Review-Url: https://codereview.chromium.org/2204503002
Cr-Commit-Position: refs/heads/master@{#411694}

[add] https://crrev.com/5b49641e336ba9be7789cc0eb2511d415f4e6d5d/third_party/WebKit/LayoutTests/resize-observer/eventloop.html
[add] https://crrev.com/5b49641e336ba9be7789cc0eb2511d415f4e6d5d/third_party/WebKit/LayoutTests/resize-observer/notify.html
[add] https://crrev.com/5b49641e336ba9be7789cc0eb2511d415f4e6d5d/third_party/WebKit/LayoutTests/resize-observer/observe.html
[add] https://crrev.com/5b49641e336ba9be7789cc0eb2511d415f4e6d5d/third_party/WebKit/LayoutTests/resize-observer/resources/iframe.html
[add] https://crrev.com/5b49641e336ba9be7789cc0eb2511d415f4e6d5d/third_party/WebKit/LayoutTests/resize-observer/resources/resizeTestHelper.js
[add] https://crrev.com/5b49641e336ba9be7789cc0eb2511d415f4e6d5d/third_party/WebKit/LayoutTests/resize-observer/svg.html
[modify] https://crrev.com/5b49641e336ba9be7789cc0eb2511d415f4e6d5d/third_party/WebKit/Source/core/dom/Element.cpp
[modify] https://crrev.com/5b49641e336ba9be7789cc0eb2511d415f4e6d5d/third_party/WebKit/Source/core/dom/Element.h
[modify] https://crrev.com/5b49641e336ba9be7789cc0eb2511d415f4e6d5d/third_party/WebKit/Source/core/frame/FrameView.cpp
[modify] https://crrev.com/5b49641e336ba9be7789cc0eb2511d415f4e6d5d/third_party/WebKit/Source/core/frame/FrameView.h
[modify] https://crrev.com/5b49641e336ba9be7789cc0eb2511d415f4e6d5d/third_party/WebKit/Source/core/layout/LayoutBox.cpp
[modify] https://crrev.com/5b49641e336ba9be7789cc0eb2511d415f4e6d5d/third_party/WebKit/Source/core/layout/LayoutBox.h
[modify] https://crrev.com/5b49641e336ba9be7789cc0eb2511d415f4e6d5d/third_party/WebKit/Source/core/layout/svg/LayoutSVGContainer.cpp
[modify] https://crrev.com/5b49641e336ba9be7789cc0eb2511d415f4e6d5d/third_party/WebKit/Source/core/layout/svg/LayoutSVGEllipse.cpp
[modify] https://crrev.com/5b49641e336ba9be7789cc0eb2511d415f4e6d5d/third_party/WebKit/Source/core/layout/svg/LayoutSVGImage.cpp
[modify] https://crrev.com/5b49641e336ba9be7789cc0eb2511d415f4e6d5d/third_party/WebKit/Source/core/layout/svg/LayoutSVGPath.cpp
[modify] https://crrev.com/5b49641e336ba9be7789cc0eb2511d415f4e6d5d/third_party/WebKit/Source/core/layout/svg/LayoutSVGRect.cpp
[modify] https://crrev.com/5b49641e336ba9be7789cc0eb2511d415f4e6d5d/third_party/WebKit/Source/core/layout/svg/LayoutSVGShape.cpp
Project Member

Comment 9 by bugdroid1@chromium.org, Aug 16 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3f41316c60eb95369602fde0ebf52e935a3a91d5

commit 3f41316c60eb95369602fde0ebf52e935a3a91d5
Author: atotic <atotic@google.com>
Date: Tue Aug 16 03:00:07 2016

ResizeObserver pt6: integration

Integrates ResizeObserver with the browser.

1) Element notifies ResizeObserver when its size might have changed.

Operations that might change Element's observed size are trapped:
Element::detachLayoutTree traps Element removal from DOM tree
LayoutObject::setMayNeedPaintInvalidation traps size changes

2) Event loop integration

FrameView::notifyResizeObserver implements it per spec.
https://wicg.github.io/ResizeObserver/#html-event-loop

3) Tests

LayoutTests/resize-observer is a comprehensive test suite.

BUG=612962

Committed: https://crrev.com/5b49641e336ba9be7789cc0eb2511d415f4e6d5d
Review-Url: https://codereview.chromium.org/2204503002
Cr-Original-Commit-Position: refs/heads/master@{#411694}
Cr-Commit-Position: refs/heads/master@{#412149}

[add] https://crrev.com/3f41316c60eb95369602fde0ebf52e935a3a91d5/third_party/WebKit/LayoutTests/resize-observer/eventloop.html
[add] https://crrev.com/3f41316c60eb95369602fde0ebf52e935a3a91d5/third_party/WebKit/LayoutTests/resize-observer/notify.html
[add] https://crrev.com/3f41316c60eb95369602fde0ebf52e935a3a91d5/third_party/WebKit/LayoutTests/resize-observer/observe.html
[add] https://crrev.com/3f41316c60eb95369602fde0ebf52e935a3a91d5/third_party/WebKit/LayoutTests/resize-observer/resources/iframe.html
[add] https://crrev.com/3f41316c60eb95369602fde0ebf52e935a3a91d5/third_party/WebKit/LayoutTests/resize-observer/resources/resizeTestHelper.js
[add] https://crrev.com/3f41316c60eb95369602fde0ebf52e935a3a91d5/third_party/WebKit/LayoutTests/resize-observer/svg.html
[modify] https://crrev.com/3f41316c60eb95369602fde0ebf52e935a3a91d5/third_party/WebKit/Source/core/dom/Element.cpp
[modify] https://crrev.com/3f41316c60eb95369602fde0ebf52e935a3a91d5/third_party/WebKit/Source/core/dom/Element.h
[modify] https://crrev.com/3f41316c60eb95369602fde0ebf52e935a3a91d5/third_party/WebKit/Source/core/frame/FrameView.cpp
[modify] https://crrev.com/3f41316c60eb95369602fde0ebf52e935a3a91d5/third_party/WebKit/Source/core/frame/FrameView.h
[modify] https://crrev.com/3f41316c60eb95369602fde0ebf52e935a3a91d5/third_party/WebKit/Source/core/layout/LayoutBox.cpp
[modify] https://crrev.com/3f41316c60eb95369602fde0ebf52e935a3a91d5/third_party/WebKit/Source/core/layout/LayoutBox.h
[modify] https://crrev.com/3f41316c60eb95369602fde0ebf52e935a3a91d5/third_party/WebKit/Source/core/layout/svg/LayoutSVGContainer.cpp
[modify] https://crrev.com/3f41316c60eb95369602fde0ebf52e935a3a91d5/third_party/WebKit/Source/core/layout/svg/LayoutSVGEllipse.cpp
[modify] https://crrev.com/3f41316c60eb95369602fde0ebf52e935a3a91d5/third_party/WebKit/Source/core/layout/svg/LayoutSVGImage.cpp
[modify] https://crrev.com/3f41316c60eb95369602fde0ebf52e935a3a91d5/third_party/WebKit/Source/core/layout/svg/LayoutSVGPath.cpp
[modify] https://crrev.com/3f41316c60eb95369602fde0ebf52e935a3a91d5/third_party/WebKit/Source/core/layout/svg/LayoutSVGRect.cpp
[modify] https://crrev.com/3f41316c60eb95369602fde0ebf52e935a3a91d5/third_party/WebKit/Source/core/layout/svg/LayoutSVGShape.cpp

Comment 10 by cvrebert@google.com, Aug 29 2016 

The chromestatus entry for this feature seems to have the wrong launch bug link.
https://www.chromestatus.com/feature/5705346022637568 links to  issue 540528  instead of to this issue.

Comment 11 Deleted

Comment 12 Deleted

Comment 13 by atotic@chromium.org, Aug 29 2016 

Fixed, thanks.

Comment 14 by que....@gmail.com, Aug 30 2016 

I've raised two issues:
 issue 641353 
 issue 641364 

Not sure though if it's not too early to file bugs.
Project Member

Comment 15 by bugdroid1@chromium.org, Aug 31 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/01cdf399a2720f0ac49cd3512c0cdfc8b0439f68

commit 01cdf399a2720f0ac49cd3512c0cdfc8b0439f68
Author: atotic <atotic@google.com>
Date: Wed Aug 31 19:09:58 2016

A new C++ test for ResizeObserver GC.

It tests whether ResizeObserver is kept alive by:
- direct javascript reference
- observing a live element.

BUG=612962

Review-Url: https://codereview.chromium.org/2272163003
Cr-Commit-Position: refs/heads/master@{#415711}

[modify] https://crrev.com/01cdf399a2720f0ac49cd3512c0cdfc8b0439f68/third_party/WebKit/Source/core/observer/ResizeObserverController.h
[modify] https://crrev.com/01cdf399a2720f0ac49cd3512c0cdfc8b0439f68/third_party/WebKit/Source/web/tests/ResizeObserverTest.cpp

Comment 16 by christop...@gmx.com, Oct 23 2016 

I just reported  Issue 658593 . Could you have a look? ;)

Comment 17 by foolip@chromium.org, Dec 15 2016

Blockedon: 674520

Comment 18 by manuelch...@gmail.com, Aug 27 2017 

Any progress on this? I would really like to see this being standard.

Comment 19 by atotic@chromium.org, Aug 28 2017 

All bugs have been fixed. Making our way through release process. Currently inside a TAG review:

https://github.com/w3ctag/design-reviews/issues/187
Project Member

Comment 20 by bugdroid1@chromium.org, Sep 1 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bd8bd7e7ba3f4283499e576d080549ac6f34cf60

commit bd8bd7e7ba3f4283499e576d080549ac6f34cf60
Author: Aleks Totic <atotic@chromium.org>
Date: Fri Sep 01 22:42:22 2017

Add OWNERS to resize-observer

Bug: 612962
Change-Id: I672c800d9bf1612d90fa06bc97c3e9f512c9e096
Reviewed-on: https://chromium-review.googlesource.com/611319
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Aleks Totic <atotic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#499332}
[add] https://crrev.com/bd8bd7e7ba3f4283499e576d080549ac6f34cf60/third_party/WebKit/Source/core/resize_observer/OWNERS

Comment 21 by owe...@chromium.org, Sep 12 2017

Labels: migrated-launch-owp Type-Task
This issue has been automatically relabelled type=task because type=launch-owp issues are now officially deprecated. The deprecation is because they were creating confusion about how to get launch approvals, which should be instead done via type=launch issues.

We recommend this issue be used for implementation tracking (for public visibility), but if you already have an issue for that, you may mark this as duplicate.

For more details see here: https://docs.google.com/document/d/1JA6RohjtZQc26bTrGoIE_bSXGXUDQz8vc6G0n_sZJ2o/edit

For any questions, please contact owencm, sshruthi, larforge
Project Member

Comment 22 by bugdroid1@chromium.org, Oct 5 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2206513a2fffdefa2d06f26970bee8f9c8411d5b

commit 2206513a2fffdefa2d06f26970bee8f9c8411d5b
Author: Aleks Totic <atotic@chromium.org>
Date: Thu Oct 05 19:10:58 2017

Remove tests that have moved to w-p-t

Bug: 612962
Change-Id: Idd15d1639defb4bd3cf56795b57b9f3a4f55379d
Reviewed-on: https://chromium-review.googlesource.com/702676
Reviewed-by: Stefan Zager <szager@chromium.org>
Commit-Queue: Aleks Totic <atotic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506814}
[add] https://crrev.com/2206513a2fffdefa2d06f26970bee8f9c8411d5b/third_party/WebKit/LayoutTests/resize-observer/README.md
[delete] https://crrev.com/26890b79728a397abe884bd3d403f7e7a8623dad/third_party/WebKit/LayoutTests/resize-observer/eventloop.html
[delete] https://crrev.com/26890b79728a397abe884bd3d403f7e7a8623dad/third_party/WebKit/LayoutTests/resize-observer/notify.html
[delete] https://crrev.com/26890b79728a397abe884bd3d403f7e7a8623dad/third_party/WebKit/LayoutTests/resize-observer/observe.html
[delete] https://crrev.com/26890b79728a397abe884bd3d403f7e7a8623dad/third_party/WebKit/LayoutTests/resize-observer/resources/iframe.html
[delete] https://crrev.com/26890b79728a397abe884bd3d403f7e7a8623dad/third_party/WebKit/LayoutTests/resize-observer/resources/resizeTestHelper.js
[delete] https://crrev.com/26890b79728a397abe884bd3d403f7e7a8623dad/third_party/WebKit/LayoutTests/resize-observer/svg.html
[delete] https://crrev.com/26890b79728a397abe884bd3d403f7e7a8623dad/third_party/WebKit/LayoutTests/resize-observer/zoom.html
Project Member

Comment 23 by bugdroid1@chromium.org, Nov 9 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a68c1ce6a94d486f19099c7255b4fe9f17553f33

commit a68c1ce6a94d486f19099c7255b4fe9f17553f33
Author: Aleks Totic <atotic@chromium.org>
Date: Thu Nov 09 18:03:56 2017

Enable ResizeObserver

Promotes ResizeObserver to stable

Intent to ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/z6ienONUb5A

LGTM1 from dglazgov, LGTM2 from foolip, LGTM3 from chrishtr on Oct 17

Bug: 612962
Change-Id: I3dc59fd0ab725acc6f40bf5a3bbd70de5e889f0f
Reviewed-on: https://chromium-review.googlesource.com/754562
Commit-Queue: Aleks Totic <atotic@chromium.org>
Reviewed-by: Yoav Weiss <yoav@yoav.ws>
Cr-Commit-Position: refs/heads/master@{#515203}
[modify] https://crrev.com/a68c1ce6a94d486f19099c7255b4fe9f17553f33/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/a68c1ce6a94d486f19099c7255b4fe9f17553f33/third_party/WebKit/Source/platform/runtime_enabled_features.json5
Project Member

Comment 26 by bugdroid1@chromium.org, Oct 16

Labels: merge-merged-3578
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a44c6b4a7968dd4fd83230f313de9659294515fe

commit a44c6b4a7968dd4fd83230f313de9659294515fe
Author: Aleks Totic <atotic@chromium.org>
Date: Tue Oct 16 19:46:20 2018

Add ResizeObserver use counter

Bug: 612962,  895543 
Change-Id: I794b3010dd4d234f81be025987cda38b134aae4e
Reviewed-on: https://chromium-review.googlesource.com/c/1279355
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#599491}(cherry picked from commit 230b55644cf60b11bb6ae6c32adac7f9a317d1a9)
Reviewed-on: https://chromium-review.googlesource.com/c/1284068
Reviewed-by: Aleks Totic <atotic@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#57}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
[modify] https://crrev.com/a44c6b4a7968dd4fd83230f313de9659294515fe/third_party/blink/public/platform/web_feature.mojom
[modify] https://crrev.com/a44c6b4a7968dd4fd83230f313de9659294515fe/third_party/blink/renderer/core/resize_observer/resize_observer.idl
[modify] https://crrev.com/a44c6b4a7968dd4fd83230f313de9659294515fe/tools/metrics/histograms/enums.xml
Project Member

Comment 27 by cr-audit...@appspot.gserviceaccount.com, Oct 23

Labels: Merge-Merged-71-3578
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/a44c6b4a7968dd4fd83230f313de9659294515fe

Commit: a44c6b4a7968dd4fd83230f313de9659294515fe
Author: atotic@chromium.org
Commiter: govind@chromium.org
Date: 2018-10-16 19:46:20 +0000 UTC

Add ResizeObserver use counter

Bug: 612962,  895543 
Change-Id: I794b3010dd4d234f81be025987cda38b134aae4e
Reviewed-on: https://chromium-review.googlesource.com/c/1279355
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#599491}(cherry picked from commit 230b55644cf60b11bb6ae6c32adac7f9a317d1a9)
Reviewed-on: https://chromium-review.googlesource.com/c/1284068
Reviewed-by: Aleks Totic <atotic@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#57}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
►

Sign in to add a comment