New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 612949 link

Starred by 1 user
Status: Fixed
Owner:
█ aschulman@chromium.org
Last visit > 30 days ago
Closed: May 2016
Cc:
charliea@chromium.org
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

BattOr agent goes into infinite loop when it receives EOF (CTRL-D)

Project Member Reported by aschulman@chromium.org, May 18 2016 
What steps will reproduce the problem?
(1) Run ./battor_agent
(2) Hit CTRL-D

When BattOr agent receives an EOF it should exit but instead it goes into an infinite loop printing the usage dialog. This is due to the battor agent not handling the EOF character.

Please use labels and text to provide additional information.
Project Member

Comment 1 by bugdroid1@chromium.org, May 19 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fd630bed0f920d344d94349b11201183bf025eaa

commit fd630bed0f920d344d94349b11201183bf025eaa
Author: aschulman <aschulman@chromium.org>
Date: Thu May 19 15:38:36 2016

Make BattOr agent properly handle EOF

The BattOr agent didn't handle an EOF as input (CTRL-D) and it would go into an infinite loop
printing the agent's usage when it received EOF. This fix is needed because it is impossible to
script the BattOr agent when it doesn't exit on EOF.

BUG= 612949 

Review-Url: https://codereview.chromium.org/1994783002
Cr-Commit-Position: refs/heads/master@{#394778}

[modify] https://crrev.com/fd630bed0f920d344d94349b11201183bf025eaa/tools/battor_agent/battor_agent_bin.cc

Comment 2 by aschulman@chromium.org, May 19 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment