New issue
Advanced search Search tips

Issue 612942 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug

Blocking:
issue 577170



Sign in to add a comment

Refactor ChooserBubbleUiController on Mac

Project Member Reported by juncai@chromium.org, May 18 2016

Issue description

As  bug 577170  described, a chooser dialog needs to be implemented on Chrome Apps so that WebBluetooth API can be used there. Since the chooser content view is the same for WebBluetooth on desktop and Chrome Apps, it is better to pull it out of ChooserBubbleUiController on Mac so that it can be reused and thus reduce code redundancy.
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d025df067297d50a01861bf680bc67e8f4dab15d

commit d025df067297d50a01861bf680bc67e8f4dab15d
Author: juncai <juncai@chromium.org>
Date: Fri May 27 17:06:15 2016

Refactor ChooserBubbleUiController on Mac

This is part 2 of enabling the chooser UIs for Bluetooth from
Apps to enable developers to make a transition.

Since the chooser content view is the same for WebBluetooth on desktop
and Chrome Apps, it is better to pull it out of ChooserBubbleUiController
and have a class ChooserContentView that can be reused.

BUG= 612942 ,  577170 

Review-Url: https://codereview.chromium.org/1995793002
Cr-Commit-Position: refs/heads/master@{#396494}

[add] https://crrev.com/d025df067297d50a01861bf680bc67e8f4dab15d/chrome/browser/ui/cocoa/chooser_content_view.h
[add] https://crrev.com/d025df067297d50a01861bf680bc67e8f4dab15d/chrome/browser/ui/cocoa/chooser_content_view.mm
[modify] https://crrev.com/d025df067297d50a01861bf680bc67e8f4dab15d/chrome/browser/ui/cocoa/website_settings/chooser_bubble_ui_cocoa.mm
[modify] https://crrev.com/d025df067297d50a01861bf680bc67e8f4dab15d/chrome/chrome_browser_ui.gypi

Project Member

Comment 2 by bugdroid1@chromium.org, May 31 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6abb2c8a94305e390838712dd71f9c80df4ca1e7

commit 6abb2c8a94305e390838712dd71f9c80df4ca1e7
Author: tapted <tapted@chromium.org>
Date: Tue May 31 02:46:07 2016

Move chooser_content_view from mac_sources to cocoa_sources

Fixes a MacViewsBrowser link error after r396494, starting at
http://go/macviewsbuilder/builds/10865, like

Undefined symbols for architecture x86_64:
  "_OBJC_CLASS_$_ConstrainedWindowButton", referenced from:
      objc-class-ref in libbrowser_ui.a(browser_ui.chooser_content_view.o)

chooser_content_view is the Cocoa UI. MacViewsBrowser gets its UI for
this from from chooser_bubble_ui_view.*

BUG= 425229 ,  612942 
TBR=juncai@chromium.org

Review-Url: https://codereview.chromium.org/2025753002
Cr-Commit-Position: refs/heads/master@{#396771}

[modify] https://crrev.com/6abb2c8a94305e390838712dd71f9c80df4ca1e7/chrome/chrome_browser_ui.gypi

Status: Fixed (was: Started)

Sign in to add a comment