Issue metadata
Sign in to add a comment
|
Security: Wrong origin security indicators in Chrome Custom Tab |
||||||||||||||||||||||
Issue descriptionSee screenshots: An HTTP page-load gets the green lock, for some reason.
,
May 18 2016
,
May 18 2016
Was this in a particular app/OS version? I wasn't able to reproduce on my Nexus7 device.
,
May 18 2016
Using the Twitter app on Nexus 5, Android version 6.0.1, Chrome 50.0.2661.89. I am now seeing the behavior that nparker reported, where the green lock shows for 1 second and then goes away.
,
May 19 2016
,
May 19 2016
I can absolutely totally reproduce by searching for "abc7news" on Twitter and clicking on the the first tweet I see (on a Nexus 5X). Since even savvy users can't tell that the lock icon is wrong, I believe this absolutely qualifies for high severity. yusufo@, you handled Issue 525150 and related bugs; could you look into this as soon as you can?
,
May 19 2016
,
May 19 2016
I don't think this meets the definition of High, given in https://www.chromium.org/developers/severity-guidelines. It's not e.g. a UXSS. I'd call it Medium at most; I even debated calling it Low when I filed it.
,
May 19 2016
Updating RB-Dev to RB-Stable given c#8, please correct if you have any concerns. That said we should fix ASAP.
,
May 23 2016
Basically https://t.co/lPI8tRXnoD will trigger this bug in CCT's toolbar UI.
,
May 26 2016
ianwen@: Have you diagnosed the cause at all? Does this look feasible to fix quickly?
,
May 26 2016
Yes. The cause is that the icon animations happen too quickly one after the other. It is trivial to fix it. I already have a CL (~10 lines of code) and will merge it to M52.
,
May 27 2016
Once your fix is checked in, please mark bug as fixed, and ClusterFuzz should add the merge triage labels later. Merge can come later, but lets get the fix in this week (since we are in security fixit this week).
,
May 31 2016
ianwen@: Is there an ETA for that patch?
,
May 31 2016
Today or tomorrow.
,
May 31 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ba21bb8491e53472c1878e8af4f8c2aab18ce336 commit ba21bb8491e53472c1878e8af4f8c2aab18ce336 Author: ianwen <ianwen@chromium.org> Date: Tue May 31 22:37:55 2016 [Custom Tabs] Fix a bug that security icon might show for http If the security icon state changes faster than the time it takes for Android to relayout, hide animation might be called even before the security icon's visibility has been flipped. This CL fixes the bug in this scenario. BUG= 612939 Review-Url: https://codereview.chromium.org/2024173003 Cr-Commit-Position: refs/heads/master@{#396957} [modify] https://crrev.com/ba21bb8491e53472c1878e8af4f8c2aab18ce336/chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbarAnimationDelegate.java
,
Jun 1 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4376e086baffb084b6e5fe02e011fbe466bc1853 commit 4376e086baffb084b6e5fe02e011fbe466bc1853 Author: Ian Wen <ianwen@google.com> Date: Wed Jun 01 18:41:03 2016 [Custom Tabs] Fix a bug that security icon might show for http If the security icon state changes faster than the time it takes for Android to relayout, hide animation might be called even before the security icon's visibility has been flipped. This CL fixes the bug in this scenario. BUG= 612939 Review-Url: https://codereview.chromium.org/2024173003 Cr-Commit-Position: refs/heads/master@{#396957} TBR=yusufo@chromium.org Review URL: https://codereview.chromium.org/2027843003 . Cr-Commit-Position: refs/branch-heads/2743@{#169} Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939} [modify] https://crrev.com/4376e086baffb084b6e5fe02e011fbe466bc1853/chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbarAnimationDelegate.java
,
Jun 1 2016
Fixed in M53 and merged to M52. Please verify.
,
Jun 1 2016
,
Jun 1 2016
,
Jul 19 2016
,
Sep 8 2016
This bug has been closed for more than 14 weeks. Removing security view restrictions. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 1 2016
This bug has been closed for more than 14 weeks. Removing security view restrictions. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 2 2016
This bug has been closed for more than 14 weeks. Removing security view restrictions. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 2 2016
,
Dec 9 2016
Security>UX component is deprecated in favor of the Team-Security-UX label |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by palmer@chromium.org
, May 18 2016266 KB
266 KB View Download
162 KB
162 KB View Download