New issue
Advanced search Search tips

Issue 612936 link

Starred by 2 users
Status: Available
Owner: ----
Cc:
pbos@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Draw window frame programmatically

Project Member Reported by pkasting@chromium.org, May 18 2016 
We have a variety of window frames.  Pre-MD the glass and opaque frames blended the toolbar into the window frame with rounded corners and a client edge.  In MD a lot of this has gotten squared off, but we still need to take a close look at all the following cases to make sure the interaction is how we want it:

* Win 7 Aero vs. Win 8 vs. custom (opaque frame) themes
* Normal vs. popup windows

Comment 1 by bsep@chromium.org, Jul 8 2016

Labels: -Pri-1 -M-53 M-54 Pri-3
I took a look at the MD frame style in Windows 7 and with the opaque frame and it mostly looks fine. Popups are basically identical to pre-MD.

I did notice that the toolbar top separator and the content sides don't quite join at the corner; there's a pixel "missing" that would otherwise make a square join. From what I can tell we don't actually want a square join though, we want a very slight rounded fade like we have on the bottom corners (see attached mockup).

However the content border is drawn with images, so it's hard to adjust. Especially because the toolbar top separator is a hairline in MD so it will never be a seamless join at dsf >1.

At any rate, since this issue is very minor and doing the thing we want isn't straightforward I'm dropping priority on this.
rounded-mockup.png
2.1 KB View Download

Comment 2 by pkasting@chromium.org, Jul 8 2016

Blocking: -495654
Labels: -Proj-MaterialDesign-NativeUI
Summary: Draw window frame programmatically (was: Figure out toolbar/window frame interaction in MD)
I'm morphing this bug to be about removing all the frame border images and drawing programmatically instead, which will include doing whatever fading out at the corner we want.
Project Member

Comment 3 by sheriffbot@chromium.org, Jul 10 2017

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 4 by pkasting@chromium.org, Jul 10 2017

Components: -UI>Browser>Toolbar UI>Browser
Labels: -Hotlist-Recharge-Cold -M-54 OS-Chrome OS-Linux
Status: Available (was: Untriaged)
Project Member

Comment 5 by sheriffbot@chromium.org, Jul 11

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 6 by pkasting@chromium.org, Jul 11

Cc: pbos@chromium.org
Status: Available (was: Untriaged)
We may be able to tackle this more easily post-refresh, as we're removing the interior frame border images in that mode.
►

Sign in to add a comment