New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 612886 link

Starred by 1 user
Status: Fixed
Owner:
igorcov@chromium.org
Closed: Dec 2016
Cc:
emaxx@chromium.org
█ dskaram@chromium.org
isandrk@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Linux , Chrome
Pri: 2
Type: Feature

Blocking:
issue 612884



Sign in to add a comment

[User Sessions] chrome.certificateProvider.requestPIN method

Project Member Reported by dskaram@chromium.org, May 18 2016 
Smart card PIN requests are currently handled by 3rd party middleware apps (they draw the UI and handle the user input). We want to switch this to a system level call to be able to properly integrate smart card use into the various Chrome OS screens.


This bug tracks PIN entry in user sessions.

Comment 1 by igorcov@chromium.org, Jun 8 2016

Status: Started (was: Assigned)

Comment 2 by emaxx@chromium.org, Jul 29 2016

Labels: CrosExtendedLogin
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 1 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bb898fb7cb786880d780d53c9d0d98ddeb37d491

commit bb898fb7cb786880d780d53c9d0d98ddeb37d491
Author: igorcov <igorcov@chromium.org>
Date: Thu Dec 01 16:07:56 2016

Implementation for chrome.certificateProvider.requestPin/stopPinRequest

The IDL for proposed API has been reviewed: https://codereview.chromium.org/2174423002/

This is the actual implementation of the API. The dialog to request PIN is defined in request_pin_view.h

The CertificateProviderApi is receiving the requests from extensions and uses the service object to manage the view. CertificateProviderService object keeps the state of the view and forwards updates to it. And the RequestPinView is notifying the CertificateProviderApi about the user input through callback.

BUG= 612886 

Review-Url: https://codereview.chromium.org/2094333002
Cr-Commit-Position: refs/heads/master@{#435620}

[modify] https://crrev.com/bb898fb7cb786880d780d53c9d0d98ddeb37d491/chrome/app/chromeos_strings.grdp
[modify] https://crrev.com/bb898fb7cb786880d780d53c9d0d98ddeb37d491/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/bb898fb7cb786880d780d53c9d0d98ddeb37d491/chrome/browser/chromeos/certificate_provider/certificate_provider_service.cc
[modify] https://crrev.com/bb898fb7cb786880d780d53c9d0d98ddeb37d491/chrome/browser/chromeos/certificate_provider/certificate_provider_service.h
[modify] https://crrev.com/bb898fb7cb786880d780d53c9d0d98ddeb37d491/chrome/browser/chromeos/certificate_provider/certificate_provider_service_factory.cc
[add] https://crrev.com/bb898fb7cb786880d780d53c9d0d98ddeb37d491/chrome/browser/chromeos/certificate_provider/pin_dialog_manager.cc
[add] https://crrev.com/bb898fb7cb786880d780d53c9d0d98ddeb37d491/chrome/browser/chromeos/certificate_provider/pin_dialog_manager.h
[add] https://crrev.com/bb898fb7cb786880d780d53c9d0d98ddeb37d491/chrome/browser/chromeos/ui/request_pin_view.cc
[add] https://crrev.com/bb898fb7cb786880d780d53c9d0d98ddeb37d491/chrome/browser/chromeos/ui/request_pin_view.h
[modify] https://crrev.com/bb898fb7cb786880d780d53c9d0d98ddeb37d491/chrome/browser/extensions/api/certificate_provider/certificate_provider_api.cc
[modify] https://crrev.com/bb898fb7cb786880d780d53c9d0d98ddeb37d491/chrome/browser/extensions/api/certificate_provider/certificate_provider_api.h
[modify] https://crrev.com/bb898fb7cb786880d780d53c9d0d98ddeb37d491/chrome/browser/extensions/api/certificate_provider/certificate_provider_apitest.cc
[modify] https://crrev.com/bb898fb7cb786880d780d53c9d0d98ddeb37d491/chrome/common/extensions/api/certificate_provider.idl
[add] https://crrev.com/bb898fb7cb786880d780d53c9d0d98ddeb37d491/chrome/test/data/extensions/api_test/certificate_provider/request_pin/basic.html
[add] https://crrev.com/bb898fb7cb786880d780d53c9d0d98ddeb37d491/chrome/test/data/extensions/api_test/certificate_provider/request_pin/basic.js
[add] https://crrev.com/bb898fb7cb786880d780d53c9d0d98ddeb37d491/chrome/test/data/extensions/api_test/certificate_provider/request_pin/basic_lock.html
[add] https://crrev.com/bb898fb7cb786880d780d53c9d0d98ddeb37d491/chrome/test/data/extensions/api_test/certificate_provider/request_pin/basic_lock.js
[add] https://crrev.com/bb898fb7cb786880d780d53c9d0d98ddeb37d491/chrome/test/data/extensions/api_test/certificate_provider/request_pin/manifest.json
[modify] https://crrev.com/bb898fb7cb786880d780d53c9d0d98ddeb37d491/extensions/browser/extension_function_histogram_value.h
[modify] https://crrev.com/bb898fb7cb786880d780d53c9d0d98ddeb37d491/tools/metrics/histograms/histograms.xml

Comment 4 by igorcov@chromium.org, Dec 5 2016

Status: Fixed (was: Started)
►

Sign in to add a comment