NQE: GetEffectiveConnectionType should return offline as the enum when the device is offline |
|||
Issue descriptionNQE: GetEffectiveConnectionType should return offline as the enum when the device is offline
,
May 19 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fac10c98b95475adf511e66a2e65b1b33f1daed2 commit fac10c98b95475adf511e66a2e65b1b33f1daed2 Author: tbansal <tbansal@chromium.org> Date: Thu May 19 04:17:08 2016 Revert of Return E_C_T_OFFLINE when the device is offline (patchset #1 id:20001 of https://codereview.chromium.org/1991933002/ ) Reason for revert: Tests failure https://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20MSan%20Tests/builds/16114. These tests are failing because the device is offline and this CL adds an early exit in GetEffectiveConnectionType() if the device is offline. Original issue's description: > Return E_C_T_OFFLINE when the device is offline > > Future CL will add additional logic to return E_C_T_OFFLINE > when the device is effectively offline. > > BUG= 612883 > > Committed: https://crrev.com/bf0c95b52ea71d32c4d5d38083ea978952516b0e > Cr-Commit-Position: refs/heads/master@{#394603} TBR=bengr@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 612883 Review-Url: https://codereview.chromium.org/1994863002 Cr-Commit-Position: refs/heads/master@{#394668} [modify] https://crrev.com/fac10c98b95475adf511e66a2e65b1b33f1daed2/net/nqe/network_quality_estimator.cc [modify] https://crrev.com/fac10c98b95475adf511e66a2e65b1b33f1daed2/net/nqe/network_quality_estimator_unittest.cc
,
May 21 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/20cf2cd3438a720195b78716f900c740a8d10b57 commit 20cf2cd3438a720195b78716f900c740a8d10b57 Author: tbansal <tbansal@chromium.org> Date: Sat May 21 00:17:36 2016 Return E_C_T_OFFLINE when the device is offline Future CL will add additional logic to return E_C_T_OFFLINE when the device is effectively offline. BUG= 612883 Review-Url: https://codereview.chromium.org/1998683003 Cr-Commit-Position: refs/heads/master@{#395214} [modify] https://crrev.com/20cf2cd3438a720195b78716f900c740a8d10b57/net/nqe/network_quality_estimator.cc [modify] https://crrev.com/20cf2cd3438a720195b78716f900c740a8d10b57/net/nqe/network_quality_estimator_unittest.cc
,
May 25 2016
,
Feb 14 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by bugdroid1@chromium.org
, May 18 2016