Issue metadata
Sign in to add a comment
|
42.4% regression in smoothness.top_25_smooth at 393107:393184 |
||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
May 18 2016
=== Auto-CCing suspected CL author mdjones@chromium.org === Hi mdjones@chromium.org, the bisect results pointed to your CL below as possibly causing a regression. Please have a look at this info and see whether your CL be related. ===== BISECT JOB RESULTS ===== Status: completed ===== SUSPECTED CL(s) ===== Subject : Fix smooth progress behavior on JellyBean Author : mdjones Commit description: The animators in JellyBean send a delta time fom the last time an animation played instead of 0 for the first frame after an animation starts. A combination of this and a misplaced "max" function completely derailed the smooth progress bar animation. This change also addresses a crash that only occures on JellyBean that involves early cancellation of a running animation. After the animation is canceled, the animator tries to run doAnimationFrame with an empty list of updates. The animation is now allowed to run itself out. (This should have no visible affect on the animation since it becomes transparent near completion). BUG= 611125 , 610522 Review-Url: https://codereview.chromium.org/1966943004 Cr-Commit-Position: refs/heads/master@{#393113} Commit : 2f8f44e6740bda7e9015e252db16cc869721e3a8 Date : Thu May 12 00:18:28 2016 ===== TESTED REVISIONS ===== Revision Mean Std Dev N Good? chromium@393106 10.1058 1.33966 5 good chromium@393111 10.402 0.69116 5 good chromium@393112 8.6482 1.07825 5 good chromium@393113 13.1526 0.959005 5 bad <-- chromium@393114 13.58 0.980546 5 bad chromium@393116 13.154 0.747239 5 bad chromium@393126 13.445 0.722421 5 bad chromium@393145 13.6404 1.80362 5 bad chromium@393184 13.0962 0.83783 5 bad Bisect job ran on: android_one_perf_bisect Bug ID: 612848 Test Command: src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --also-run-disabled-tests smoothness.top_25_smooth Test Metric: mean_input_event_latency/Blogger Relative Change: 29.59% Score: 99.8 Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_one_perf_bisect/builds/1320 Job details: https://chromeperf.appspot.com/buildbucket_job_status/9012310108124916192 Not what you expected? We'll investigate and get back to you! https://chromeperf.appspot.com/bad_bisect?try_job_id=5845138056675328 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Tests>AutoBisect. Thank you!
,
Jun 1 2016
Moving this nonessential bug to the next milestone. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 3 2016
mdjones@: does it seem plausible that that CL could have affected the smoothness mean_input_event_latency metric on Android one?
,
Jul 6 2016
No, that change should not affect performance in a negative way. In general the smooth animation that this change is a part of causes a regression, but that requires it being enabled through a flag.
,
Jul 6 2016
Makes sense, thanks. One of the alerts associated with this bug still looks suspicious (https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg9IuyqgoM), so I'll run another bisect job.
,
Jul 6 2016
===== BISECT JOB RESULTS ===== Status: completed === Bisection aborted === The bisect was aborted because The metric values for the initial "good" and "bad" revisions do not represent a clear regression. Please contact the the team (see below) if you believe this is in error. === Warnings === The following warnings were raised by the bisect job: * Bisect failed to reproduce the regression with enough confidence. ===== TESTED REVISIONS ===== Revision Mean Std Dev N Good? chromium@393106 13.3694 1.55934 12 good chromium@393184 16.4456 5.35905 12 bad Bisect job ran on: android_one_perf_bisect Bug ID: 612848 Test Command: src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --also-run-disabled-tests smoothness.top_25_smooth Test Metric: mean_input_event_latency/Blogger Relative Change: 0.53% Score: 0 Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_one_perf_bisect/builds/1390 Job details: https://chromeperf.appspot.com/buildbucket_job_status/9007871516542074320 Not what you expected? We'll investigate and get back to you! https://chromeperf.appspot.com/bad_bisect?try_job_id=5771967798444032 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Tests>AutoBisect. Thank you!
,
Jul 6 2016
,
Jul 6 2016
|
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by majidvp@chromium.org
, May 18 2016