New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 612847 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Feature



Sign in to add a comment

Record typed slots from old space to new space

Project Member Reported by mlippautz@chromium.org, May 18 2016

Issue description

Tracking bug for recording typed slots from old to new space.
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/768e9c509bfdbb092b392f62cc128a2a451b0490

commit 768e9c509bfdbb092b392f62cc128a2a451b0490
Author: mlippautz <mlippautz@chromium.org>
Date: Wed May 18 18:31:29 2016

[heap] Replace RELOCATED_CODE_OBJECT with proper recording

Properly records entries individually instead of using the hammer that requires
visiting the whole code object during pointer updating.

BUG= chromium:612847 
LOG=N

Review-Url: https://codereview.chromium.org/1994653002
Cr-Commit-Position: refs/heads/master@{#36334}

[modify] https://crrev.com/768e9c509bfdbb092b392f62cc128a2a451b0490/src/heap/mark-compact.cc
[modify] https://crrev.com/768e9c509bfdbb092b392f62cc128a2a451b0490/src/heap/slot-set.h

Project Member

Comment 2 by bugdroid1@chromium.org, May 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/dbca1feb4e782529a0bf144dc00cb8683d700e63

commit dbca1feb4e782529a0bf144dc00cb8683d700e63
Author: ulan <ulan@chromium.org>
Date: Wed May 18 19:24:36 2016

Refactor ObjectVisitor functions to not mutate the slot.

BUG= chromium:612847 
LOG=N

Review-Url: https://codereview.chromium.org/1989973002
Cr-Commit-Position: refs/heads/master@{#36337}

[modify] https://crrev.com/dbca1feb4e782529a0bf144dc00cb8683d700e63/src/heap/mark-compact.cc
[modify] https://crrev.com/dbca1feb4e782529a0bf144dc00cb8683d700e63/src/objects.cc

Project Member

Comment 3 by bugdroid1@chromium.org, May 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/c3a906d53bbb5da277e95d547cb0abef56b1ae46

commit c3a906d53bbb5da277e95d547cb0abef56b1ae46
Author: ulan <ulan@chromium.org>
Date: Thu May 19 11:04:27 2016

Refactor PointerUpdatingVisitor.

This patch extracts typed slot processing logic from
the PointerUpdatingVisitor to a set of functions.

Each of these functions takes an untyped slot processing function
and applies it to a typed slot.

BUG= chromium:612847 
LOG=NO

Review-Url: https://codereview.chromium.org/1991843003
Cr-Commit-Position: refs/heads/master@{#36357}

[modify] https://crrev.com/c3a906d53bbb5da277e95d547cb0abef56b1ae46/src/heap/mark-compact.cc

Status: Fixed (was: Started)
That was done a long time ago :)

Sign in to add a comment