New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 612840 link

Starred by 0 users
Status: Fixed
Owner:
lazyboy@chromium.org
Closed: May 2016
Cc:
█ dgn@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

"ServiceWorkerPushMessagingTest.OnPush" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, May 18 2016 
"ServiceWorkerPushMessagingTest.OnPush" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 4 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyMAsSBUZsYWtlIiVTZXJ2aWNlV29ya2VyUHVzaE1lc3NhZ2luZ1Rlc3QuT25QdXNoDA.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs

Comment 1 by qyears...@chromium.org, May 18 2016

Cc: lazyboy@chromium.org
Log excerpt from https://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/215699/steps/browser_tests%20%28with%20patch%29%20on%20Windows-7-SP1/logs/ServiceWorkerPushMessagingTest.OnPush:

ServiceWorkerPushMessagingTest.OnPush (run #1):
[ RUN      ] ServiceWorkerPushMessagingTest.OnPush
[5036:3276:0518/071057:WARNING:chrome_browser_main_win.cc(420)] Command line too long for RegisterApplicationRestart
[5036:3276:0518/071058:INFO:CONSOLE(25)] "SERVICE_WORKER_READY", source: chrome-extension://efdllkfolaoochenjmoeacfbgphagjba/page.js (25)
[5036:3276:0518/071058:INFO:CONSOLE(25)] "OK", source: chrome-extension://efdllkfolaoochenjmoeacfbgphagjba/page.js (25)
[5036:3276:0518/071058:INFO:CONSOLE(27)] "message: testdata", source: chrome-extension://efdllkfolaoochenjmoeacfbgphagjba/page.js (27)
[5036:3276:0518/071119:WARNING:pref_notifier_impl.cc(27)] pref observer found at shutdown plugins.always_authorize
[5036:3276:0518/071119:WARNING:pref_notifier_impl.cc(27)] pref observer found at shutdown printing.enabled
[5036:3276:0518/071119:WARNING:pref_notifier_impl.cc(27)] pref observer found at shutdown plugins.allow_outdated
[5036:3276:0518/071119:FATAL:gpu_process_transport_factory.cc(179)] Check failed: per_compositor_data_.empty().
Backtrace:
	SetCrashKeyValueImpl [0x0000000144C91FA1+3282009]
	SetCrashKeyValueImpl [0x0000000144C3A5FC+2923188]
	ovly_debug_event [0x0000000141C5254B+6938923]
	ovly_debug_event [0x0000000141C526AC+6939276]
	ovly_debug_event [0x0000000141C549CC+6948268]
	ovly_debug_event [0x00000001418C7021+3222529]
	ovly_debug_event [0x00000001418C879F+3228543]
	ovly_debug_event [0x00000001418C2706+3203814]
	SetCrashKeyValueImpl [0x00000001449992CD+165765]
	SetCrashKeyValueImpl [0x000000014499916A+165410]
	SetCrashKeyValueImpl [0x00000001449981CC+161412]
	RelaunchChromeBrowserWithNewCommandLineIfNeeded [0x000000014058BD74+5021844]
	(No symbol) [0x0000000140056EA8]
	GetHandleVerifier [0x0000000144D84879+952137]
	GetHandleVerifier [0x0000000144D91AEA+1006010]
	GetHandleVerifier [0x0000000144D91D09+1006553]
	GetHandleVerifier [0x0000000144D91BF1+1006273]
	GetHandleVerifier [0x0000000144D920AF+1007487]
	GetHandleVerifier [0x0000000144D84919+952297]
	GetHandleVerifier [0x0000000144D91E49+1006873]
	(No symbol) [0x000000014007185F]
	(No symbol) [0x0000000140049BB9]
	SetCrashKeyValueImpl [0x00000001449DD564+444956]
	(No symbol) [0x000000013F7F759B]
	IsSandboxedProcess [0x0000000145796998+7036864]
	BaseThreadInitThunk [0x0000000076CA59CD+13]
	RtlUserThreadStart [0x0000000076EDB891+33]

lazyboy@, do you know why this test might be flaky here?

Looks like the next step is to disable this test, according to the above message.

Comment 2 by lazyboy@chromium.org, May 18 2016

Owner: lazyboy@chromium.org
Status: Assigned (was: Untriaged)
Looks like the test passes, but it is crashing on shutdown. Let me take a look.

Comment 3 by lazyboy@chromium.org, May 18 2016

Cc: -lazyboy@chromium.org dgn@chromium.org
Status: Started (was: Assigned)
Seems to be caused by r394194, I can repro this locally on windows.

I have a tentative fix, seems like r394194 exposes some race in the test.
So far, waiting for the push message to be handled by push_service (push_service()->SetMessageCallbackForTesting()) seems to be working, I'll keep this issue updated.

/cc dgn@

Comment 4 by hirosh...@chromium.org, May 19 2016

Labels: -Sheriff-Chromium
Project Member

Comment 5 by chromium...@appspot.gserviceaccount.com, May 19 2016

Labels: Sheriff-Chromium
Detected 12 new flakes for test/step "ServiceWorkerPushMessagingTest.OnPush". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyMAsSBUZsYWtlIiVTZXJ2aWNlV29ya2VyUHVzaE1lc3NhZ2luZ1Rlc3QuT25QdXNoDA. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).
Project Member

Comment 6 by bugdroid1@chromium.org, May 19 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/18279a79e2481c7454fb06e391c73ae992ecbf6a

commit 18279a79e2481c7454fb06e391c73ae992ecbf6a
Author: spqchan <spqchan@chromium.org>
Date: Thu May 19 20:05:01 2016

Disable flaky ServiceWorkerPushMessagingTest.OnPush test on Windows

BUG= 612840 

TBR=sky@chromium.org

Review-Url: https://codereview.chromium.org/1996673002
Cr-Commit-Position: refs/heads/master@{#394845}

[modify] https://crrev.com/18279a79e2481c7454fb06e391c73ae992ecbf6a/chrome/browser/extensions/service_worker_apitest.cc

Comment 7 by hirosh...@chromium.org, May 20 2016

Labels: -Sheriff-Chromium
Project Member

Comment 8 by bugdroid1@chromium.org, May 20 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d429e25851e808a426a8a692525987f3da008559

commit d429e25851e808a426a8a692525987f3da008559
Author: lazyboy <lazyboy@chromium.org>
Date: Fri May 20 20:18:52 2016

Fix ServiceWorkerPushMessagingTest.OnPush.

r394194 exposed some race. It seems that waiting for a push message to
be handled by push_service() is the right thing to do.

BUG= 612840 , 612673 
Test=On Chromeos and windows, the test now always pass locally.

Review-Url: https://codereview.chromium.org/1987393003
Cr-Commit-Position: refs/heads/master@{#395153}

[modify] https://crrev.com/d429e25851e808a426a8a692525987f3da008559/chrome/browser/extensions/service_worker_apitest.cc

Comment 9 by lazyboy@chromium.org, May 23 2016

Status: Fixed (was: Started)
►

Sign in to add a comment