New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 612809 link

Starred by 1 user
Status: Fixed
Owner:
tommi@chromium.org
Closed: May 2016
Cc:
m...@chromium.org
█ perkj@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Remove 'local audio source' WebRtc references in Chrome

Project Member Reported by tommi@chromium.org, May 18 2016 
We should delete PeerConnectionDependencyFactory::CreateLocalAudioSource and references in Chrome to WebRtc's LocalAudioSource implementation.

The implementation of CreateLocalAudioSource has the side effect of initializing WebRtc's PeerConnectionFactory, which in turn can initialize a lot of internal state that relates to WebRtc but not local audio sources (i.e. getUserMedia).  The side effects can be bad such as has been seen in  issue 612366 .

Moving forward, the GetSource() method in WebRtc's AudioTrackInterface, will probably be removed, as it only applies to a corner case for remote audio sources (handling SetVolume).

Comment 1 by tommi@chromium.org, May 18 2016

Cc: m...@chromium.org
It's worth noting that Yuri recently made a change to set the audio source to null for most audio tracks, so making this change for gUM audio tracks, should be straight forward and actually make them more like other audio tracks.
Project Member

Comment 2 by bugdroid1@chromium.org, May 18 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fcfeb8bc42fa37a8875480a0581372c496a303f0

commit fcfeb8bc42fa37a8875480a0581372c496a303f0
Author: tommi <tommi@chromium.org>
Date: Wed May 18 22:25:35 2016

Remove WebRtc audio source references for local audio tracks.
Remove PeerConnectionDependencyFactory::CreateLocalAudioSource.
Remove audio source mock class that's not needed now.

BUG= 612809 , 612366 

Review-Url: https://codereview.chromium.org/1995553002
Cr-Commit-Position: refs/heads/master@{#394575}

[modify] https://crrev.com/fcfeb8bc42fa37a8875480a0581372c496a303f0/content/renderer/media/webrtc/mock_peer_connection_dependency_factory.cc
[modify] https://crrev.com/fcfeb8bc42fa37a8875480a0581372c496a303f0/content/renderer/media/webrtc/mock_peer_connection_dependency_factory.h
[modify] https://crrev.com/fcfeb8bc42fa37a8875480a0581372c496a303f0/content/renderer/media/webrtc/peer_connection_dependency_factory.cc
[modify] https://crrev.com/fcfeb8bc42fa37a8875480a0581372c496a303f0/content/renderer/media/webrtc/peer_connection_dependency_factory.h
[modify] https://crrev.com/fcfeb8bc42fa37a8875480a0581372c496a303f0/content/renderer/media/webrtc/processed_local_audio_source.cc
[modify] https://crrev.com/fcfeb8bc42fa37a8875480a0581372c496a303f0/content/renderer/media/webrtc/processed_local_audio_source.h
[modify] https://crrev.com/fcfeb8bc42fa37a8875480a0581372c496a303f0/content/renderer/media/webrtc/webrtc_media_stream_adapter.cc

Comment 3 by tommi@chromium.org, May 26 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment