New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 612760 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit 16 days ago
Closed: May 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Replace SkBitmap with gfx::Image in all of component/ntp_snippets

Project Member Reported by markusheintz@chromium.org, May 18 2016

Issue description

This will improve the performance on for iOS

 
Project Member

Comment 1 by bugdroid1@chromium.org, May 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/049dce3d29e33aa1dae4228e0cfb301c391e795b

commit 049dce3d29e33aa1dae4228e0cfb301c391e795b
Author: markusheintz <markusheintz@chromium.org>
Date: Thu May 19 08:43:27 2016

Replace SkBitmap with gfx::Image in the ImageFetcher API and the NTPSnippetsService API.
This will increase the performance on iOS.

BUG= 609127 , 612760 

Review-Url: https://codereview.chromium.org/1974013002
Cr-Commit-Position: refs/heads/master@{#394719}

[modify] https://crrev.com/049dce3d29e33aa1dae4228e0cfb301c391e795b/chrome/browser/android/ntp/ntp_snippets_bridge.cc
[modify] https://crrev.com/049dce3d29e33aa1dae4228e0cfb301c391e795b/chrome/browser/android/ntp/ntp_snippets_bridge.h
[modify] https://crrev.com/049dce3d29e33aa1dae4228e0cfb301c391e795b/chrome/browser/search/suggestions/image_fetcher_impl.cc
[modify] https://crrev.com/049dce3d29e33aa1dae4228e0cfb301c391e795b/chrome/browser/search/suggestions/image_fetcher_impl.h
[modify] https://crrev.com/049dce3d29e33aa1dae4228e0cfb301c391e795b/chrome/browser/search/suggestions/image_fetcher_impl_browsertest.cc
[modify] https://crrev.com/049dce3d29e33aa1dae4228e0cfb301c391e795b/chrome/browser/search/thumbnail_source.cc
[modify] https://crrev.com/049dce3d29e33aa1dae4228e0cfb301c391e795b/chrome/browser/search/thumbnail_source.h
[modify] https://crrev.com/049dce3d29e33aa1dae4228e0cfb301c391e795b/components/image_fetcher/image_fetcher.h
[modify] https://crrev.com/049dce3d29e33aa1dae4228e0cfb301c391e795b/components/image_fetcher/image_fetcher_delegate.h
[modify] https://crrev.com/049dce3d29e33aa1dae4228e0cfb301c391e795b/components/ntp_snippets/BUILD.gn
[modify] https://crrev.com/049dce3d29e33aa1dae4228e0cfb301c391e795b/components/ntp_snippets/DEPS
[modify] https://crrev.com/049dce3d29e33aa1dae4228e0cfb301c391e795b/components/ntp_snippets/ntp_snippets_service.cc
[modify] https://crrev.com/049dce3d29e33aa1dae4228e0cfb301c391e795b/components/ntp_snippets/ntp_snippets_service.h
[modify] https://crrev.com/049dce3d29e33aa1dae4228e0cfb301c391e795b/components/suggestions/image_manager.cc
[modify] https://crrev.com/049dce3d29e33aa1dae4228e0cfb301c391e795b/components/suggestions/image_manager.h
[modify] https://crrev.com/049dce3d29e33aa1dae4228e0cfb301c391e795b/components/suggestions/image_manager_unittest.cc
[modify] https://crrev.com/049dce3d29e33aa1dae4228e0cfb301c391e795b/ios/chrome/browser/suggestions/image_fetcher_impl.h
[modify] https://crrev.com/049dce3d29e33aa1dae4228e0cfb301c391e795b/ios/chrome/browser/suggestions/image_fetcher_impl.mm

Status: Fixed (was: Assigned)
Components: UI>Browser>NewTabPage
Labels: VerifyIn-53
Labels: VerifyIn-54

Comment 6 by ka...@chromium.org, Aug 31 2016

Labels: Bulk-Verified
Status: Verified (was: Fixed)

Sign in to add a comment