MD omnibox dropdown selection is too wide |
|||||||
Issue descriptionChrome Version : 52.0.2739.0 OS Version: 10.0 The selection in the omnibox dropdown should be the width of the omnibox. In MD, it seems to have grown to the full width of the window, which looks strange.
,
May 19 2016
Marking as WontFix, as this was an intentional change made for MD according to Sebastien's spec.
,
May 19 2016
Then I'm going to argue with Sebastien. This looks really gross.
,
Jun 1 2016
Moving this nonessential bug to the next milestone. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 8 2016
Sebastian says we can change this as long as the hover region matches the visible paint region and the corners of the selection/hover rects are rounded to match the omnibox.
,
Jun 8 2016
After discussing with peter, we'll revert to constrained selection with rounded corners to match the omnibox visuals.
,
Jun 15 2016
I have a local fix for this.
,
Jun 16 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f38647f5f74e6b04d14cbd6473201b40ed855699 commit f38647f5f74e6b04d14cbd6473201b40ed855699 Author: pkasting <pkasting@chromium.org> Date: Thu Jun 16 05:29:22 2016 Adjust BackgroundWith1PxBorder corner radius to scale properly. The ".5" in the existing radius was intended to get to the middle of the stroke, but that portion of the radius value was in px and not DIP, so scaling the whole thing wasn't correct. Instead, set the corner radius to the value of the "inner radius", then add .5 after scaling. This fixes a problem where, at larger scale factors, the focus ring's curvature was slightly different than the edge's curvature. It also very slightly changes the appearance of the corner (no one would notice without zooming in). BUG= 612758 TEST=none Review-Url: https://codereview.chromium.org/2066303003 Cr-Commit-Position: refs/heads/master@{#400089} [modify] https://crrev.com/f38647f5f74e6b04d14cbd6473201b40ed855699/chrome/browser/ui/views/location_bar/background_with_1_px_border.cc [modify] https://crrev.com/f38647f5f74e6b04d14cbd6473201b40ed855699/chrome/browser/ui/views/location_bar/background_with_1_px_border.h [modify] https://crrev.com/f38647f5f74e6b04d14cbd6473201b40ed855699/chrome/browser/ui/views/location_bar/location_bar_view.cc
,
Jun 16 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/367d9021063deb29a90571768d9b4b822f2f50be commit 367d9021063deb29a90571768d9b4b822f2f50be Author: pkasting <pkasting@chromium.org> Date: Thu Jun 16 20:55:48 2016 Update omnibox dropdown selection/hover background drawing for MD. Rather than use full-window-width selections, return to using omnibox-width selections, but with a rounded corner to match the omnibox corner shape. BUG= 612758 TEST=Type in the omnibox. The selected dropdown entry should have a selection background the same width as the omnibox, with the same rounded corners. Review-Url: https://codereview.chromium.org/2070733002 Cr-Commit-Position: refs/heads/master@{#400254} [modify] https://crrev.com/367d9021063deb29a90571768d9b4b822f2f50be/chrome/browser/ui/views/location_bar/location_bar_view.cc [modify] https://crrev.com/367d9021063deb29a90571768d9b4b822f2f50be/chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc [modify] https://crrev.com/367d9021063deb29a90571768d9b4b822f2f50be/chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.h [modify] https://crrev.com/367d9021063deb29a90571768d9b4b822f2f50be/chrome/browser/ui/views/omnibox/omnibox_result_view.cc [modify] https://crrev.com/367d9021063deb29a90571768d9b4b822f2f50be/chrome/browser/ui/views/omnibox/omnibox_result_view.h [modify] https://crrev.com/367d9021063deb29a90571768d9b4b822f2f50be/components/omnibox/browser/omnibox_popup_model.cc
,
Jun 16 2016
,
Aug 12 2016
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by pkasting@chromium.org
, May 18 2016