Issue metadata
Sign in to add a comment
|
Extension badges are unreadable
Reported by
nie.mam....@gmail.com,
May 18 2016
|
||||||||||||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 6.3; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/52.0.2739.0 Safari/537.36 Steps to reproduce the problem: 1. Display a badge from within an extension. 2. Try to read what's in it. What is the expected behavior? It should be possible to read the badge text. What went wrong? After update to 52.0.2739.0, the new toolbar styles kicked in and the padding and text size on extension badges makes the text very small and, effectively, unreadable. SCreenshot attached. Did this work before? Yes 52.0.2729.3 Chrome version: 52.0.2739.0 Channel: dev OS Version: 6.3 Flash Version: Shockwave Flash 22.0 r0
,
May 23 2016
I don't think blink is involved in this code path. Guessing this is a skia issue.
,
May 23 2016
Skia does the rendering, but is directed by the Chrome UI. We've not noticed any regressions in the Skia-specific tests with M52. What code is ordering this for Chrome - src/chrome/browser/ui/views/toolbar/extension_toolbar_menu_view.cc? Something related?
,
May 23 2016
I think this is the changes to compositor based caching and scaling of decoded images.
,
May 23 2016
Could you please give a more detailed description of how to reproduce the bug? What badge exactly? Which extension?
,
May 23 2016
Any badge, any extension. After 52.0.2729.3 -> 52.0.2739.0 update, the new styles for the toolbar appeared. These included fancy new icons (refresh/home), smaller omnibox font, margins all around and - crucially - visibly smaller extension icons. Not only these icons are smaller, but extensions badges themselves have additional padding, too, which renders the text very small. Screenshot attached to this comment is a comparison between pre-52.0.2739.0 extension toolbar (as currently seen on 51.0.2704.54 from beta channel) and the current, post-52.0.2739.0 style.
,
May 23 2016
,
May 24 2016
Verified the issue on Chrome Dev# 52.0.2739.0 and Chrome Canary# 53.0.2746.0 on Windows and could not reproduce the issue. Also navigated to chrome://flags and enable "Material Design in the browser's top chrome" and did not observe the issue. Attaching a screenshot after enabling the above mentioned flag. Able to see the extensions badges without any rendering and are also readable. @nie.mam.pomyslu.na.nick -- Could you please let me know if i am missing anything. Note: Removing Needs Bisect label as of now.
,
May 24 2016
First of all, I don't know what's supposed to be shown on your screenshot, as there are no extension badges visible on it and have no idea what you mean by "without any rendering". Second, the issue is present when the top-chrome-md flag is set to either Material or Material hybrid (which probably became default value and that's why I'm now seeing it). After switching the flag back to Non-material, badges are displayed using the old style, which is clearly readable (but the tabs above have much smaller height than before).
,
May 24 2016
There are still no badges on your screenshot. Badges. As in "those tiny little squares with even tinier digits that show up on extension icons to indicate extension activity". Badges, set by chrome.browserAction.setBadgeText extension API method. Badges. If there are no issues with those and they're clearly readable, could you please tell me what's the number on the badge from the screenshot I'm attaching to this comment?
,
May 24 2016
Yes, if the badges looked like that, they would be perfectly readable.
,
May 24 2016
Thank you for providing more feedback. Adding requester "msrchandra@chromium.org" for another review and adding "Needs-Review" label for tracking. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 25 2016
It sounds like this is in cc? Putting on Internals>Compositing.
,
May 25 2016
,
Jun 1 2016
Moving this nonessential bug to the next milestone. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 3 2016
Ali, Ian said it looks like we may have a bad scale when drawing the badges and that you might be familiar with this.
,
Jun 7 2016
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by ashej...@chromium.org
, May 18 2016