Regression: "Welcome to the Cast experience in Chrome" text is not seen at first instance on opening Cast overlay.
Reported by
jshan...@etouch.net,
May 18 2016
|
|||||||
Issue descriptionChrome version: 52.0.2740.0 (Official Build) (64-bit)60dd666a273eb84d361f0fd5de11d770881b46bc-refs/heads/master@{#394284} -32/64 bit OS: Windows (7,8,8.1,10),Mac OS X(10.10.5, 10.11.4) Pre-condition: Enable Media router from chrome://flags Steps: 1. Launch chrome and open NTP. 2. Right click to open the context menu then select 'Cast' option and observe. Actual: "Welcome to the Cast experience in Chrome" text is not seen at first instance and unwanted blue line is seen R.H.S border on opening Cast overlay. Expected: "Welcome to the Cast experience in Chrome" text should be seen at first instance on opening Cast overlay. This is a regression issue broken in M-52, below is bisect info Good build: 52.0.2738.0 Bad build: 52.0.2739.0 Narrow bisect: https://chromium.googlesource.com/chromium/src/+log/849388b26cc1cab6a2e4d9cb6e798f360b99ba64..6f4816f3b086f910cb4d15a9790825f8b3bb5a01?pretty=fuller&n=100 Suspecting: r393969 ? Please help to re-assign if your change is not the cause for this issue.
,
May 18 2016
,
May 18 2016
,
May 20 2016
,
May 20 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2786224a2dd9f8b5d785b589be26500900d9e5b0 commit 2786224a2dd9f8b5d785b589be26500900d9e5b0 Author: btolsch <btolsch@chromium.org> Date: Fri May 20 18:09:16 2016 [Media Router WebUI] Update element positioning after delayed imports. This change adds a call to update the positioning of dialog elements after the delayed html imports have finished. Delaying the imports seems to cause the first run flow element (which is conditionally templated) to have an offsetHeight of 0 after it is stamped but before the imports complete. Adding another update call lets the update correctly see this element's offsetHeight when it is supposed to be visible. R=apacible@chromium.org BUG= 612726 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/1996233002 Cr-Commit-Position: refs/heads/master@{#395116} [modify] https://crrev.com/2786224a2dd9f8b5d785b589be26500900d9e5b0/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js
,
May 21 2016
,
Jun 1 2016
,
Jun 1 2016
Your change meets the bar and is auto-approved for M52 (branch: 2743)
,
Jun 1 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/36c6f4a59d3a7a2031716694259aea7a236cb7ae commit 36c6f4a59d3a7a2031716694259aea7a236cb7ae Author: btolsch <btolsch@chromium.org> Date: Wed Jun 01 22:34:51 2016 [Media Router WebUI] Update element positioning after delayed imports. This change adds a call to update the positioning of dialog elements after the delayed html imports have finished. Delaying the imports seems to cause the first run flow element (which is conditionally templated) to have an offsetHeight of 0 after it is stamped but before the imports complete. Adding another update call lets the update correctly see this element's offsetHeight when it is supposed to be visible. R=apacible@chromium.org BUG= 612726 NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/1996233002 Cr-Commit-Position: refs/heads/master@{#395116} (cherry picked from commit 2786224a2dd9f8b5d785b589be26500900d9e5b0) Review-Url: https://codereview.chromium.org/2029783002 Cr-Commit-Position: refs/branch-heads/2743@{#176} Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939} [modify] https://crrev.com/36c6f4a59d3a7a2031716694259aea7a236cb7ae/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by ashej...@chromium.org
, May 18 2016