Write unittest for arc_file_tasks.cc |
|||||||
Issue descriptionTitle says all. The file is getting bigger and complex. Worth having tests.
,
Jun 30 2016
,
Sep 8 2016
,
Oct 18 2016
,
Oct 18 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6b8f55438bb39e8cc37b76f97abf64683c476977 commit 6b8f55438bb39e8cc37b76f97abf64683c476977 Author: kinaba <kinaba@chromium.org> Date: Tue Oct 18 06:05:44 2016 ChromeOS: Add unittest for ConvertPathToArcUrl. BUG= 612720 TEST=unit_tests --gtest_filter='FileManagerPathUtilTest.ConvertPathToArcUrl' Review-Url: https://codereview.chromium.org/2426873002 Cr-Commit-Position: refs/heads/master@{#425905} [modify] https://crrev.com/6b8f55438bb39e8cc37b76f97abf64683c476977/chrome/browser/chromeos/file_manager/path_util_unittest.cc
,
Oct 18 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/74c4cbc587e14a76bbc26cbf8f7b98f97cbc080b commit 74c4cbc587e14a76bbc26cbf8f7b98f97cbc080b Author: kinaba <kinaba@chromium.org> Date: Tue Oct 18 07:05:54 2016 Revert of ChromeOS: Add unittest for ConvertPathToArcUrl. (patchset #1 id:1 of https://codereview.chromium.org/2426873002/ ) Reason for revert: It broke a bot https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Ozone%20Tests%20%281%29/builds/37447/steps/unit_tests%20on%20Ubuntu-12.04/logs/FileManagerPathUtilTest.ConvertPathToArcUrl Original issue's description: > ChromeOS: Add unittest for ConvertPathToArcUrl. > > BUG= 612720 > TEST=unit_tests --gtest_filter='FileManagerPathUtilTest.ConvertPathToArcUrl' > > Committed: https://crrev.com/6b8f55438bb39e8cc37b76f97abf64683c476977 > Cr-Commit-Position: refs/heads/master@{#425905} TBR=fukino@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 612720 Review-Url: https://codereview.chromium.org/2429533004 Cr-Commit-Position: refs/heads/master@{#425914} [modify] https://crrev.com/74c4cbc587e14a76bbc26cbf8f7b98f97cbc080b/chrome/browser/chromeos/file_manager/path_util_unittest.cc
,
Oct 18 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/98c1b1af04fc6704666c3ac140542bb51d45cb90 commit 98c1b1af04fc6704666c3ac140542bb51d45cb90 Author: kinaba <kinaba@chromium.org> Date: Tue Oct 18 08:34:35 2016 Reland: ChromeOS: Add unittest for ConvertPathToArcUrl. Relanding the reverted crrev.com/2429533004 commit. It broke the test due to the lack of message loop necessary for shutdown. This version now adds the test thread bundle. BUG= 612720 TEST=unit_tests --gtest_filter='FileManagerPathUtilTest.ConvertPathToArcUrl' Review-Url: https://codereview.chromium.org/2430623002 Cr-Commit-Position: refs/heads/master@{#425923} [modify] https://crrev.com/98c1b1af04fc6704666c3ac140542bb51d45cb90/chrome/browser/chromeos/file_manager/path_util_unittest.cc
,
Nov 21 2016
,
Mar 23 2017
,
Feb 6 2018
<triage> This should be fixed. |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by kinaba@chromium.org
, Jun 30 2016