New issue
Advanced search Search tips

Issue 612717 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Jul 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Files app: Stop using KeyEvent.keyIdentifier.

Project Member Reported by fukino@chromium.org, May 18 2016

Issue description

It is deprecated.
We should use KeyboardEvent.key instead.
https://www.chromestatus.com/features/5316065118650368
 
Project Member

Comment 1 by sheriffbot@chromium.org, Jun 1 2016

Labels: -M-52 M-53 MovedFrom-52
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9e5d27298cb447dbf20cbcd189dfb36a4d94960d

commit 9e5d27298cb447dbf20cbcd189dfb36a4d94960d
Author: fukino <fukino@chromium.org>
Date: Thu Jun 09 14:45:59 2016

Remove the use of KeyEvent.keyIdentifier.

We should use KeyboardEvent.key instead.
For the shortcut identifier of cr.ui.Command (<command> in main.html), we still depends on keyIdentifier, but it should be handled in a separate CL.

BUG= 612717 
TEST=run browser_tests

Review-Url: https://codereview.chromium.org/1994563002
Cr-Commit-Position: refs/heads/master@{#398876}

[modify] https://crrev.com/9e5d27298cb447dbf20cbcd189dfb36a4d94960d/ui/file_manager/audio_player/elements/audio_player.js
[modify] https://crrev.com/9e5d27298cb447dbf20cbcd189dfb36a4d94960d/ui/file_manager/audio_player/js/audio_player.js
[modify] https://crrev.com/9e5d27298cb447dbf20cbcd189dfb36a4d94960d/ui/file_manager/file_manager/background/js/test_util.js
[modify] https://crrev.com/9e5d27298cb447dbf20cbcd189dfb36a4d94960d/ui/file_manager/file_manager/foreground/js/directory_tree_naming_controller.js
[modify] https://crrev.com/9e5d27298cb447dbf20cbcd189dfb36a4d94960d/ui/file_manager/file_manager/foreground/js/import_controller.js
[modify] https://crrev.com/9e5d27298cb447dbf20cbcd189dfb36a4d94960d/ui/file_manager/file_manager/foreground/js/main_window_component.js
[modify] https://crrev.com/9e5d27298cb447dbf20cbcd189dfb36a4d94960d/ui/file_manager/file_manager/foreground/js/naming_controller.js
[modify] https://crrev.com/9e5d27298cb447dbf20cbcd189dfb36a4d94960d/ui/file_manager/file_manager/foreground/js/ui/combobutton.js
[modify] https://crrev.com/9e5d27298cb447dbf20cbcd189dfb36a4d94960d/ui/file_manager/file_manager/foreground/js/ui/file_table.js
[modify] https://crrev.com/9e5d27298cb447dbf20cbcd189dfb36a4d94960d/ui/file_manager/file_manager/foreground/js/ui/list_container.js
[modify] https://crrev.com/9e5d27298cb447dbf20cbcd189dfb36a4d94960d/ui/file_manager/file_manager/foreground/js/ui/search_box.js
[modify] https://crrev.com/9e5d27298cb447dbf20cbcd189dfb36a4d94960d/ui/file_manager/gallery/js/gallery.js
[modify] https://crrev.com/9e5d27298cb447dbf20cbcd189dfb36a4d94960d/ui/file_manager/gallery/js/image_editor/image_editor.js
[modify] https://crrev.com/9e5d27298cb447dbf20cbcd189dfb36a4d94960d/ui/file_manager/gallery/js/image_editor/image_transform.js
[modify] https://crrev.com/9e5d27298cb447dbf20cbcd189dfb36a4d94960d/ui/file_manager/gallery/js/slide_mode.js
[modify] https://crrev.com/9e5d27298cb447dbf20cbcd189dfb36a4d94960d/ui/file_manager/gallery/js/thumbnail_mode.js
[modify] https://crrev.com/9e5d27298cb447dbf20cbcd189dfb36a4d94960d/ui/file_manager/video_player/js/video_player.js

Project Member

Comment 3 by bugdroid1@chromium.org, Jun 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9e5d27298cb447dbf20cbcd189dfb36a4d94960d

commit 9e5d27298cb447dbf20cbcd189dfb36a4d94960d
Author: fukino <fukino@chromium.org>
Date: Thu Jun 09 14:45:59 2016

Remove the use of KeyEvent.keyIdentifier.

We should use KeyboardEvent.key instead.
For the shortcut identifier of cr.ui.Command (<command> in main.html), we still depends on keyIdentifier, but it should be handled in a separate CL.

BUG= 612717 
TEST=run browser_tests

Review-Url: https://codereview.chromium.org/1994563002
Cr-Commit-Position: refs/heads/master@{#398876}

[modify] https://crrev.com/9e5d27298cb447dbf20cbcd189dfb36a4d94960d/ui/file_manager/audio_player/elements/audio_player.js
[modify] https://crrev.com/9e5d27298cb447dbf20cbcd189dfb36a4d94960d/ui/file_manager/audio_player/js/audio_player.js
[modify] https://crrev.com/9e5d27298cb447dbf20cbcd189dfb36a4d94960d/ui/file_manager/file_manager/background/js/test_util.js
[modify] https://crrev.com/9e5d27298cb447dbf20cbcd189dfb36a4d94960d/ui/file_manager/file_manager/foreground/js/directory_tree_naming_controller.js
[modify] https://crrev.com/9e5d27298cb447dbf20cbcd189dfb36a4d94960d/ui/file_manager/file_manager/foreground/js/import_controller.js
[modify] https://crrev.com/9e5d27298cb447dbf20cbcd189dfb36a4d94960d/ui/file_manager/file_manager/foreground/js/main_window_component.js
[modify] https://crrev.com/9e5d27298cb447dbf20cbcd189dfb36a4d94960d/ui/file_manager/file_manager/foreground/js/naming_controller.js
[modify] https://crrev.com/9e5d27298cb447dbf20cbcd189dfb36a4d94960d/ui/file_manager/file_manager/foreground/js/ui/combobutton.js
[modify] https://crrev.com/9e5d27298cb447dbf20cbcd189dfb36a4d94960d/ui/file_manager/file_manager/foreground/js/ui/file_table.js
[modify] https://crrev.com/9e5d27298cb447dbf20cbcd189dfb36a4d94960d/ui/file_manager/file_manager/foreground/js/ui/list_container.js
[modify] https://crrev.com/9e5d27298cb447dbf20cbcd189dfb36a4d94960d/ui/file_manager/file_manager/foreground/js/ui/search_box.js
[modify] https://crrev.com/9e5d27298cb447dbf20cbcd189dfb36a4d94960d/ui/file_manager/gallery/js/gallery.js
[modify] https://crrev.com/9e5d27298cb447dbf20cbcd189dfb36a4d94960d/ui/file_manager/gallery/js/image_editor/image_editor.js
[modify] https://crrev.com/9e5d27298cb447dbf20cbcd189dfb36a4d94960d/ui/file_manager/gallery/js/image_editor/image_transform.js
[modify] https://crrev.com/9e5d27298cb447dbf20cbcd189dfb36a4d94960d/ui/file_manager/gallery/js/slide_mode.js
[modify] https://crrev.com/9e5d27298cb447dbf20cbcd189dfb36a4d94960d/ui/file_manager/gallery/js/thumbnail_mode.js
[modify] https://crrev.com/9e5d27298cb447dbf20cbcd189dfb36a4d94960d/ui/file_manager/video_player/js/video_player.js

Status: Fixed (was: Started)
Status: Verified (was: Fixed)

Sign in to add a comment