Regression : The scroll position of a page changes when returning from full screen mode in www.vimeo.com.
Reported by
mni...@etouch.net,
May 18 2016
|
|||||||||||||||
Issue descriptionVersion: 51.0.2704.54 0a83ee128f7de73f3ed9fb8e920541134464f086-refs/branch-heads/2704@{#583} (32/64-bit) OS: Windows (7,8,8.1,10),Mac OS X(10.10.5, 10.11.4) URL : https://vimeo.com/channels/staffpicks/166034462 What steps will reproduce the problem? 1) Launch chrome and navigate to above url 2) Now scroll down the page and play video and set it to full screen mode. 3) Now exit full screen mode and observe the page Actual : The scroll position of a page changes when returning from full screen mode. Expected : The scroll position of a page should not change when returning from full screen mode. This is a regression issue broken in 'M-50' and below is the manual regression and Narrow bisect info: Good build : 50.0.2633.3 Bad build : 50.0.2636.0 Change Log info: https://chromium.googlesource.com/chromium/src/+log/50.0.2633.0..50.0.2636.0?pretty=fuller&n=10000 (Note : Unable to provide Narrow bisect info as the above video is not able to be viewed in chromium builds) Suspecting : r372146 from Change Log @bokan : Could you please help to reassign if your change is not the cause for this change. Note : Issue is not reproduced in Linux OS.
,
May 31 2016
Could not reproduce this on Mac 53.0.2751.0 or 50.0.2661.102 or on Windows. The given patch actually fixes this issue. Are you sure you didn't make a mistake with the bisect? Could you try again with Canary/Beta?
,
Jun 1 2016
With response to comment #2 : Rechecked the above issue on windows with latest canary chrome version 53.0.2753.0 and Mac 53.0.2751.0 and the above issue is still reproducible.Please refer the attached video.
,
Jun 1 2016
Strange, I can't repro on Win 53.0.2754.0, in incognito, fresh profile, flags reset. I've tried this on two separate machines on Windows 10 and another on OSX so either there's something missing in the repro instructions or there's a specific issue with your setup. You're using the escape key to exit fullscreen?
,
Jun 2 2016
With response to comment #4 : Can you try it on fresh installation in normal window.The above issue is reproducible at our end with canary chrome version 53.0.2754.0 on various machines Win 7,8,8.1,10. Issues reproduces by both means by pressing 'Esc' key or by clicking Exit full screen.Please refer the attached video.
,
Jun 2 2016
Ok, I finally managed to reproduce. The key seems to be that this is dependent on the window height, it must be below some threshold (a little larger than the video height). Past a certain point the restoring logic works as expected. Strange. I'll look into this but it's not a priority since it's not actually a regression (the restoring logic didn't work at all before the bisected point)
,
Jun 7 2016
This also repros on Linux
,
Jun 10 2016
This is a problem with the site. It seems they display: none a bunch of content when entering fullscreen and restore it when exiting. This means when we exit fullscreen, but before the page has had a chance to redisplay all the other content, we try to restore the scroll position but because all the content is missing, the maximum scroll position is much smaller than what we try to restore. The solution is for the content to not hide all the non-fullscreen content.
,
Jun 21 2016
|
|||||||||||||||
►
Sign in to add a comment |
|||||||||||||||
Comment 1 by mni...@etouch.net
, May 18 2016