New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 612689 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
please use my google.com address
Closed: May 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 0
Type: Bug



Sign in to add a comment

services/shell/public/cpp/connect.h compile flake (interface_provider.mojom.h)

Project Member Reported by tapted@chromium.org, May 18 2016

Issue description

Chrome Version       : 52.0.2739.2

Flaked in the waterfall at
 - https://build.chromium.org/p/chromium/builders/Win/builds/43482

Flaked in my tryjob at
 - https://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/192144

Error like

[14176/33705] CXX obj\chrome\browser\media\router\mojo\media_router_test_support.media_router_mojo_test.obj
FAILED: obj/chrome/browser/media/router/mojo/media_router_test_support.media_router_mojo_test.obj 
ninja -t msvc -e environment.x86 -- C:\b\build\slave\cache\cipd\goma/gomacc "C:\b\depot_tools\win_toolchain\vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\VC\bin\amd64_x86\cl.exe" /nologo /showIncludes /FC @obj\chrome\browser\media\router\mojo\media_router_test_support.media_router_mojo_test.obj.rsp /c ..\..\chrome\browser\media\router\mojo\media_router_mojo_test.cc /Foobj\chrome\browser\media\router\mojo\media_router_test_support.media_router_mojo_test.obj /Fdobj\chrome\browser\media\router\media_router_test_support.cc.pdb 
c:\b\build\slave\win\build\src\services\shell\public\cpp\connect.h(10): fatalerror C1083: Cannot open include file: 'services/shell/public/interfaces/interface_provider.mojom.h': No such file or directory


Probably a missing dependency or hard_dependency or export_dependent_settings thing.

Maybe some pointers in  Issue 611898  or  Issue 611319  or  Issue 606829  will help fix the problem.

-> to amistry who has sheriff powers
 

Comment 1 by roc...@chromium.org, May 18 2016

Ooh I looked at this yesterday but was only considering GN, which looked
fine. Media router's mojo test includes something from
content/public/common which eventually pulls in shell interfaces. Maybe one
of those dependencies is missing for gyp. AFAICT the dependency on these
interfaces can only come from content in this case.

Comment 2 by tapted@chromium.org, May 18 2016

btw, this is quite bad. CQ is blocked on flaky win_chromium_compile_dbg_ng jobs. Only about 1 in 5 are succeeding - the rest failing on compile failed / without patch due to this error.

https://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng?numbuilds=200
Screen Shot 2016-05-18 at 3.15.04 PM.png
469 KB View Download

Comment 3 by roc...@chromium.org, May 18 2016

Yikes. I'll take a look now.

Comment 4 by roc...@chromium.org, May 18 2016

Cc: -roc...@chromium.org amistry@chromium.org
Owner: roc...@chromium.org
Cc: kcaratt...@chromium.org

Comment 6 by roc...@chromium.org, May 18 2016

Fix is on the way: https://codereview.chromium.org/1990793002
Project Member

Comment 7 by bugdroid1@chromium.org, May 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bf869a0ff45baa0b1f973ab6dd5befcd5dd2f518

commit bf869a0ff45baa0b1f973ab6dd5befcd5dd2f518
Author: rockot <rockot@chromium.org>
Date: Wed May 18 08:14:22 2016

Forward declare ShellClient for MojoApplicationInfo

This avoids pulling in generated headers indirectly
through content_browser_client.h, which can be problematic
because gyp makes it hard to reason about how these
dependencies are propagated.

BUG= 612689 
R=amistry@chromium.org
TBR=jam@chromium.org

Review-Url: https://codereview.chromium.org/1990793002
Cr-Commit-Position: refs/heads/master@{#394359}

[modify] https://crrev.com/bf869a0ff45baa0b1f973ab6dd5befcd5dd2f518/content/public/common/mojo_application_info.cc
[modify] https://crrev.com/bf869a0ff45baa0b1f973ab6dd5befcd5dd2f518/content/public/common/mojo_application_info.h

Comment 8 by roc...@chromium.org, May 18 2016

Status: Fixed (was: Assigned)

Sign in to add a comment