Chromium repository should prevent submission of overly long paths |
|||||||||||||
Issue descriptionWhat steps will reproduce the problem? (1) Commit a very long path name to the git repository (2) Watch the windows bots fail In http://crbug.com/609853 a file with a very long path name was submitted which causes the windows builders to fail (because the longest path on Windows is 260 characters).
,
May 18 2016
Example CL https://codereview.chromium.org/1990763002 which has a very long file name (which if submitted would break windows bots and other Windows users) but that there doesn't seem to be anything stopping me from submitting?
,
May 18 2016
See also bug 609871 and bug 611437 - as the latter case shows, we also need to watch out for generated files.
,
May 18 2016
,
May 19 2016
,
Jun 1 2016
CL which passed CQ and failed on waterfall later: https://codereview.chromium.org/1949503002.
,
Aug 13 2016
,
Aug 15 2016
Well, this seems like a perfect case for PRESUBMIT check to be added to root PRESUBMIT.py of chromium/src. FTR, Gerrit codereview won't have this limit for CLs.
,
Aug 15 2016
,
Aug 15 2017
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 6 2017
Since we have moved to Gerrit now, does this mean we can close this?
,
Sep 6 2017
No, the underlying problem on Windows is still there.
,
May 11 2018
I haven't looked into this and this is under CCI so marking untriaged for someone else to have a look.
,
May 11 2018
-> martiniss, since he's been dealing with this recently.
,
May 15 2018
,
Jun 1 2018
There is also EncFS with a 142 char filename limit.
,
Jun 7 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/97a39414a80f02e03837fa60e603466958708b44 commit 97a39414a80f02e03837fa60e603466958708b44 Author: Stephen Martinis <martiniss@chromium.org> Date: Thu Jun 07 23:06:05 2018 Add presubmit check for long paths Bug: 612667 Change-Id: I6bd52794bf6122813770338a93509d295bf4a7cb Reviewed-on: https://chromium-review.googlesource.com/1060458 Reviewed-by: Dirk Pranke <dpranke@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#565452} [modify] https://crrev.com/97a39414a80f02e03837fa60e603466958708b44/PRESUBMIT.py
,
Jun 8 2018
|
|||||||||||||
►
Sign in to add a comment |
|||||||||||||
Comment 1 by tansell@chromium.org
, May 18 2016