New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 612667 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

Chromium repository should prevent submission of overly long paths

Project Member Reported by tansell@chromium.org, May 18 2016

Issue description


What steps will reproduce the problem?
(1) Commit a very long path name to the git repository
(2) Watch the windows bots fail

In http://crbug.com/609853 a file with a very long path name was submitted which causes the windows builders to fail (because the longest path on Windows is 260 characters).
 
Rietveld seems to have a limit of 255 characters;
-------------------------
Upload server: https://codereview.chromium.org (change with -s/--server)
Issue created. URL: https://codereview.chromium.org/1991643002 (patchset: 1)
  --> ERROR: Upload content errors:
{'filename': [u'Ensure this value has at most 255 characters (it has 412).']}
-------------------------
Example CL https://codereview.chromium.org/1990763002 which has a very long file name (which if submitted would break windows bots and other Windows users) but that there doesn't seem to be anything stopping me from submitting?
See also  bug 609871  and bug 611437 - as the latter case shows, we also need to watch out for generated files.
Cc: jparent@chromium.org iannucci@chromium.org

Comment 5 by estaab@chromium.org, May 19 2016

Components: -Infra
Status: Available (was: Untriaged)
CL which passed CQ and failed on waterfall later: https://codereview.chromium.org/1949503002.
Cc: -qyears...@chromium.org
Components: -Infra>CQ Infra>Client>Chrome
Well, this seems like a perfect case for PRESUBMIT check to be added to root PRESUBMIT.py of chromium/src.

FTR, Gerrit codereview won't have this limit for CLs.
Labels: -Type-Bug Type-Feature
Project Member

Comment 10 by sheriffbot@chromium.org, Aug 15 2017

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: estaab@chromium.org
Owner: estaab@chromium.org
Status: Assigned (was: Untriaged)
Since we have moved to Gerrit now, does this mean we can close this?
No, the underlying problem on Windows is still there.
Labels: -Hotlist-Recharge-Cold
Owner: ----
Status: Untriaged (was: Assigned)
I haven't looked into this and this is under CCI so marking untriaged for someone else to have a look.
Owner: martiniss@chromium.org
Status: Assigned (was: Untriaged)
-> martiniss, since he's been dealing with this recently.
Status: Started (was: Assigned)

Comment 16 by brat...@opera.com, Jun 1 2018

There is also EncFS with a 142 char filename limit.
Project Member

Comment 17 by bugdroid1@chromium.org, Jun 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/97a39414a80f02e03837fa60e603466958708b44

commit 97a39414a80f02e03837fa60e603466958708b44
Author: Stephen Martinis <martiniss@chromium.org>
Date: Thu Jun 07 23:06:05 2018

Add presubmit check for long paths

Bug:  612667 
Change-Id: I6bd52794bf6122813770338a93509d295bf4a7cb
Reviewed-on: https://chromium-review.googlesource.com/1060458
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565452}
[modify] https://crrev.com/97a39414a80f02e03837fa60e603466958708b44/PRESUBMIT.py

Status: Fixed (was: Started)

Sign in to add a comment