New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 612662 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug-Regression



Sign in to add a comment

[Pinky/Speedy] Getting corrupted display for a second after suspend/resume.

Project Member Reported by sontis@chromium.org, May 18 2016

Issue description

Version: 8337.0.0
OS: Chromeos
What steps will reproduce the problem?
(1) Sign in to the device.
(2) Suspend device.
     close lid/ run "powerd_dbus_suspend"
(3) Resume device.
     Open lid / press any key.

What is the expected output?
Device display should work properly.

What do you see instead?
Getting corrupted display for one second after resume.

Please use labels and text to provide additional information.

Note: Not able to reproduce this issue on Samus device.

 

Comment 2 by sontis@chromium.org, May 18 2016

 Issue 612661  has been merged into this issue.

Comment 3 by derat@chromium.org, May 18 2016

Cc: -derat@chromium.org

Comment 4 by sontis@chromium.org, May 25 2016

Cc: sontis@chromium.org
 Issue 614862  has been merged into this issue.
Project Member

Comment 5 by sheriffbot@chromium.org, Jun 1 2016

Labels: -M-52 M-53 MovedFrom-52
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 6 by sheriffbot@chromium.org, Jul 9 2016

Labels: -M-53 MovedFrom-53
This issue has been moved once and is lower than Pri-1. Removing the milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: M-54
issue reproduce on 8696.0.0/54.0.2824.0 with speedy
just close/open the lid and can see issue
Owner: dbehr@chromium.org
Status: Assigned (was: Untriaged)
I don't see this on my minnie, and I don't have a speedy here.

dbehr, can you try this patch and see if it helps:
https://chromium-review.googlesource.com/368561

Comment 10 by derat@chromium.org, Aug 24 2016

Any updates? Has the patch from #9 been tested?

I see a white flash when I open the lid on a veyron_speedy device to resume it. It repros every time.

Google Chrome	52.0.2743.116 (Official Build) (32-bit)
Revision	9115ecad1cae66fd5fe52bd9120af643384fd6f3-refs/branch-heads/2743@{#728}
Platform	8350.68.0 (Official Build) stable-channel veyron_speedy

Comment 11 by son...@google.com, Aug 24 2016

Still able to reproduce this issue on M54 build 8737.0.0_veyron-speedy
Cc: puneetster@chromium.org diand...@chromium.org
Components: OS>Kernel>Display
Owner: katierh@chromium.org
I don't see this on my minnie, and I don't have a speedy here.

katierh, can you help find someone to try this patch and see if it helps:
https://chromium-review.googlesource.com/368561

I see this all the time on my jerry device on beta channel and it's ugly.  I've been down in the lab and not up at my desk for about a month now so I haven't been able to test the patch myself.  Hopefully someone on this thread can.
sontis - can someone on your team help test? please ping on chat if you're missing devices

Comment 15 by ka...@chromium.org, Aug 31 2016

Can you point sontis@ to a image location with patched build to download and image speedy device?
Kicked off a magic build bot with the command:

$ cbuildbot --remote -g 368561 veyron_speedy-release

Eventually <https://uberchromegw.corp.google.com/i/chromiumos.tryserver/builders/release/builds/6022> will finish and then you can find an image in the Artifacts.
FYI that the build is done.  Test away.
Cc: ihf@chromium.org rjahagir@chromium.org
 Issue 670010  has been merged into this issue.
Summary: [Pinky/Speedy] Getting corrupted display for a second after suspend/resume. (was: [Pinky] Getting corrupted display for a second after suspend/resume.)
Is this still an issue?

Comment 21 by son...@google.com, Jan 4 2017

Still able to reproduce this issue on build 9150.0.0
Getting white screen for a second before resume.

Vedio and logs are present at https://pantheon.corp.google.com/storage/browser/chromiumos-test-logs/bugfiles/cr/612662/9150.0.0/?debugUI=CLOUD
Status: Archived (was: Assigned)
Labels: -M-54 M-58
Owner: diand...@chromium.org
Status: Started (was: Archived)
Probably should actually land this.  Maybe R-58?
Project Member

Comment 24 by bugdroid1@chromium.org, Mar 17 2017

Labels: merge-merged-chromeos-3.14
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/73099f19838bcad9f4ee4f882e97473ceee7e0b0

commit 73099f19838bcad9f4ee4f882e97473ceee7e0b0
Author: Thierry Reding <treding@nvidia.com>
Date: Fri Mar 17 01:06:55 2017

UPSTREAM: drm/panel: simple: Update backlight state property

Some backlight drivers ignore the power property and instead only use
the state property. Fixup the panel driver to set the state property in
addition to the power property.

Signed-off-by: Thierry Reding <treding@nvidia.com>
(cherry picked from commit e4aa34289ec6a8a9f6a6f63d0e219db6ceaaf4c8)
Signed-off-by: Daniel Kurtz <djkurtz@chromium.org>

BUG= chromium:612662 
TEST=On an elm DUT with a 'noisy' panel in laptop mode
  Log-in
  Use a magnet to trigger 'lid-close' (suspend)
  Lift magnet to trigger 'lid-open' (resume)
  => No "early panel flash" on resume (ie backlight on before data)
  => No vertical static/corruption on screen at resume

Change-Id: Ib1df3969f0811a661ff359104eb241e020b5b17c
Reviewed-on: https://chromium-review.googlesource.com/368561
Commit-Ready: Douglas Anderson <dianders@chromium.org>
Tested-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: Dominik Behr <dbehr@chromium.org>

[modify] https://crrev.com/73099f19838bcad9f4ee4f882e97473ceee7e0b0/drivers/gpu/drm/panel/panel-simple.c

Cc: bhthompson@chromium.org
Labels: Merge-Request-58
Got an independent confirmation that this is fixed in b/35585555

Requesting Merge.
Project Member

Comment 26 by sheriffbot@chromium.org, Mar 18 2017

Labels: -Merge-Request-58 Hotlist-Merge-Approved Merge-Approved-58
Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 27 by bugdroid1@chromium.org, Mar 20 2017

Labels: merge-merged-release-R58-9334.B-chromeos-3.14
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/cd72d115430486150ebd2651a445d180d623bd2b

commit cd72d115430486150ebd2651a445d180d623bd2b
Author: Thierry Reding <treding@nvidia.com>
Date: Mon Mar 20 15:27:48 2017

UPSTREAM: drm/panel: simple: Update backlight state property

Some backlight drivers ignore the power property and instead only use
the state property. Fixup the panel driver to set the state property in
addition to the power property.

Signed-off-by: Thierry Reding <treding@nvidia.com>
(cherry picked from commit e4aa34289ec6a8a9f6a6f63d0e219db6ceaaf4c8)
Signed-off-by: Daniel Kurtz <djkurtz@chromium.org>

BUG= chromium:612662 
TEST=On an elm DUT with a 'noisy' panel in laptop mode
  Log-in
  Use a magnet to trigger 'lid-close' (suspend)
  Lift magnet to trigger 'lid-open' (resume)
  => No "early panel flash" on resume (ie backlight on before data)
  => No vertical static/corruption on screen at resume

Change-Id: Ib1df3969f0811a661ff359104eb241e020b5b17c
Reviewed-on: https://chromium-review.googlesource.com/368561
Commit-Ready: Douglas Anderson <dianders@chromium.org>
Tested-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: Dominik Behr <dbehr@chromium.org>
(cherry picked from commit 73099f19838bcad9f4ee4f882e97473ceee7e0b0)
Reviewed-on: https://chromium-review.googlesource.com/457240
Reviewed-by: Douglas Anderson <dianders@chromium.org>

[modify] https://crrev.com/cd72d115430486150ebd2651a445d180d623bd2b/drivers/gpu/drm/panel/panel-simple.c

Labels: -Hotlist-Merge-Approved -Merge-Approved-58 Merge-Merged
Status: Fixed (was: Started)

Comment 29 by son...@google.com, Mar 24 2017

Status: Verified (was: Fixed)
Verified on build 9334.20.0

Sign in to add a comment