New issue
Advanced search Search tips

Issue 612658 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jun 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Cleanup: Remove the CertTrustAnchorProvider from //net

Project Member Reported by rsleevi@chromium.org, May 18 2016

Issue description

The net::CertTrustAnchorProvider is an abstraction to support ChromeOS trust anchor providers. However, if net::CertVerifier took an input of trust anchors (e.g. as part of a CertVerifier::RequestParams), we could remove that interface and leave it entirely up to the higher //chrome code to compose, by supplying the trust anchor certs in the Verify() call.

e.g.
PolicyCertVerifier::Verify(const CertVerifier::RequestParams& params, ...) {
  CertVerifier::RequestParams local_request(params);
  local_request.SetTrustAnchors(GetAdditionalTrustAnchors());

  verifier_->Verify(local_request, ...);
}

PolicyCertVerifier::GetAdditionalTrustAnchors() {
  .. What it does today
}


Basically, get rid of the entire concept of net::CertTrustAnchorProvider, which is weird.
 

Comment 1 by eroman@chromium.org, Jun 21 2016

Components: -Internals>Network>SSL Internals>Network>Certificate
Labels: M-53
Status: Verified (was: Assigned)
Gah, forgot to tag https://codereview.chromium.org/2070223002/ with this bug.

This is fixed in M-53.

Sign in to add a comment