Lint/remove "app launcher" from UI strings, except on ChromeOS |
|||||
Issue descriptionChrome Version : 52.0.2739.2 chrome://settings has stuff like "Use a prediction service to help complete searches and URLs typed in the address bar or the app launcher search box". The second half of that sentence is now only relevant for ChromeOS, and should disappear from desktop platforms. There are probably other occurrences that will remain after enable_app_list is set to 0. Filing this to track.
,
May 18 2016
I had a look - that's the only one I could find apart from:
- stuff in chrome://flags
- this, which is already guarded with `if chromeos`
<if expr="chromeos">
<message name="IDS_HOTWORD_SEARCH_NO_DSP_DESCRIPTION" desc="Description of the hotword search preference for devices with no DSP.">
Say "Ok Google" in a new tab, google.com, and the App Launcher
</message>
</if>
<if expr="not chromeos">
<message name="IDS_HOTWORD_SEARCH_NO_DSP_DESCRIPTION" desc="Description of the hotword search preference for devices with no DSP.">
Say "Ok Google" in a new tab and google.com
</message>
</if>
I'll make a CL with something similar for IDS_OPTIONS_SUGGEST_PREF
Along with chrome://flags there's a bunch of stuff in ui_strings.grd specifically for the app launcher which isn't guarded. Those should be hidden, but that can be a follow-up.
,
May 18 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b02dc0c635b2d936f56cdeb90efce61f0aef35e6 commit b02dc0c635b2d936f56cdeb90efce61f0aef35e6 Author: tapted <tapted@chromium.org> Date: Wed May 18 09:13:29 2016 Only mention the App Launcher on ChromeOS for the "Use a prediction service.." setting It currently says, "Use a prediction service to help complete searches and URLs typed in the address bar or the app launcher search box" App Launcher only exists on ChromeOS now, so drop the "or the app launcher.." bit on other platforms. BUG= 612651 Review-Url: https://codereview.chromium.org/1987993002 Cr-Commit-Position: refs/heads/master@{#394368} [modify] https://crrev.com/b02dc0c635b2d936f56cdeb90efce61f0aef35e6/chrome/app/generated_resources.grd
,
May 23 2016
,
Jun 24 2016
Yep - looks like there's another copy of the string in chrome/app/settings_strings.grdp
,
Jul 7 2016
,
Jul 8 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cc8cdf3f9e3153a81a2870b72b6b2ca10f8309f6 commit cc8cdf3f9e3153a81a2870b72b6b2ca10f8309f6 Author: tapted <tapted@chromium.org> Date: Fri Jul 08 00:00:22 2016 [MD Settings] Only mention the App Launcher on ChromeOS for the "Use a prediction service.." setting Fixed for regular settings (generated_resources.grd) in r394368. Apply the same fix for MD settings (settings_strings.grdp). It currently says, "Use a prediction service to help complete searches and URLs typed in the address bar or the app launcher search box" App Launcher only exists on ChromeOS now, so drop the "or the app launcher.." bit on other platforms. BUG= 612651 Review-Url: https://codereview.chromium.org/2125883004 Cr-Commit-Position: refs/heads/master@{#404271} [modify] https://crrev.com/cc8cdf3f9e3153a81a2870b72b6b2ca10f8309f6/chrome/app/settings_strings.grdp
,
Jul 8 2016
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by mgiuca@chromium.org
, May 18 2016