[Media Router WebUI] Long sink list can cause dialog to extend beyond browser window. |
||
Issue descriptionVersion: 52.0.2739.2 canary OS: Mac OSX What steps will reproduce the problem? (1) Enable MR. (2) Make browser window shorter, have lots of sinks available. (3) Open MR dialog. What is the expected output? Sink list is scrollable. Dialog stays constrained within browser window. Switching views fixes the issue. What do you see instead? See screenshot.
,
May 19 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/280f569b634b0a119851411326f5cefee901ee6a commit 280f569b634b0a119851411326f5cefee901ee6a Author: apacible <apacible@chromium.org> Date: Thu May 19 06:20:56 2016 [Media Router WebUI] Update element positioning when sink list is set. Since the sink list element isn't created until after the sink list is set to a non-zero amount of sinks, the max height is not set when the initial sink list is set. As there's no way to check for initial stamping of a non-custom element, this change updates the element positioning whenever the sinks are set again. BUG= 612646 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/1990713002 Cr-Commit-Position: refs/heads/master@{#394695} [modify] https://crrev.com/280f569b634b0a119851411326f5cefee901ee6a/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js
,
May 20 2016
|
||
►
Sign in to add a comment |
||
Comment 1 by apaci...@chromium.org
, May 18 2016