New issue
Advanced search Search tips

Issue 612631 link

Starred by 1 user

Issue metadata

Status: Archived
Owner: ----
Closed: Aug 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Fully implement WmShelfMus

Project Member Reported by sky@chromium.org, May 17 2016

Issue description

It's mostly a stub at this point.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ccb5d69efde4c915618f8334fa4a5231a09d3bb7

commit ccb5d69efde4c915618f8334fa4a5231a09d3bb7
Author: msw <msw@chromium.org>
Date: Wed Aug 17 20:37:48 2016

mash: Create and show a shelf in mash.

Allow mash to use the shelf, widget, and layout manager.
Delay moving files to ease oshima's concurrent Shelf CL.

Consolidate WmShelf[Aura|Mus] functionality on WmShelf.
WmShelfMus ctor inits Shelf, ShelfView, ShelfWidget, etc.
Use a ShelfDelegateStub for now; add TODO for real impl.
WmShelfAura still uses root event handlers; shelf dimmer.

Nix ShelfIconObserver interface; use WmShelfObserver.
Nix redundant mash RootWindowController::CreateStatusArea.
Change ShelfWidget's WmShelfAura* member to WmShelf*.

Call WmShell::ShutDown before destruction in WindowManager.
Teardown PointerWatcherEventRouter after window destruction.

BUG= 557406 , 612631 , 615155 , 621112 
TEST=Automated; no cros changes; chrome --mash has a shelf.
R=jamescook@chromium.org,sky@chromium.org

Review-Url: https://codereview.chromium.org/2247503002
Cr-Commit-Position: refs/heads/master@{#412630}

[modify] https://crrev.com/ccb5d69efde4c915618f8334fa4a5231a09d3bb7/ash/app_list/app_list_presenter_delegate.cc
[modify] https://crrev.com/ccb5d69efde4c915618f8334fa4a5231a09d3bb7/ash/app_list/app_list_presenter_delegate.h
[modify] https://crrev.com/ccb5d69efde4c915618f8334fa4a5231a09d3bb7/ash/ash.gyp
[modify] https://crrev.com/ccb5d69efde4c915618f8334fa4a5231a09d3bb7/ash/aura/wm_shelf_aura.cc
[modify] https://crrev.com/ccb5d69efde4c915618f8334fa4a5231a09d3bb7/ash/aura/wm_shelf_aura.h
[modify] https://crrev.com/ccb5d69efde4c915618f8334fa4a5231a09d3bb7/ash/common/shelf/DEPS
[delete] https://crrev.com/8b8b2cd33a7685b4b4d51e3d778073be4b526897/ash/common/shelf/shelf_icon_observer.h
[modify] https://crrev.com/ccb5d69efde4c915618f8334fa4a5231a09d3bb7/ash/common/shelf/shelf_view.cc
[modify] https://crrev.com/ccb5d69efde4c915618f8334fa4a5231a09d3bb7/ash/common/shelf/shelf_view.h
[modify] https://crrev.com/ccb5d69efde4c915618f8334fa4a5231a09d3bb7/ash/common/shelf/wm_shelf.cc
[modify] https://crrev.com/ccb5d69efde4c915618f8334fa4a5231a09d3bb7/ash/common/shelf/wm_shelf.h
[modify] https://crrev.com/ccb5d69efde4c915618f8334fa4a5231a09d3bb7/ash/common/wm_shell.cc
[modify] https://crrev.com/ccb5d69efde4c915618f8334fa4a5231a09d3bb7/ash/common/wm_shell.h
[add] https://crrev.com/ccb5d69efde4c915618f8334fa4a5231a09d3bb7/ash/mus/bridge/DEPS
[modify] https://crrev.com/ccb5d69efde4c915618f8334fa4a5231a09d3bb7/ash/mus/bridge/wm_shelf_mus.cc
[modify] https://crrev.com/ccb5d69efde4c915618f8334fa4a5231a09d3bb7/ash/mus/bridge/wm_shelf_mus.h
[modify] https://crrev.com/ccb5d69efde4c915618f8334fa4a5231a09d3bb7/ash/mus/root_window_controller.cc
[modify] https://crrev.com/ccb5d69efde4c915618f8334fa4a5231a09d3bb7/ash/mus/root_window_controller.h
[modify] https://crrev.com/ccb5d69efde4c915618f8334fa4a5231a09d3bb7/ash/mus/shell_delegate_mus.cc
[modify] https://crrev.com/ccb5d69efde4c915618f8334fa4a5231a09d3bb7/ash/mus/window_manager.cc
[modify] https://crrev.com/ccb5d69efde4c915618f8334fa4a5231a09d3bb7/ash/root_window_controller.cc
[modify] https://crrev.com/ccb5d69efde4c915618f8334fa4a5231a09d3bb7/ash/shelf/shelf.cc
[modify] https://crrev.com/ccb5d69efde4c915618f8334fa4a5231a09d3bb7/ash/shelf/shelf.h
[modify] https://crrev.com/ccb5d69efde4c915618f8334fa4a5231a09d3bb7/ash/shelf/shelf_view_unittest.cc
[modify] https://crrev.com/ccb5d69efde4c915618f8334fa4a5231a09d3bb7/ash/shelf/shelf_widget.cc
[modify] https://crrev.com/ccb5d69efde4c915618f8334fa4a5231a09d3bb7/ash/shelf/shelf_widget.h
[modify] https://crrev.com/ccb5d69efde4c915618f8334fa4a5231a09d3bb7/ash/system/web_notification/ash_popup_alignment_delegate_unittest.cc
[modify] https://crrev.com/ccb5d69efde4c915618f8334fa4a5231a09d3bb7/ui/views/mus/pointer_watcher_event_router.cc
[modify] https://crrev.com/ccb5d69efde4c915618f8334fa4a5231a09d3bb7/ui/views/mus/pointer_watcher_event_router.h

Comment 2 by msw@chromium.org, Aug 17 2016

Status: Fixed (was: Available)
This is generally fixed; minor issues remain for functionality implemented by WmShelfAura, but not WmShelfMus:
 Issue 631216  mash shelf: Auto-hide support
 Issue 636647  mash shelf: Bezel gesture event support
Labels: VerifyIn-54

Comment 4 by dchan@chromium.org, Oct 7 2016

Labels: VerifyIn-55

Comment 5 by dchan@google.com, Nov 19 2016

Labels: VerifyIn-56

Comment 6 by dchan@google.com, Jan 21 2017

Labels: VerifyIn-57

Comment 7 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58

Comment 8 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 9 by dchan@google.com, May 30 2017

Labels: VerifyIn-60
Labels: VerifyIn-61

Comment 11 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)

Sign in to add a comment