It likely needs to be moved to ash/wm/common so both ash and mash can use it.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b132099e1c9edf0dc8038098aae6ba4da677622c commit b132099e1c9edf0dc8038098aae6ba4da677622c Author: sky <sky@chromium.org> Date: Fri Jun 24 16:30:53 2016 Convert determining restore bounds to use ash/common type This change converts from using views::Widget to determine restore bounds to using WindowState and WmWindow. This way the code can be ported to use work in mash. BUG= 612629 TEST=covered by tests R=skuhne@chromium.org Review-Url: https://codereview.chromium.org/2095793002 Cr-Commit-Position: refs/heads/master@{#401877} [modify] https://crrev.com/b132099e1c9edf0dc8038098aae6ba4da677622c/ash/aura/wm_window_aura.cc [modify] https://crrev.com/b132099e1c9edf0dc8038098aae6ba4da677622c/ash/wm/maximize_mode/maximize_mode_window_state.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1d978e17227fcebcf93328354f1dc652187ca39c commit 1d978e17227fcebcf93328354f1dc652187ca39c Author: sky <sky@chromium.org> Date: Sat Jun 25 14:54:40 2016 Changes NativeWidgetMus to honor layer type from InitParms This is used in ash in at least one place. BUG= 612629 TEST=covered by tests R=sadrul@chromium.org Review-Url: https://codereview.chromium.org/2098033002 Cr-Commit-Position: refs/heads/master@{#402064} [modify] https://crrev.com/1d978e17227fcebcf93328354f1dc652187ca39c/ui/views/mus/native_widget_mus.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/45a721f87dda27a3096f0429a409b84ae63ce178 commit 45a721f87dda27a3096f0429a409b84ae63ce178 Author: sky <sky@chromium.org> Date: Mon Jun 27 16:22:48 2016 Moves a couple of the maximize mode classes to ash/common BUG= 612629 TEST=covered by tests R=jamescook@chromium.org Review-Url: https://codereview.chromium.org/2091263004 Cr-Commit-Position: refs/heads/master@{#402195} [modify] https://crrev.com/45a721f87dda27a3096f0429a409b84ae63ce178/ash/aura/wm_window_aura.cc [modify] https://crrev.com/45a721f87dda27a3096f0429a409b84ae63ce178/ash/aura/wm_window_aura.h [modify] https://crrev.com/45a721f87dda27a3096f0429a409b84ae63ce178/ash/common/wm_window.h [modify] https://crrev.com/45a721f87dda27a3096f0429a409b84ae63ce178/ash/mus/bridge/wm_window_mus.cc [modify] https://crrev.com/45a721f87dda27a3096f0429a409b84ae63ce178/ash/mus/bridge/wm_window_mus.h [add] https://crrev.com/45a721f87dda27a3096f0429a409b84ae63ce178/ash/wm/maximize_mode/DEPS [modify] https://crrev.com/45a721f87dda27a3096f0429a409b84ae63ce178/ash/wm/maximize_mode/maximize_mode_window_manager.cc [modify] https://crrev.com/45a721f87dda27a3096f0429a409b84ae63ce178/ash/wm/maximize_mode/maximize_mode_window_manager.h [modify] https://crrev.com/45a721f87dda27a3096f0429a409b84ae63ce178/ash/wm/maximize_mode/maximize_mode_window_state.cc [modify] https://crrev.com/45a721f87dda27a3096f0429a409b84ae63ce178/ash/wm/maximize_mode/maximize_mode_window_state.h [modify] https://crrev.com/45a721f87dda27a3096f0429a409b84ae63ce178/ash/wm/maximize_mode/workspace_backdrop_delegate.cc [modify] https://crrev.com/45a721f87dda27a3096f0429a409b84ae63ce178/ash/wm/maximize_mode/workspace_backdrop_delegate.h [modify] https://crrev.com/45a721f87dda27a3096f0429a409b84ae63ce178/ash/wm/workspace/workspace_layout_manager_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/281b34eeff49d0f6bc9b92eef2a8ac707cb5f665 commit 281b34eeff49d0f6bc9b92eef2a8ac707cb5f665 Author: sky <sky@chromium.org> Date: Wed Jun 29 03:55:36 2016 Refactors maximize mode event handling into its own class This way we can have mash and ash implementations. I can't implement this in terms of PointerWatcher as it needs to stop propagation. BUG= 624157 , 612629 TEST=covered by tests R=jamescook@chromium.org Review-Url: https://codereview.chromium.org/2106823004 Cr-Commit-Position: refs/heads/master@{#402706} [modify] https://crrev.com/281b34eeff49d0f6bc9b92eef2a8ac707cb5f665/ash/ash.gyp [modify] https://crrev.com/281b34eeff49d0f6bc9b92eef2a8ac707cb5f665/ash/aura/wm_shell_aura.cc [modify] https://crrev.com/281b34eeff49d0f6bc9b92eef2a8ac707cb5f665/ash/aura/wm_shell_aura.h [add] https://crrev.com/281b34eeff49d0f6bc9b92eef2a8ac707cb5f665/ash/common/wm/maximize_mode/OWNERS [add] https://crrev.com/281b34eeff49d0f6bc9b92eef2a8ac707cb5f665/ash/common/wm/maximize_mode/maximize_mode_event_handler.cc [add] https://crrev.com/281b34eeff49d0f6bc9b92eef2a8ac707cb5f665/ash/common/wm/maximize_mode/maximize_mode_event_handler.h [modify] https://crrev.com/281b34eeff49d0f6bc9b92eef2a8ac707cb5f665/ash/common/wm_shell.h [modify] https://crrev.com/281b34eeff49d0f6bc9b92eef2a8ac707cb5f665/ash/mus/bridge/wm_shell_mus.cc [modify] https://crrev.com/281b34eeff49d0f6bc9b92eef2a8ac707cb5f665/ash/mus/bridge/wm_shell_mus.h [add] https://crrev.com/281b34eeff49d0f6bc9b92eef2a8ac707cb5f665/ash/wm/maximize_mode/maximize_mode_event_handler_aura.cc [add] https://crrev.com/281b34eeff49d0f6bc9b92eef2a8ac707cb5f665/ash/wm/maximize_mode/maximize_mode_event_handler_aura.h [modify] https://crrev.com/281b34eeff49d0f6bc9b92eef2a8ac707cb5f665/ash/wm/maximize_mode/maximize_mode_window_manager.cc [modify] https://crrev.com/281b34eeff49d0f6bc9b92eef2a8ac707cb5f665/ash/wm/maximize_mode/maximize_mode_window_manager.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e09bfe93b19d0823d49eea79881c0563e6239cd1 commit e09bfe93b19d0823d49eea79881c0563e6239cd1 Author: sky <sky@chromium.org> Date: Wed Jun 29 17:17:48 2016 Converts MaximizeModeWindowManager to use ash/common types BUG= 612629 TEST=covered by tests R=jamescook@chromium.org Review-Url: https://codereview.chromium.org/2103913003 Cr-Commit-Position: refs/heads/master@{#402846} [modify] https://crrev.com/e09bfe93b19d0823d49eea79881c0563e6239cd1/ash/aura/wm_root_window_controller_aura.cc [modify] https://crrev.com/e09bfe93b19d0823d49eea79881c0563e6239cd1/ash/aura/wm_root_window_controller_aura.h [modify] https://crrev.com/e09bfe93b19d0823d49eea79881c0563e6239cd1/ash/aura/wm_window_aura.cc [modify] https://crrev.com/e09bfe93b19d0823d49eea79881c0563e6239cd1/ash/aura/wm_window_aura.h [modify] https://crrev.com/e09bfe93b19d0823d49eea79881c0563e6239cd1/ash/common/wm_root_window_controller.h [modify] https://crrev.com/e09bfe93b19d0823d49eea79881c0563e6239cd1/ash/common/wm_window.h [modify] https://crrev.com/e09bfe93b19d0823d49eea79881c0563e6239cd1/ash/mus/bridge/wm_root_window_controller_mus.cc [modify] https://crrev.com/e09bfe93b19d0823d49eea79881c0563e6239cd1/ash/mus/bridge/wm_root_window_controller_mus.h [modify] https://crrev.com/e09bfe93b19d0823d49eea79881c0563e6239cd1/ash/mus/bridge/wm_window_mus.cc [modify] https://crrev.com/e09bfe93b19d0823d49eea79881c0563e6239cd1/ash/mus/bridge/wm_window_mus.h [modify] https://crrev.com/e09bfe93b19d0823d49eea79881c0563e6239cd1/ash/mus/root_window_controller.cc [modify] https://crrev.com/e09bfe93b19d0823d49eea79881c0563e6239cd1/ash/mus/root_window_controller.h [modify] https://crrev.com/e09bfe93b19d0823d49eea79881c0563e6239cd1/ash/wm/maximize_mode/DEPS [modify] https://crrev.com/e09bfe93b19d0823d49eea79881c0563e6239cd1/ash/wm/maximize_mode/maximize_mode_controller.cc [modify] https://crrev.com/e09bfe93b19d0823d49eea79881c0563e6239cd1/ash/wm/maximize_mode/maximize_mode_controller.h [modify] https://crrev.com/e09bfe93b19d0823d49eea79881c0563e6239cd1/ash/wm/maximize_mode/maximize_mode_window_manager.cc [modify] https://crrev.com/e09bfe93b19d0823d49eea79881c0563e6239cd1/ash/wm/maximize_mode/maximize_mode_window_manager.h [modify] https://crrev.com/e09bfe93b19d0823d49eea79881c0563e6239cd1/chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0be55e6a0d9f5737e472cafa25fd4b85f2e5ef15 commit 0be55e6a0d9f5737e472cafa25fd4b85f2e5ef15 Author: sky <sky@chromium.org> Date: Wed Jun 29 19:07:47 2016 Moves handful of classes in ash/wm/maximize_mode to ash/common These classes now only depend upon ash/common. BUG= 612629 TEST=covered by tests R=jamescook@chromium.org TBR=jamescook@chromium.org Review-Url: https://codereview.chromium.org/2108223002 Cr-Commit-Position: refs/heads/master@{#402888} [modify] https://crrev.com/0be55e6a0d9f5737e472cafa25fd4b85f2e5ef15/ash/ash.gyp [rename] https://crrev.com/0be55e6a0d9f5737e472cafa25fd4b85f2e5ef15/ash/common/wm/maximize_mode/maximize_mode_window_manager.cc [rename] https://crrev.com/0be55e6a0d9f5737e472cafa25fd4b85f2e5ef15/ash/common/wm/maximize_mode/maximize_mode_window_manager.h [rename] https://crrev.com/0be55e6a0d9f5737e472cafa25fd4b85f2e5ef15/ash/common/wm/maximize_mode/maximize_mode_window_state.cc [rename] https://crrev.com/0be55e6a0d9f5737e472cafa25fd4b85f2e5ef15/ash/common/wm/maximize_mode/maximize_mode_window_state.h [rename] https://crrev.com/0be55e6a0d9f5737e472cafa25fd4b85f2e5ef15/ash/common/wm/maximize_mode/workspace_backdrop_delegate.cc [rename] https://crrev.com/0be55e6a0d9f5737e472cafa25fd4b85f2e5ef15/ash/common/wm/maximize_mode/workspace_backdrop_delegate.h [modify] https://crrev.com/0be55e6a0d9f5737e472cafa25fd4b85f2e5ef15/ash/shell.cc [delete] https://crrev.com/4e7d4683e5b49649342a1dfe731c25108bac1ca1/ash/wm/maximize_mode/DEPS [modify] https://crrev.com/0be55e6a0d9f5737e472cafa25fd4b85f2e5ef15/ash/wm/maximize_mode/maximize_mode_controller.cc [modify] https://crrev.com/0be55e6a0d9f5737e472cafa25fd4b85f2e5ef15/ash/wm/maximize_mode/maximize_mode_window_manager_unittest.cc [modify] https://crrev.com/0be55e6a0d9f5737e472cafa25fd4b85f2e5ef15/ash/wm/workspace/workspace_layout_manager_unittest.cc [modify] https://crrev.com/0be55e6a0d9f5737e472cafa25fd4b85f2e5ef15/chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e2bde21744c5cefa38133556b2fb21fecea34518 commit e2bde21744c5cefa38133556b2fb21fecea34518 Author: sky <sky@chromium.org> Date: Fri Jul 01 18:27:02 2016 Move MaximizeModeController into ash/common BUG= 612629 TEST=covered by tests R=jamescook@chromium.org, yusukes@chromium.org TBR=yusukes@chromium.org Review-Url: https://codereview.chromium.org/2118643002 Cr-Commit-Position: refs/heads/master@{#403485} [modify] https://crrev.com/e2bde21744c5cefa38133556b2fb21fecea34518/ash/accelerators/accelerator_controller.cc [modify] https://crrev.com/e2bde21744c5cefa38133556b2fb21fecea34518/ash/accelerators/debug_commands.cc [modify] https://crrev.com/e2bde21744c5cefa38133556b2fb21fecea34518/ash/app_list/app_list_presenter_delegate.cc [modify] https://crrev.com/e2bde21744c5cefa38133556b2fb21fecea34518/ash/ash.gyp [modify] https://crrev.com/e2bde21744c5cefa38133556b2fb21fecea34518/ash/aura/wm_shell_aura.cc [modify] https://crrev.com/e2bde21744c5cefa38133556b2fb21fecea34518/ash/aura/wm_shell_aura.h [modify] https://crrev.com/e2bde21744c5cefa38133556b2fb21fecea34518/ash/common/ash_switches.cc [modify] https://crrev.com/e2bde21744c5cefa38133556b2fb21fecea34518/ash/common/ash_switches.h [rename] https://crrev.com/e2bde21744c5cefa38133556b2fb21fecea34518/ash/common/wm/maximize_mode/maximize_mode_controller.cc [rename] https://crrev.com/e2bde21744c5cefa38133556b2fb21fecea34518/ash/common/wm/maximize_mode/maximize_mode_controller.h [add] https://crrev.com/e2bde21744c5cefa38133556b2fb21fecea34518/ash/common/wm/maximize_mode/scoped_disable_internal_mouse_and_keyboard.h [modify] https://crrev.com/e2bde21744c5cefa38133556b2fb21fecea34518/ash/common/wm_shell.cc [modify] https://crrev.com/e2bde21744c5cefa38133556b2fb21fecea34518/ash/common/wm_shell.h [modify] https://crrev.com/e2bde21744c5cefa38133556b2fb21fecea34518/ash/content/display/screen_orientation_controller_chromeos_unittest.cc [modify] https://crrev.com/e2bde21744c5cefa38133556b2fb21fecea34518/ash/display/screen_orientation_controller_chromeos.cc [modify] https://crrev.com/e2bde21744c5cefa38133556b2fb21fecea34518/ash/frame/caption_buttons/frame_caption_button_container_view.cc [modify] https://crrev.com/e2bde21744c5cefa38133556b2fb21fecea34518/ash/frame/caption_buttons/frame_caption_button_container_view_unittest.cc [modify] https://crrev.com/e2bde21744c5cefa38133556b2fb21fecea34518/ash/frame/custom_frame_view_ash_unittest.cc [modify] https://crrev.com/e2bde21744c5cefa38133556b2fb21fecea34518/ash/mus/bridge/wm_shell_mus.cc [modify] https://crrev.com/e2bde21744c5cefa38133556b2fb21fecea34518/ash/mus/bridge/wm_shell_mus.h [modify] https://crrev.com/e2bde21744c5cefa38133556b2fb21fecea34518/ash/shell.cc [modify] https://crrev.com/e2bde21744c5cefa38133556b2fb21fecea34518/ash/shell.h [modify] https://crrev.com/e2bde21744c5cefa38133556b2fb21fecea34518/ash/system/chromeos/brightness/tray_brightness.cc [modify] https://crrev.com/e2bde21744c5cefa38133556b2fb21fecea34518/ash/system/chromeos/brightness/tray_brightness_unittest.cc [modify] https://crrev.com/e2bde21744c5cefa38133556b2fb21fecea34518/ash/system/chromeos/rotation/tray_rotation_lock.cc [modify] https://crrev.com/e2bde21744c5cefa38133556b2fb21fecea34518/ash/system/chromeos/rotation/tray_rotation_lock_unittest.cc [modify] https://crrev.com/e2bde21744c5cefa38133556b2fb21fecea34518/ash/system/overview/overview_button_tray.cc [modify] https://crrev.com/e2bde21744c5cefa38133556b2fb21fecea34518/ash/system/overview/overview_button_tray_unittest.cc [modify] https://crrev.com/e2bde21744c5cefa38133556b2fb21fecea34518/ash/virtual_keyboard_controller.cc [modify] https://crrev.com/e2bde21744c5cefa38133556b2fb21fecea34518/ash/virtual_keyboard_controller_unittest.cc [modify] https://crrev.com/e2bde21744c5cefa38133556b2fb21fecea34518/ash/wm/lock_state_controller_unittest.cc [modify] https://crrev.com/e2bde21744c5cefa38133556b2fb21fecea34518/ash/wm/maximize_mode/maximize_mode_controller_unittest.cc [modify] https://crrev.com/e2bde21744c5cefa38133556b2fb21fecea34518/ash/wm/maximize_mode/maximize_mode_window_manager_unittest.cc [delete] https://crrev.com/5709dede669972796cc01a98a3f280200545f7fe/ash/wm/maximize_mode/scoped_disable_internal_mouse_and_keyboard.h [modify] https://crrev.com/e2bde21744c5cefa38133556b2fb21fecea34518/ash/wm/maximize_mode/scoped_disable_internal_mouse_and_keyboard_ozone.h [modify] https://crrev.com/e2bde21744c5cefa38133556b2fb21fecea34518/ash/wm/maximize_mode/scoped_disable_internal_mouse_and_keyboard_x11.h [modify] https://crrev.com/e2bde21744c5cefa38133556b2fb21fecea34518/ash/wm/overview/window_selector_unittest.cc [modify] https://crrev.com/e2bde21744c5cefa38133556b2fb21fecea34518/ash/wm/power_button_controller.cc [modify] https://crrev.com/e2bde21744c5cefa38133556b2fb21fecea34518/chrome/browser/chromeos/display/display_preferences_unittest.cc [modify] https://crrev.com/e2bde21744c5cefa38133556b2fb21fecea34518/chrome/browser/extensions/display_info_provider_chromeos_unittest.cc [modify] https://crrev.com/e2bde21744c5cefa38133556b2fb21fecea34518/chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.cc [modify] https://crrev.com/e2bde21744c5cefa38133556b2fb21fecea34518/chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos_unittest.cc [modify] https://crrev.com/e2bde21744c5cefa38133556b2fb21fecea34518/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash_browsertest.cc [modify] https://crrev.com/e2bde21744c5cefa38133556b2fb21fecea34518/chrome/browser/ui/views/tabs/tab_drag_controller.cc [modify] https://crrev.com/e2bde21744c5cefa38133556b2fb21fecea34518/chrome/browser/ui/webui/chromeos/touch_view_controller_delegate.cc [modify] https://crrev.com/e2bde21744c5cefa38133556b2fb21fecea34518/components/arc/window_manager/arc_window_manager_bridge.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c68696cc6a6fb8e052842e81905cf92777de47d2 commit c68696cc6a6fb8e052842e81905cf92777de47d2 Author: sky <sky@chromium.org> Date: Fri Jul 01 21:06:02 2016 Moves Shell::maximize_mode_controller() to WmShell BUG= 612629 TEST=covered by tests R=jamescook@chromium.org TBR=yusukes@chromium.org Review-Url: https://codereview.chromium.org/2113053003 Cr-Commit-Position: refs/heads/master@{#403529} [modify] https://crrev.com/c68696cc6a6fb8e052842e81905cf92777de47d2/ash/accelerators/debug_commands.cc [modify] https://crrev.com/c68696cc6a6fb8e052842e81905cf92777de47d2/ash/app_list/app_list_presenter_delegate.cc [modify] https://crrev.com/c68696cc6a6fb8e052842e81905cf92777de47d2/ash/common/wm_shell.cc [modify] https://crrev.com/c68696cc6a6fb8e052842e81905cf92777de47d2/ash/common/wm_shell.h [modify] https://crrev.com/c68696cc6a6fb8e052842e81905cf92777de47d2/ash/content/display/screen_orientation_controller_chromeos_unittest.cc [modify] https://crrev.com/c68696cc6a6fb8e052842e81905cf92777de47d2/ash/display/screen_orientation_controller_chromeos.cc [modify] https://crrev.com/c68696cc6a6fb8e052842e81905cf92777de47d2/ash/frame/caption_buttons/frame_caption_button_container_view.cc [modify] https://crrev.com/c68696cc6a6fb8e052842e81905cf92777de47d2/ash/frame/caption_buttons/frame_caption_button_container_view_unittest.cc [modify] https://crrev.com/c68696cc6a6fb8e052842e81905cf92777de47d2/ash/frame/custom_frame_view_ash_unittest.cc [modify] https://crrev.com/c68696cc6a6fb8e052842e81905cf92777de47d2/ash/mus/bridge/wm_shell_mus.cc [modify] https://crrev.com/c68696cc6a6fb8e052842e81905cf92777de47d2/ash/shell.cc [modify] https://crrev.com/c68696cc6a6fb8e052842e81905cf92777de47d2/ash/shell.h [modify] https://crrev.com/c68696cc6a6fb8e052842e81905cf92777de47d2/ash/system/chromeos/brightness/tray_brightness.cc [modify] https://crrev.com/c68696cc6a6fb8e052842e81905cf92777de47d2/ash/system/chromeos/brightness/tray_brightness_unittest.cc [modify] https://crrev.com/c68696cc6a6fb8e052842e81905cf92777de47d2/ash/system/chromeos/rotation/tray_rotation_lock.cc [modify] https://crrev.com/c68696cc6a6fb8e052842e81905cf92777de47d2/ash/system/chromeos/rotation/tray_rotation_lock_unittest.cc [modify] https://crrev.com/c68696cc6a6fb8e052842e81905cf92777de47d2/ash/system/overview/overview_button_tray.cc [modify] https://crrev.com/c68696cc6a6fb8e052842e81905cf92777de47d2/ash/system/overview/overview_button_tray_unittest.cc [modify] https://crrev.com/c68696cc6a6fb8e052842e81905cf92777de47d2/ash/virtual_keyboard_controller.cc [modify] https://crrev.com/c68696cc6a6fb8e052842e81905cf92777de47d2/ash/virtual_keyboard_controller_unittest.cc [modify] https://crrev.com/c68696cc6a6fb8e052842e81905cf92777de47d2/ash/wm/lock_state_controller_unittest.cc [modify] https://crrev.com/c68696cc6a6fb8e052842e81905cf92777de47d2/ash/wm/maximize_mode/maximize_mode_controller_unittest.cc [modify] https://crrev.com/c68696cc6a6fb8e052842e81905cf92777de47d2/ash/wm/maximize_mode/maximize_mode_window_manager_unittest.cc [modify] https://crrev.com/c68696cc6a6fb8e052842e81905cf92777de47d2/ash/wm/overview/window_selector_unittest.cc [modify] https://crrev.com/c68696cc6a6fb8e052842e81905cf92777de47d2/ash/wm/power_button_controller.cc [modify] https://crrev.com/c68696cc6a6fb8e052842e81905cf92777de47d2/chrome/browser/chromeos/display/display_preferences_unittest.cc [modify] https://crrev.com/c68696cc6a6fb8e052842e81905cf92777de47d2/chrome/browser/extensions/display_info_provider_chromeos_unittest.cc [modify] https://crrev.com/c68696cc6a6fb8e052842e81905cf92777de47d2/chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.cc [modify] https://crrev.com/c68696cc6a6fb8e052842e81905cf92777de47d2/chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos_unittest.cc [modify] https://crrev.com/c68696cc6a6fb8e052842e81905cf92777de47d2/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash_browsertest.cc [modify] https://crrev.com/c68696cc6a6fb8e052842e81905cf92777de47d2/chrome/browser/ui/views/tabs/tab_drag_controller.cc [modify] https://crrev.com/c68696cc6a6fb8e052842e81905cf92777de47d2/chrome/browser/ui/webui/chromeos/touch_view_controller_delegate.cc [modify] https://crrev.com/c68696cc6a6fb8e052842e81905cf92777de47d2/components/arc/window_manager/arc_window_manager_bridge.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3469a6d1b37bed86a1f08ada6c3e350a236158ba commit 3469a6d1b37bed86a1f08ada6c3e350a236158ba Author: sky <sky@chromium.org> Date: Fri Jul 01 23:44:33 2016 Fixes mash Turns out maximize controller uses dbus, which we aren't yet creating. Temporarily disable mojo:ash from creating maximize controller until sorted out. BUG= 612629 TEST=covered by tests R=jamescook@chromium.org TBR=jamescook@chromium.org Review-Url: https://codereview.chromium.org/2120003002 Cr-Commit-Position: refs/heads/master@{#403563} [modify] https://crrev.com/3469a6d1b37bed86a1f08ada6c3e350a236158ba/ash/mus/bridge/wm_shell_mus.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6eff4c6df93fd22ce101d61883f77fe50df89ea1 commit 6eff4c6df93fd22ce101d61883f77fe50df89ea1 Author: jamescook <jamescook@chromium.org> Date: Thu Jul 07 22:20:53 2016 Initialize DBus in mojo:ash on chrome os This fixes a crash when running mash_unittests. Also add back initialization of MaximizeModeController on mus, which was removed to avoid the crash. BUG= 612629 TEST=mash_unittests Review-Url: https://codereview.chromium.org/2116153002 Cr-Commit-Position: refs/heads/master@{#404257} [modify] https://crrev.com/6eff4c6df93fd22ce101d61883f77fe50df89ea1/ash/mus/BUILD.gn [modify] https://crrev.com/6eff4c6df93fd22ce101d61883f77fe50df89ea1/ash/mus/bridge/wm_shell_mus.cc [modify] https://crrev.com/6eff4c6df93fd22ce101d61883f77fe50df89ea1/ash/mus/window_manager_application.cc
This bug has been subsumed by 640365.
Comment 1 by sky@chromium.org
, Jun 23 2016Status: Started (was: Available)