Issue 612627 link

Starred by 1 user

Issue metadata

Status:	Archived
Owner:	sky@chromium.org
Closed:	Oct 2016
Cc:	mustash-bugs@google.com
Components:	Internals>Services>WindowService
EstimatedDays:	----
NextAction:	----
OS:	Chrome
Pri:	3
Type:	Bug
mash Proj-Mustash VerifyIn-57 VerifyIn-58 VerifyIn-59 VerifyIn-60 VerifyIn-61

Update WorkspaceLayoutManagerUnittests for multiple displays

Project Member Reported by sky@chromium.org, May 17 2016

Issue description

There are a number of tests in mash/wm/workspace/workspace_layout_manager_unittest that requires multiple displays. This code needs to be updated once the wm better supports multiple displays.
611563 makes moving windows between displays impractical, not sure if these tests trigger that.

Comment 1 by sky@chromium.org, May 17 2016

Labels: OS-Chrome

Comment 2 by dtapu...@chromium.org, Sep 2 2016

Components: MUS

Project Member

Comment 3 by bugdroid1@chromium.org, Sep 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/20686a4c5e578609252f1ba564010db7b5799338

commit 20686a4c5e578609252f1ba564010db7b5799338
Author: sky <sky@chromium.org>
Date: Tue Sep 13 01:26:54 2016

Adds support for multiple displays to WmTestBase

This gives the basics. The one test I hoped to use against it fails
for other reasons (WmWindowMus::SetBoundsInScreen()) isn't implemented
yet.

BUG= 612627 
TEST=none

Review-Url: https://codereview.chromium.org/2322613002
Cr-Commit-Position: refs/heads/master@{#418133}

[modify] https://crrev.com/20686a4c5e578609252f1ba564010db7b5799338/ash/mus/BUILD.gn
[modify] https://crrev.com/20686a4c5e578609252f1ba564010db7b5799338/ash/mus/test/wm_test_base.cc
[modify] https://crrev.com/20686a4c5e578609252f1ba564010db7b5799338/ash/mus/test/wm_test_base.h
[modify] https://crrev.com/20686a4c5e578609252f1ba564010db7b5799338/ash/mus/test/wm_test_helper.cc
[modify] https://crrev.com/20686a4c5e578609252f1ba564010db7b5799338/ash/mus/test/wm_test_helper.h
[delete] https://crrev.com/f792cf02dde6c70831ac7c6cd8cca77636c37c4f/ash/mus/test/wm_test_screen.cc
[delete] https://crrev.com/f792cf02dde6c70831ac7c6cd8cca77636c37c4f/ash/mus/test/wm_test_screen.h
[modify] https://crrev.com/20686a4c5e578609252f1ba564010db7b5799338/ash/mus/window_manager.cc
[modify] https://crrev.com/20686a4c5e578609252f1ba564010db7b5799338/ash/mus/window_manager.h
[modify] https://crrev.com/20686a4c5e578609252f1ba564010db7b5799338/ash/mus/workspace/workspace_layout_manager_unittest.cc
[modify] https://crrev.com/20686a4c5e578609252f1ba564010db7b5799338/ash/root_window_controller.cc
[modify] https://crrev.com/20686a4c5e578609252f1ba564010db7b5799338/services/ui/public/cpp/tests/test_window_tree_client_setup.cc
[modify] https://crrev.com/20686a4c5e578609252f1ba564010db7b5799338/services/ui/public/cpp/tests/test_window_tree_client_setup.h
[modify] https://crrev.com/20686a4c5e578609252f1ba564010db7b5799338/services/ui/public/cpp/tests/window_tree_client_private.cc
[modify] https://crrev.com/20686a4c5e578609252f1ba564010db7b5799338/services/ui/public/cpp/tests/window_tree_client_private.h