//chrome:chrome_framework does not re-link if the framework.order file changes |
||||||
Issue descriptionWhen implementing the //chrome:verify_chrome_framework_order step in https://codereview.chromium.org/1980173002/, we started passing the framework.order file to the linker. However if the framework.order file changes, a re-link does not occur because this file is not listed as a sources[] or an inputs[]. Adding the file to either of those lists didn't have any effect. We need to figure out a way to get the framework.order file to cause a re-link if it changes.
,
May 18 2016
,
Jun 3 2016
This also affects the .saves file inputs to the linker for striping: https://codereview.chromium.org/1999513002/
,
Jun 8 2016
Re-assigning this to brettw@ now that he's back in the office. Brett, we discussed this briefly last week or the week before; I think the thing to do here is to make inputs a proper dependency on links, not just an order-only dependency, since link commands have no concept of deps files that they could dump precise lists into.
,
Jun 17 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/57ac2eae0f67ef9310e2fad40258b1d45ac82435 commit 57ac2eae0f67ef9310e2fad40258b1d45ac82435 Author: phosek <phosek@chromium.org> Date: Fri Jun 17 21:49:02 2016 GN: Use implicit dependency for binary input deps This is to ensure that the input gets rebuilt when the depencies change even when they are not included in the depfile generated by the compiler. BUG=612623 Review-Url: https://codereview.chromium.org/2071573003 Cr-Commit-Position: refs/heads/master@{#400515} [modify] https://crrev.com/57ac2eae0f67ef9310e2fad40258b1d45ac82435/tools/gn/docs/reference.md [modify] https://crrev.com/57ac2eae0f67ef9310e2fad40258b1d45ac82435/tools/gn/ninja_binary_target_writer.cc [modify] https://crrev.com/57ac2eae0f67ef9310e2fad40258b1d45ac82435/tools/gn/ninja_binary_target_writer.h [modify] https://crrev.com/57ac2eae0f67ef9310e2fad40258b1d45ac82435/tools/gn/ninja_binary_target_writer_unittest.cc [modify] https://crrev.com/57ac2eae0f67ef9310e2fad40258b1d45ac82435/tools/gn/ninja_target_writer.cc [modify] https://crrev.com/57ac2eae0f67ef9310e2fad40258b1d45ac82435/tools/gn/ninja_target_writer_unittest.cc [modify] https://crrev.com/57ac2eae0f67ef9310e2fad40258b1d45ac82435/tools/gn/variables.cc
,
Jul 1 2016
bouncing this back to rsesek@; I think just listing this in `inputs` should work now.
,
Jul 1 2016
,
Jul 1 2016
This seems to work for executable but not shared_library targets.
,
Jul 1 2016
,
Sep 22 2016
Is this still an issue?
,
Sep 23 2016
Yeah, when I tested this in #8/#9 this wasn't fully done. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by dpranke@chromium.org
, May 18 2016Labels: -Pri-3 Build-Tools-GN Pri-1