[Mac] [Material Design] Bookmarks Bar: Too much space between Bookmarks |
||||
Issue descriptionVersion: Chromium Build 394171 OS: 10.11.5 What steps will reproduce the problem? (1) save some bookmarks (2) take a look at the space between two bookmarks (3) What is the expected output? What do you see instead? There is too much space between Bookmarks. Not sure, if this is intended. Please use labels and text to provide additional information. A screenshot is attached. Above is the old Bookmarksbar, below is the new MD-Bookmarksbar. Thanks, Mehmet
,
May 17 2016
The spec calls for 16pt between buttons (before it was 2pt).
,
May 18 2016
Hi shrike@. Thanks for your feedback. From the specs in issue 593548 the space between text and next favicon is 16pt. But it looks, that actually it is 16pt between the the hover button, which also have 3pt on both sides. This means, that there are probably 6pt too much padding. What do you think? Thanks in advance.
,
May 18 2016
I would be surprised if the designer spec'ed 16pts from text to favicon but I will check in with him for clarification.
,
May 18 2016
Okay, thank you!
,
May 18 2016
bettes@ agrees the distance should be tightened to 10pt.
,
May 18 2016
Great! :-)
,
May 18 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/20bcb73188c083c6fa2c055670f84e3d3544eb9e commit 20bcb73188c083c6fa2c055670f84e3d3544eb9e Author: shrike <shrike@chromium.org> Date: Wed May 18 23:00:31 2016 [Mac][Material Design] Reduce distance between bookmark buttons. The distance between bookmark buttons should be 10pt, not 16pt. R=avi@chromium.org BUG= 612612 Review-Url: https://codereview.chromium.org/1992063002 Cr-Commit-Position: refs/heads/master@{#394583} [modify] https://crrev.com/20bcb73188c083c6fa2c055670f84e3d3544eb9e/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm
,
May 18 2016
|
||||
►
Sign in to add a comment |
||||
Comment 1 by meh...@chromium.org
, May 17 2016