[Mac] [Material Design] Bookmarks Bar: Bookmarktext and Favicon need to be 1pt higher to be vertically centered in the hover state & the buttons need to be centered vertically on the the bookmarks bar |
||||
Issue descriptionVersion: Chromium Build 394171 OS: 10.11.5 What steps will reproduce the problem? (1) Save www.google.com as a bookmark on the Bar. (2) Hover over the bookmark. (3) Take a look at the favicon and the text. What is the expected output? What do you see instead? The favicon and the text are not vertically centered. They could be 1pt higher. At the moment the favicons are very close to bottom of the hover button. Please use labels and text to provide additional information. A screenshot is attached. Thanks, Mehmet
,
May 18 2016
,
May 18 2016
Updating title regarding issue 612849 .
,
May 18 2016
Hover background spec located in Issue 593548 .
,
May 18 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d6bb602b460c9e39739a1e934347d278bd6b501b commit d6bb602b460c9e39739a1e934347d278bd6b501b Author: shrike <shrike@chromium.org> Date: Wed May 18 23:33:12 2016 [Mac][Material Design] Bring bookmark hover background up to spec. The MD hover background currently does not match the spec. R=avi@chromium.org BUG= 612598 Review-Url: https://codereview.chromium.org/1988223002 Cr-Commit-Position: refs/heads/master@{#394599} [modify] https://crrev.com/d6bb602b460c9e39739a1e934347d278bd6b501b/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_constants.h [modify] https://crrev.com/d6bb602b460c9e39739a1e934347d278bd6b501b/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm [modify] https://crrev.com/d6bb602b460c9e39739a1e934347d278bd6b501b/chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell.mm [modify] https://crrev.com/d6bb602b460c9e39739a1e934347d278bd6b501b/chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell_unittest.mm [modify] https://crrev.com/d6bb602b460c9e39739a1e934347d278bd6b501b/chrome/browser/ui/cocoa/gradient_button_cell.mm
,
May 18 2016
|
||||
►
Sign in to add a comment |
||||
Comment 1 by shrike@chromium.org
, May 17 2016