Issue metadata
Sign in to add a comment
|
Increased main thread pipelining |
||||||||||||||||||||||||||||||||||
Issue descriptionFeature description: Eng owner: sunnyps@chromium.org Product owner: rschoen@chromium.org The --enable-main-frame-before-activation flag increases main thread pipelining by making cc scheduler not wait for activation before sending a main frame. This flag improves performance on the animometer leaves benchmark by ~20% on Mac and ~100% on Android with GPU raster enabled. This flag will be controlled by a finch experiment and is always disabled when a device has fewer than 4 cores. We want to gauge the performance impact of this flag on various rendering metrics e.g. Scheduling.Renderer.BeginMainFrameIntervalCritical, Event.Latency.TouchToFirstScrollUpdateSwapBegin, etc. Finch ambassador: rkaplow@chromium.org
,
May 18 2016
Double checked with vasilii@
,
May 19 2016
,
May 19 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0e8a1ccc39289aaaec0ecfb73c2eee995de3715e commit 0e8a1ccc39289aaaec0ecfb73c2eee995de3715e Author: sunnyps <sunnyps@chromium.org> Date: Thu May 19 21:33:35 2016 cc: Remove unnecessary DCHECK and dead code from scheduler. This removes a DCHECK which fails in main frame before activation mode and cleans some of the code in WillCommit. Some dead code around forced redraw state is also removed. R=enne@chromium.org BUG= 612596 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review-Url: https://codereview.chromium.org/1997473003 Cr-Commit-Position: refs/heads/master@{#394874} [modify] https://crrev.com/0e8a1ccc39289aaaec0ecfb73c2eee995de3715e/cc/scheduler/scheduler_state_machine.cc
,
May 20 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/36a74489ec5e4fb898a7984398ad79b3798f70d7 commit 36a74489ec5e4fb898a7984398ad79b3798f70d7 Author: sunnyps <sunnyps@chromium.org> Date: Fri May 20 23:40:08 2016 Enable main frame before activation on waterfall. This CL enables the main frame before activation on the waterfall so that we have adequate coverage while we launch this via Finch. R=rkaplow@chromium.org BUG= 612596 Review-Url: https://codereview.chromium.org/1988413003 Cr-Commit-Position: refs/heads/master@{#395206} [modify] https://crrev.com/36a74489ec5e4fb898a7984398ad79b3798f70d7/testing/variations/fieldtrial_testing_config_android.json [modify] https://crrev.com/36a74489ec5e4fb898a7984398ad79b3798f70d7/testing/variations/fieldtrial_testing_config_chromeos.json [modify] https://crrev.com/36a74489ec5e4fb898a7984398ad79b3798f70d7/testing/variations/fieldtrial_testing_config_linux.json [modify] https://crrev.com/36a74489ec5e4fb898a7984398ad79b3798f70d7/testing/variations/fieldtrial_testing_config_mac.json [modify] https://crrev.com/36a74489ec5e4fb898a7984398ad79b3798f70d7/testing/variations/fieldtrial_testing_config_win.json
,
May 23 2016
,
May 23 2016
Your change meets the bar and is auto-approved for M52 (branch: 2743)
,
May 23 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a5a85a14ea9519e57c3484b9351e79416a06083f commit a5a85a14ea9519e57c3484b9351e79416a06083f Author: Sunny Sachanandani <sunnyps@chromium.org> Date: Mon May 23 19:17:40 2016 Enable main frame before activation on waterfall. This CL enables the main frame before activation on the waterfall so that we have adequate coverage while we launch this via Finch. R=rkaplow@chromium.org BUG= 612596 Review-Url: https://codereview.chromium.org/1988413003 Cr-Commit-Position: refs/heads/master@{#395206} (cherry picked from commit 36a74489ec5e4fb898a7984398ad79b3798f70d7) Review URL: https://codereview.chromium.org/2000293002 . Cr-Commit-Position: refs/branch-heads/2743@{#11} Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939} [modify] https://crrev.com/a5a85a14ea9519e57c3484b9351e79416a06083f/testing/variations/fieldtrial_testing_config_android.json [modify] https://crrev.com/a5a85a14ea9519e57c3484b9351e79416a06083f/testing/variations/fieldtrial_testing_config_chromeos.json [modify] https://crrev.com/a5a85a14ea9519e57c3484b9351e79416a06083f/testing/variations/fieldtrial_testing_config_linux.json [modify] https://crrev.com/a5a85a14ea9519e57c3484b9351e79416a06083f/testing/variations/fieldtrial_testing_config_mac.json [modify] https://crrev.com/a5a85a14ea9519e57c3484b9351e79416a06083f/testing/variations/fieldtrial_testing_config_win.json
,
May 26 2016
,
May 31 2016
,
Jun 6 2016
Please provide the following information, so that chrome test engineering team can proceed with testing. 1. Is the feature code complete & enabled in the trunk and ready for testing? 2. Does this require manual testing? 3. Any specific setup / flags required?
,
Jun 6 2016
The feature was disabled (server side) because of issue 616086 . I have a fix that hopefully can be merged into M52 but probably not today.
,
Jun 14 2016
Security survey: https://chrome-security-survey.appspot.com/p/chrome-gpu/main-frame-before-activation Test survey: 1. Feature implementation status (what is currently working and not working/known issues, where/how is it enabled etc.) This feature is enabled via a finch experiment (50/50) on dev/canary but I plan to enable it fully soon. The scrolling issue for which we last disabled the experiment is fixed on canary and also merged into M52. The next dev/beta releases should have it. 2. Link to Test Plan: There's no new test plan for this - existing tests should be sufficient. 3. What's automated? (Unit tests, API tests, Browser tests) Please provide links to automated tests: There are a few unit tests for edge cases of this feature: https://cs.chromium.org/chromium/src/cc/trees/layer_tree_host_unittest_scroll.cc?rcl=0&l=1520 https://cs.chromium.org/chromium/src/cc/trees/layer_tree_host_unittest_scroll.cc?rcl=0&l=1650 https://cs.chromium.org/chromium/src/cc/trees/layer_tree_host_unittest_proxy.cc?rcl=0&l=339 All telemetry based tests on the waterfall (browser tests, perf, etc.) are already running with this feature enabled. 4. Is there a mechanism to turn off the feature if it breaks product functionality or performance? The finch experiment MainFrameBeforeActivation is used to control this feature so it can be turned off very easily. 5. List UMA stats if any: Scheduling.Renderer.BeginMainFrameIntervalCritical Scheduling.Renderer.CommitInterval Scheduling.Renderer.DrawInterval Event.Latency.TouchToScrollUpdateSwapBegin 6. Any performance impact? Did the feature get tested on perf waterfall? This feature is enabled on the perf waterfall. Minor regression in page load times that's being investigated: crbug.com/614482
,
Jun 14 2016
,
Jun 22 2016
,
Jun 23 2016
Is the feature enabled fully on M52 Beta for Android?
,
Jun 28 2016
This did not go into M52 but will definitely go in for M53. Trying to decide if this needs to be a feature given that we've had a lot of testing on canary/dev without issues and it's a relatively minor change. Maybe we'll just enable it on canary and let it go through dev/beta/stable.
,
Jun 28 2016
,
Jun 28 2016
,
Jul 20 2016
Not a launch bug any more - this is being default enabled on canary (and then on M53) since there haven't been any issues for the last few weeks on canary/dev.
,
Jul 21 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/45041a7e286c665ab14d8ae0b182e1c11cef65ed commit 45041a7e286c665ab14d8ae0b182e1c11cef65ed Author: sunnyps <sunnyps@chromium.org> Date: Thu Jul 21 18:40:41 2016 Default enable main frame before activation and remove finch experiment. The finch experiment hasn't revealed any regressions other than in page load times which has been deemed a blink scheduler issue (see crbug.com/614482). R=piman@chromium.org,rkaplow@chromium.org BUG= 612596 Review-Url: https://codereview.chromium.org/2159103008 Cr-Commit-Position: refs/heads/master@{#406916} [modify] https://crrev.com/45041a7e286c665ab14d8ae0b182e1c11cef65ed/content/browser/gpu/compositor_util.cc [modify] https://crrev.com/45041a7e286c665ab14d8ae0b182e1c11cef65ed/content/public/common/content_features.cc [modify] https://crrev.com/45041a7e286c665ab14d8ae0b182e1c11cef65ed/content/public/common/content_features.h [modify] https://crrev.com/45041a7e286c665ab14d8ae0b182e1c11cef65ed/testing/variations/fieldtrial_testing_config_android.json [modify] https://crrev.com/45041a7e286c665ab14d8ae0b182e1c11cef65ed/testing/variations/fieldtrial_testing_config_chromeos.json [modify] https://crrev.com/45041a7e286c665ab14d8ae0b182e1c11cef65ed/testing/variations/fieldtrial_testing_config_linux.json [modify] https://crrev.com/45041a7e286c665ab14d8ae0b182e1c11cef65ed/testing/variations/fieldtrial_testing_config_mac.json [modify] https://crrev.com/45041a7e286c665ab14d8ae0b182e1c11cef65ed/testing/variations/fieldtrial_testing_config_win.json
,
Jul 22 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2863590ee8e57543f646f4308130765afb02bd44 commit 2863590ee8e57543f646f4308130765afb02bd44 Author: tedchoc <tedchoc@chromium.org> Date: Fri Jul 22 00:54:56 2016 Revert of Default enable main frame before activation and remove finch experiment. (patchset #1 id:1 of https://codereview.chromium.org/2159103008/ ) Reason for revert: Speculative revert for failing WebView tests on Lollipop: https://build.chromium.org/p/chromium.android/builders/Lollipop%20Phone%20Tester/builds/5794 https://build.chromium.org/p/chromium.android/builders/Lollipop%20Tablet%20Tester/builds/4054 Both phone and tablet started failing and this is the most "suspicious" change. boliu@ can help investigate further assuming this holds true. Original issue's description: > Default enable main frame before activation and remove finch experiment. > > The finch experiment hasn't revealed any regressions other than in page > load times which has been deemed a blink scheduler issue (see > crbug.com/614482). > > R=piman@chromium.org,rkaplow@chromium.org > BUG= 612596 > > Committed: https://crrev.com/45041a7e286c665ab14d8ae0b182e1c11cef65ed > Cr-Commit-Position: refs/heads/master@{#406916} TBR=piman@chromium.org,rkaplow@chromium.org,sunnyps@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 612596 Review-Url: https://codereview.chromium.org/2170233002 Cr-Commit-Position: refs/heads/master@{#407003} [modify] https://crrev.com/2863590ee8e57543f646f4308130765afb02bd44/content/browser/gpu/compositor_util.cc [modify] https://crrev.com/2863590ee8e57543f646f4308130765afb02bd44/content/public/common/content_features.cc [modify] https://crrev.com/2863590ee8e57543f646f4308130765afb02bd44/content/public/common/content_features.h [modify] https://crrev.com/2863590ee8e57543f646f4308130765afb02bd44/testing/variations/fieldtrial_testing_config_android.json [modify] https://crrev.com/2863590ee8e57543f646f4308130765afb02bd44/testing/variations/fieldtrial_testing_config_chromeos.json [modify] https://crrev.com/2863590ee8e57543f646f4308130765afb02bd44/testing/variations/fieldtrial_testing_config_linux.json [modify] https://crrev.com/2863590ee8e57543f646f4308130765afb02bd44/testing/variations/fieldtrial_testing_config_mac.json [modify] https://crrev.com/2863590ee8e57543f646f4308130765afb02bd44/testing/variations/fieldtrial_testing_config_win.json
,
Aug 9 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ad3235e21ef666ea29cea5a8f85c303589880297 commit ad3235e21ef666ea29cea5a8f85c303589880297 Author: sunnyps <sunnyps@chromium.org> Date: Tue Aug 09 04:57:52 2016 cc: Complete swap promise for aborted commit after pending activation. Swap promises are used by android webview (via the visual state message in FrameSwapMessageQueue) to wait until all changes made on the main thread are ready to be drawn. This happens in two ways either we go through the commit and activate it or if there is aborted commit because there are no updates in the commit. In either case we assume that the compositor is ready to draw all changes. With main frame before activation we have two frames in flight where one frame is being activated and the next one is sent to the main thread. In case of aborted commits the swap promise for a frame might be completed before the previous frame is activated. This means that the assumption above re: being ready to draw is invalid. This CL allows passing swap promises from the main thread to the impl thread on aborted commits. If activation is pending on the impl thread the swap promises are queued up to be completed upon activation, otherwise the promises are completed immediately. For SingleThreadProxy and RemoteChannel we don't have multiple frames in flight so we complete the promises on the main thread as before. BUG= 612596 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Review-Url: https://codereview.chromium.org/2188093002 Cr-Commit-Position: refs/heads/master@{#410576} [modify] https://crrev.com/ad3235e21ef666ea29cea5a8f85c303589880297/cc/test/layer_tree_test.cc [modify] https://crrev.com/ad3235e21ef666ea29cea5a8f85c303589880297/cc/trees/channel_main.h [modify] https://crrev.com/ad3235e21ef666ea29cea5a8f85c303589880297/cc/trees/layer_tree_host.cc [modify] https://crrev.com/ad3235e21ef666ea29cea5a8f85c303589880297/cc/trees/layer_tree_host.h [modify] https://crrev.com/ad3235e21ef666ea29cea5a8f85c303589880297/cc/trees/layer_tree_host_impl.cc [modify] https://crrev.com/ad3235e21ef666ea29cea5a8f85c303589880297/cc/trees/layer_tree_host_impl.h [modify] https://crrev.com/ad3235e21ef666ea29cea5a8f85c303589880297/cc/trees/layer_tree_host_unittest.cc [modify] https://crrev.com/ad3235e21ef666ea29cea5a8f85c303589880297/cc/trees/layer_tree_impl.cc [modify] https://crrev.com/ad3235e21ef666ea29cea5a8f85c303589880297/cc/trees/layer_tree_impl.h [modify] https://crrev.com/ad3235e21ef666ea29cea5a8f85c303589880297/cc/trees/proxy_impl.cc [modify] https://crrev.com/ad3235e21ef666ea29cea5a8f85c303589880297/cc/trees/proxy_impl.h [modify] https://crrev.com/ad3235e21ef666ea29cea5a8f85c303589880297/cc/trees/proxy_main.cc [modify] https://crrev.com/ad3235e21ef666ea29cea5a8f85c303589880297/cc/trees/remote_channel_impl.cc [modify] https://crrev.com/ad3235e21ef666ea29cea5a8f85c303589880297/cc/trees/remote_channel_main.cc [modify] https://crrev.com/ad3235e21ef666ea29cea5a8f85c303589880297/cc/trees/remote_channel_main.h [modify] https://crrev.com/ad3235e21ef666ea29cea5a8f85c303589880297/cc/trees/single_thread_proxy.cc [modify] https://crrev.com/ad3235e21ef666ea29cea5a8f85c303589880297/cc/trees/threaded_channel.cc [modify] https://crrev.com/ad3235e21ef666ea29cea5a8f85c303589880297/cc/trees/threaded_channel.h
,
Sep 3 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/398642c9f408c394cd87564780b64602e8d310f9 commit 398642c9f408c394cd87564780b64602e8d310f9 Author: sunnyps <sunnyps@chromium.org> Date: Sat Sep 03 00:04:09 2016 Reland of Default enable main frame before activation and remove finch experiment. (patchset #1 id:1 of https://codereview.chromium.org/2170233002/ ) Reason for revert: Relanding after fixing android webview issues Original issue's description: > Revert of Default enable main frame before activation and remove finch experiment. (patchset #1 id:1 of https://codereview.chromium.org/2159103008/ ) > > Reason for revert: > Speculative revert for failing WebView tests on Lollipop: > > https://build.chromium.org/p/chromium.android/builders/Lollipop%20Phone%20Tester/builds/5794 > https://build.chromium.org/p/chromium.android/builders/Lollipop%20Tablet%20Tester/builds/4054 > > Both phone and tablet started failing and this is the most "suspicious" change. boliu@ can help investigate further assuming this holds true. > > Original issue's description: > > Default enable main frame before activation and remove finch experiment. > > > > The finch experiment hasn't revealed any regressions other than in page > > load times which has been deemed a blink scheduler issue (see > > crbug.com/614482). > > > > R=piman@chromium.org,rkaplow@chromium.org > > BUG= 612596 > > > > Committed: https://crrev.com/45041a7e286c665ab14d8ae0b182e1c11cef65ed > > Cr-Commit-Position: refs/heads/master@{#406916} > > TBR=piman@chromium.org,rkaplow@chromium.org,sunnyps@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG= 612596 > > Committed: https://crrev.com/2863590ee8e57543f646f4308130765afb02bd44 > Cr-Commit-Position: refs/heads/master@{#407003} TBR=piman@chromium.org,rkaplow@chromium.org,tedchoc@chromium.org BUG= 612596 Review-Url: https://codereview.chromium.org/2184243003 Cr-Commit-Position: refs/heads/master@{#416402} [modify] https://crrev.com/398642c9f408c394cd87564780b64602e8d310f9/content/browser/gpu/compositor_util.cc [modify] https://crrev.com/398642c9f408c394cd87564780b64602e8d310f9/content/public/common/content_features.cc [modify] https://crrev.com/398642c9f408c394cd87564780b64602e8d310f9/content/public/common/content_features.h [modify] https://crrev.com/398642c9f408c394cd87564780b64602e8d310f9/testing/variations/fieldtrial_testing_config_android.json [modify] https://crrev.com/398642c9f408c394cd87564780b64602e8d310f9/testing/variations/fieldtrial_testing_config_chromeos.json [modify] https://crrev.com/398642c9f408c394cd87564780b64602e8d310f9/testing/variations/fieldtrial_testing_config_linux.json [modify] https://crrev.com/398642c9f408c394cd87564780b64602e8d310f9/testing/variations/fieldtrial_testing_config_mac.json [modify] https://crrev.com/398642c9f408c394cd87564780b64602e8d310f9/testing/variations/fieldtrial_testing_config_win.json
,
Sep 6 2016
Requesting merge to M54 for last CL.
,
Sep 6 2016
Your change meets the bar and is auto-approved for M54 (branch: 2840)
,
Sep 6 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8d9a5f91b19c30f88e0a9812abf2e936a38dbd0b commit 8d9a5f91b19c30f88e0a9812abf2e936a38dbd0b Author: Sunny Sachanandani <sunnyps@chromium.org> Date: Tue Sep 06 18:59:55 2016 Reland of Default enable main frame before activation and remove finch experiment. (patchset #1 id:1 of https://codereview.chromium.org/2170233002/ ) Reason for revert: Relanding after fixing android webview issues Original issue's description: > Revert of Default enable main frame before activation and remove finch experiment. (patchset #1 id:1 of https://codereview.chromium.org/2159103008/ ) > > Reason for revert: > Speculative revert for failing WebView tests on Lollipop: > > https://build.chromium.org/p/chromium.android/builders/Lollipop%20Phone%20Tester/builds/5794 > https://build.chromium.org/p/chromium.android/builders/Lollipop%20Tablet%20Tester/builds/4054 > > Both phone and tablet started failing and this is the most "suspicious" change. boliu@ can help investigate further assuming this holds true. > > Original issue's description: > > Default enable main frame before activation and remove finch experiment. > > > > The finch experiment hasn't revealed any regressions other than in page > > load times which has been deemed a blink scheduler issue (see > > crbug.com/614482). > > > > R=piman@chromium.org,rkaplow@chromium.org > > BUG= 612596 > > > > Committed: https://crrev.com/45041a7e286c665ab14d8ae0b182e1c11cef65ed > > Cr-Commit-Position: refs/heads/master@{#406916} > > TBR=piman@chromium.org,rkaplow@chromium.org,sunnyps@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG= 612596 > > Committed: https://crrev.com/2863590ee8e57543f646f4308130765afb02bd44 > Cr-Commit-Position: refs/heads/master@{#407003} TBR=piman@chromium.org,rkaplow@chromium.org,tedchoc@chromium.org BUG= 612596 Review-Url: https://codereview.chromium.org/2184243003 Cr-Commit-Position: refs/heads/master@{#416402} (cherry picked from commit 398642c9f408c394cd87564780b64602e8d310f9) Review URL: https://codereview.chromium.org/2316743002 . Cr-Commit-Position: refs/branch-heads/2840@{#180} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/8d9a5f91b19c30f88e0a9812abf2e936a38dbd0b/content/browser/gpu/compositor_util.cc [modify] https://crrev.com/8d9a5f91b19c30f88e0a9812abf2e936a38dbd0b/content/public/common/content_features.cc [modify] https://crrev.com/8d9a5f91b19c30f88e0a9812abf2e936a38dbd0b/content/public/common/content_features.h [modify] https://crrev.com/8d9a5f91b19c30f88e0a9812abf2e936a38dbd0b/testing/variations/fieldtrial_testing_config_android.json [modify] https://crrev.com/8d9a5f91b19c30f88e0a9812abf2e936a38dbd0b/testing/variations/fieldtrial_testing_config_chromeos.json [modify] https://crrev.com/8d9a5f91b19c30f88e0a9812abf2e936a38dbd0b/testing/variations/fieldtrial_testing_config_linux.json [modify] https://crrev.com/8d9a5f91b19c30f88e0a9812abf2e936a38dbd0b/testing/variations/fieldtrial_testing_config_mac.json [modify] https://crrev.com/8d9a5f91b19c30f88e0a9812abf2e936a38dbd0b/testing/variations/fieldtrial_testing_config_win.json
,
Sep 28 2016
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8d9a5f91b19c30f88e0a9812abf2e936a38dbd0b commit 8d9a5f91b19c30f88e0a9812abf2e936a38dbd0b Author: Sunny Sachanandani <sunnyps@chromium.org> Date: Tue Sep 06 18:59:55 2016 Reland of Default enable main frame before activation and remove finch experiment. (patchset #1 id:1 of https://codereview.chromium.org/2170233002/ ) Reason for revert: Relanding after fixing android webview issues Original issue's description: > Revert of Default enable main frame before activation and remove finch experiment. (patchset #1 id:1 of https://codereview.chromium.org/2159103008/ ) > > Reason for revert: > Speculative revert for failing WebView tests on Lollipop: > > https://build.chromium.org/p/chromium.android/builders/Lollipop%20Phone%20Tester/builds/5794 > https://build.chromium.org/p/chromium.android/builders/Lollipop%20Tablet%20Tester/builds/4054 > > Both phone and tablet started failing and this is the most "suspicious" change. boliu@ can help investigate further assuming this holds true. > > Original issue's description: > > Default enable main frame before activation and remove finch experiment. > > > > The finch experiment hasn't revealed any regressions other than in page > > load times which has been deemed a blink scheduler issue (see > > crbug.com/614482). > > > > R=piman@chromium.org,rkaplow@chromium.org > > BUG= 612596 > > > > Committed: https://crrev.com/45041a7e286c665ab14d8ae0b182e1c11cef65ed > > Cr-Commit-Position: refs/heads/master@{#406916} > > TBR=piman@chromium.org,rkaplow@chromium.org,sunnyps@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG= 612596 > > Committed: https://crrev.com/2863590ee8e57543f646f4308130765afb02bd44 > Cr-Commit-Position: refs/heads/master@{#407003} TBR=piman@chromium.org,rkaplow@chromium.org,tedchoc@chromium.org BUG= 612596 Review-Url: https://codereview.chromium.org/2184243003 Cr-Commit-Position: refs/heads/master@{#416402} (cherry picked from commit 398642c9f408c394cd87564780b64602e8d310f9) Review URL: https://codereview.chromium.org/2316743002 . Cr-Commit-Position: refs/branch-heads/2840@{#180} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/8d9a5f91b19c30f88e0a9812abf2e936a38dbd0b/content/browser/gpu/compositor_util.cc [modify] https://crrev.com/8d9a5f91b19c30f88e0a9812abf2e936a38dbd0b/content/public/common/content_features.cc [modify] https://crrev.com/8d9a5f91b19c30f88e0a9812abf2e936a38dbd0b/content/public/common/content_features.h [modify] https://crrev.com/8d9a5f91b19c30f88e0a9812abf2e936a38dbd0b/testing/variations/fieldtrial_testing_config_android.json [modify] https://crrev.com/8d9a5f91b19c30f88e0a9812abf2e936a38dbd0b/testing/variations/fieldtrial_testing_config_chromeos.json [modify] https://crrev.com/8d9a5f91b19c30f88e0a9812abf2e936a38dbd0b/testing/variations/fieldtrial_testing_config_linux.json [modify] https://crrev.com/8d9a5f91b19c30f88e0a9812abf2e936a38dbd0b/testing/variations/fieldtrial_testing_config_mac.json [modify] https://crrev.com/8d9a5f91b19c30f88e0a9812abf2e936a38dbd0b/testing/variations/fieldtrial_testing_config_win.json |
|||||||||||||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||||||||||||
Comment 1 by bugdroid1@chromium.org
, May 18 2016