[People -> Sync] Update Status messages |
|||||||||
Issue descriptionHi Alan, I saw in the People preview some updated status messages: https://folio.googleplex.com/chrome-ux-specs-and-sources/Chrome%20Inner%20Pages/03-Settings/preview/cards#%2FPREVIEW-People-account.png%3Fz=width These status messages are generated from a common sync_ui_util.cc file used by both Old Options and New Settings. It's not totally trivial because there's a whole bunch of different error states Sync can be in. I wanted to confirm a few things: 1. The new Settings should have different error messages from the old Options? 2. Can the old Options get the updated error messages too? It's extra engineering work to make the two have different sets of messages, since there's a common sync_ui_util currently. 3. Is there a definitive list of the new messages? There's a few more cases that are not covered in the mocks: See https://code.google.com/p/chromium/codesearch#chromium/src/chrome/app/generated_resources.grd&sq=package:chromium&q=generated_resources.grd&l=11412 4. I noticed the mocks show none of them having links. The old Options version has some links in them. Are we abolishing links within the Sync status messages? This is not incredibly urgent. Currently I'm just proceeding forward using the old status messages (that don't match the mocks). Thanks! Tommy
,
May 18 2016
Hi Eli, Great, I think you addressed all my questions. I will update the messages for both the old Options and new Settings. I'll leave this bug open until we finish this work, as I'm sure I'll have some edge cases or related questions to ask you.
,
May 18 2016
Thanks Tommy! I'm going to assign the bug to you for now, since you're working on updating the messages. Let me know if there are any errors/cases I missed. We can iterate via comments on the doc as well.
,
May 24 2016
,
Jun 14 2016
,
Aug 11 2016
,
Sep 13 2016
,
Oct 3 2016
Issue 642965 has been merged into this issue.
,
Oct 5 2016
,
Nov 4 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/715a58fd0413dbe6fd2fbccb9d6bc088056de3d1 commit 715a58fd0413dbe6fd2fbccb9d6bc088056de3d1 Author: mahmadi <mahmadi@chromium.org> Date: Fri Nov 04 21:40:59 2016 [MD Settings][Sync Settings] Updates sync status messages BUG= 612595 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2457483002 Cr-Commit-Position: refs/heads/master@{#430023} [modify] https://crrev.com/715a58fd0413dbe6fd2fbccb9d6bc088056de3d1/chrome/app/chromium_strings.grd [modify] https://crrev.com/715a58fd0413dbe6fd2fbccb9d6bc088056de3d1/chrome/app/generated_resources.grd [modify] https://crrev.com/715a58fd0413dbe6fd2fbccb9d6bc088056de3d1/chrome/app/google_chrome_strings.grd [modify] https://crrev.com/715a58fd0413dbe6fd2fbccb9d6bc088056de3d1/chrome/browser/resources/settings/people_page/people_page.html [modify] https://crrev.com/715a58fd0413dbe6fd2fbccb9d6bc088056de3d1/chrome/browser/resources/settings/people_page/people_page.js [modify] https://crrev.com/715a58fd0413dbe6fd2fbccb9d6bc088056de3d1/chrome/browser/resources/settings/people_page/sync_browser_proxy.js [modify] https://crrev.com/715a58fd0413dbe6fd2fbccb9d6bc088056de3d1/chrome/browser/signin/signin_ui_util.cc [modify] https://crrev.com/715a58fd0413dbe6fd2fbccb9d6bc088056de3d1/chrome/browser/signin/signin_ui_util.h [modify] https://crrev.com/715a58fd0413dbe6fd2fbccb9d6bc088056de3d1/chrome/browser/sync/sync_ui_util.cc [modify] https://crrev.com/715a58fd0413dbe6fd2fbccb9d6bc088056de3d1/chrome/browser/sync/sync_ui_util.h [modify] https://crrev.com/715a58fd0413dbe6fd2fbccb9d6bc088056de3d1/chrome/browser/sync/sync_ui_util_unittest.cc [modify] https://crrev.com/715a58fd0413dbe6fd2fbccb9d6bc088056de3d1/chrome/browser/ui/webui/options/browser_options_handler.cc [modify] https://crrev.com/715a58fd0413dbe6fd2fbccb9d6bc088056de3d1/chrome/browser/ui/webui/options/sync_setup_handler.cc [modify] https://crrev.com/715a58fd0413dbe6fd2fbccb9d6bc088056de3d1/chrome/browser/ui/webui/options/sync_setup_handler.h [modify] https://crrev.com/715a58fd0413dbe6fd2fbccb9d6bc088056de3d1/chrome/browser/ui/webui/settings/people_handler.cc [modify] https://crrev.com/715a58fd0413dbe6fd2fbccb9d6bc088056de3d1/chrome/test/data/webui/settings/people_page_test.js [modify] https://crrev.com/715a58fd0413dbe6fd2fbccb9d6bc088056de3d1/components/browser_sync/profile_sync_service.cc [modify] https://crrev.com/715a58fd0413dbe6fd2fbccb9d6bc088056de3d1/components/sync_ui_strings.grdp
,
Nov 4 2016
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by ew...@chromium.org
, May 18 2016