New issue
Advanced search Search tips

Issue 612593 link

Starred by 1 user

Issue metadata

Status: Untriaged
Owner: ----
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

git cl upload fails in presubmit_support.py ExecPresubmitScript

Project Member Reported by lijeffrey@chromium.org, May 17 2016

Issue description

Hey Dirk,

Thanks for the help. Here's the stacktrace from attempting to run "git cl upload" from a chromium src checkout:

Using 50% similarity for rename/copy detection. Override with --similarity.
Running presubmit upload checks ...
Traceback (most recent call last):
  File "/usr/local/google/home/lijeffrey/depot_tools/git_cl.py", line 4907, in <module>
    sys.exit(main(sys.argv[1:]))
  File "/usr/local/google/home/lijeffrey/depot_tools/git_cl.py", line 4889, in main
    return dispatcher.execute(OptionParser(), argv)
  File "/usr/local/google/home/lijeffrey/depot_tools/subcommand.py", line 252, in execute
    return command(parser, args[1:])
  File "/usr/local/google/home/lijeffrey/depot_tools/git_cl.py", line 3621, in CMDupload
    return cl.CMDUpload(options, args, orig_args)
  File "/usr/local/google/home/lijeffrey/depot_tools/git_cl.py", line 1378, in CMDUpload
    change=change)
  File "/usr/local/google/home/lijeffrey/depot_tools/git_cl.py", line 1322, in RunHook
    gerrit_obj=self._codereview_impl.GetGerritObjForPresubmit())
  File "/usr/local/google/home/lijeffrey/depot_tools/presubmit_support.py", line 1548, in DoPresubmitChecks
    results += executer.ExecPresubmitScript(presubmit_script, filename)
  File "/usr/local/google/home/lijeffrey/depot_tools/presubmit_support.py", line 1460, in ExecPresubmitScript
    result = eval(function_name + '(*__args)', context)
  File "<string>", line 1, in <module>
  File "<string>", line 2085, in CheckChangeOnUpload
  File "<string>", line 1832, in _CommonChecks
  File "<string>", line 677, in _CheckUnwantedDependencies
ImportError: No module named checkdeps


Per your suggestion using git cl upload --bypass-hooks worked great
 
Components: Build
Labels: OS-All
Status: Assigned (was: Untriaged)
Owner: ----
Status: Available (was: Assigned)
I'm probably not going to get to this any time soon ...
Project Member

Comment 4 by sheriffbot@chromium.org, Apr 13 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment