NativeDesktopMediaListTest.UpdateThumbnail failing on DrMemory |
|||
Issue descriptionStarted failing in https://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Unit%20%28DrMemory%20full%29%20%283%29/builds/10334: [ RUN ] NativeDesktopMediaListTest.UpdateThumbnail unknown file: error: Unexpected mock function call - returning directly. Function call: OnSourceThumbnailChanged(0FFC2B48, 2) Google Mock tried the following 1 expectation, but it didn't match: c:\b\build\slave\drm-cr\build\src\chrome\browser\media\native_desktop_media_list_unittest.cc(484): EXPECT_CALL(observer_, OnSourceThumbnailChanged(model_.get(), 1))... Expected arg #1: is equal to 1 Actual: 2 Expected: to be called once Actual: called once - saturated and active [ FAILED ] NativeDesktopMediaListTest.UpdateThumbnail (2329 ms) I don't immediately see a change that looks likely to have caused this.
,
May 17 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fb6927848799886e034269ad61c911059cdefc23 commit fb6927848799886e034269ad61c911059cdefc23 Author: jyasskin <jyasskin@chromium.org> Date: Tue May 17 23:06:11 2016 Exclude NativeDesktopMediaListTest.UpdateThumbnail, which fails on DrMemory. BUG= 612590 TBR=gyzhou@chromium.org,sergeyu@chromium.org Review-Url: https://codereview.chromium.org/1991473002 Cr-Commit-Position: refs/heads/master@{#394258} [modify] https://crrev.com/fb6927848799886e034269ad61c911059cdefc23/tools/valgrind/gtest_exclude/unit_tests.gtest-drmemory_win32.txt
,
May 20 2016
,
Jun 6 2016
jyasskin@ Would you please give an instruction of how to reproduce this issue in DrMemory buildbot? Thanks, George
,
Jun 6 2016
Try reverting r394258, building the test on Windows for DrMemory (http://www.chromium.org/developers/how-tos/using-drmemory), and running it?
,
Jun 7 2016
I tried on both DrMemory debug and release build and cannot reproduce the issue. It is not a surprise to see it is hard to reproduce since this bug was reported more than a month after the Unit tests was modified to support aura windows. The issue in the bug may happen occasionally. From the bug report, I suspect the aura window's thumbnail (OnSourceThumbnailChanged(model_.get(), 2)) is updated though it should not before the native window's thumbnail (OnSourceThumbnailChanged(model_.get(), 1)) update. Fake aura windows are created for unit test. I am going to only test native window for thumbnail update to avoid this issue.
,
Jun 8 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a37f94d721559520b7aa7ef72b0055e92948041d commit a37f94d721559520b7aa7ef72b0055e92948041d Author: gyzhou <gyzhou@chromium.org> Date: Wed Jun 08 23:20:14 2016 Fix DrMemory test for NativeDesktopMediaListTest.UpdateThumbnail BUG= 612590 Review-Url: https://codereview.chromium.org/2045983004 Cr-Commit-Position: refs/heads/master@{#398729} [modify] https://crrev.com/a37f94d721559520b7aa7ef72b0055e92948041d/chrome/browser/media/native_desktop_media_list_unittest.cc [modify] https://crrev.com/a37f94d721559520b7aa7ef72b0055e92948041d/tools/valgrind/gtest_exclude/unit_tests.gtest-drmemory_win32.txt
,
Jun 8 2016
|
|||
►
Sign in to add a comment |
|||
Comment 1 by gyzhou@chromium.org
, May 17 2016