New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 612587 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Email to this user bounced
Closed: May 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Webview shell doesn't support fullscreen video

Project Member Reported by w...@chromium.org, May 17 2016

Issue description

Comment 1 by ti...@chromium.org, May 17 2016

Cc: -ti...@chromium.org
Owner: ti...@chromium.org

Comment 2 by boliu@chromium.org, May 17 2016

Which test shell, android_webview_apk or system_webview_shell_apk?

Either one, it's not too hard to implement onShowCustomView and onHideCustomView. Just copy the implementation from the test should be fine.

Comment 3 by w...@chromium.org, May 17 2016

system webview shell would be best for us I believe. (I think the easiest workflow for us non-webview people is to build system_webview_apk with  system_webview_shell_package_name="com.google.android.webview")

Comment 4 by boliu@chromium.org, May 18 2016

Looking at the code today, I think arbitrary element full screen *is* supported in webview. It's just neither test shells implement the webview callbacks required for full screen.

So just need to verify this is the case.
SystemWebviewShell.apk should support fullscreen now. watk@ - is this sufficient for your needs?

Comment 7 by w...@chromium.org, May 19 2016

Status: Fixed (was: Available)
Awesome! Just tried it and it works.

Sign in to add a comment