Webview shell doesn't support fullscreen video |
||
Issue descriptionWe really need this for testing changes to fullscreen video on Android. This is already implemented for tests, but not the shell (https://code.google.com/p/chromium/codesearch#chromium/src/android_webview/javatests/src/org/chromium/android_webview/test/FullScreenVideoTestAwContentsClient.java&q=onshowcustomview&sq=package:chromium&l=45)
,
May 17 2016
Which test shell, android_webview_apk or system_webview_shell_apk? Either one, it's not too hard to implement onShowCustomView and onHideCustomView. Just copy the implementation from the test should be fine.
,
May 17 2016
system webview shell would be best for us I believe. (I think the easiest workflow for us non-webview people is to build system_webview_apk with system_webview_shell_package_name="com.google.android.webview")
,
May 18 2016
Looking at the code today, I think arbitrary element full screen *is* supported in webview. It's just neither test shells implement the webview callbacks required for full screen. So just need to verify this is the case.
,
May 19 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6a321a7e3cfe5b7272da3c0f99cf200ee09927fd commit 6a321a7e3cfe5b7272da3c0f99cf200ee09927fd Author: tobiasjs <tobiasjs@chromium.org> Date: Thu May 19 11:04:09 2016 Support fullscreen in webview shell. BUG= 612587 Review-Url: https://codereview.chromium.org/1990743003 Cr-Commit-Position: refs/heads/master@{#394731} [modify] https://crrev.com/6a321a7e3cfe5b7272da3c0f99cf200ee09927fd/android_webview/tools/system_webview_shell/apk/src/org/chromium/webview_shell/WebViewBrowserActivity.java
,
May 19 2016
SystemWebviewShell.apk should support fullscreen now. watk@ - is this sufficient for your needs?
,
May 19 2016
Awesome! Just tried it and it works. |
||
►
Sign in to add a comment |
||
Comment 1 by ti...@chromium.org
, May 17 2016Owner: ti...@chromium.org