both_gn_and_gyp is missing many test dependencies on mac |
||
Issue description
./BUILD.gn has a target both_gn_and_gyp that's supposed to pull in all test binaries (roughly; see comment at top of file).
It lists many many tests in two nested ifs that aren't entered on mac (or cros):
if (is_android || is_win || (is_linux && !is_chromeos)) {
deps += [
"//base:build_utf8_validator_tables",
"//base:check_example",
"//cc:cc_perftests",
"//cc/blink:cc_blink_unittests",
"//components:components_perftests",
"//device:device_unittests",
"//gin:gin_shell",
"//gin:gin_unittests",
"//google_apis/gcm:mcs_probe",
"//gpu:gl_tests",
"//gpu:gpu_perftests",
"//ipc:ipc_perftests",
"//media:media_perftests",
"//net:dump_cache",
"//sync:run_sync_testserver",
"//third_party/codesighs:maptsvdifftool",
"//third_party/libphonenumber:libphonenumber_unittests",
"//ui/compositor:compositor_unittests",
]
# TODO(GYP): Figure out which of these should (and can) build
# for chromeos/mac/ios.
if (!is_android) {
....
Most of these should be hooked up on mac as well.
,
Jun 1 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/507c15c418df6f643c990e06a1d989eafab85fc1 commit 507c15c418df6f643c990e06a1d989eafab85fc1 Author: thakis <thakis@chromium.org> Date: Wed Jun 01 00:26:01 2016 mac/gn: Add most missing test binaries to the gn build. BUG= 612580 TBR=dpranke Review-Url: https://codereview.chromium.org/2025793004 Cr-Commit-Position: refs/heads/master@{#396990} [modify] https://crrev.com/507c15c418df6f643c990e06a1d989eafab85fc1/BUILD.gn
,
Jun 1 2016
|
||
►
Sign in to add a comment |
||
Comment 1 by ellyjo...@chromium.org
, May 18 2016Owner: thakis@chromium.org
Status: Assigned (was: Untriaged)