WebElement:isEditable is a poorly reinvented version of Node::hasEditableStyle |
|||
Issue descriptionIt will work for most, but not all cases. We should remove this function.
,
Jan 27 2017
,
Sep 9 2017
Can I take this issue?
,
Sep 11 2017
I think consumers can't use Node:hasEditableStyle() instead of WebElement::IsEditable() because Node:hasEditableStyle() is not exported api. and each function's functionality is not same even if we expose Node:hasEditableStyle().
,
Sep 12 2017
Hello Hyungwook, you can take this issue by assigning it to yourself.
,
Sep 16 2017
In my investigation, Node:hasEditableStyle() can't cover WebElement::IsEditable() directly because of following reasons.
1. WebElement::IsEditable() API calls UpdateStyleAndLayoutTree() for make sure latest node's editable status.
2. Node:hasEditableStyle() doesn't support InsertHTML("<input id=testElement>") test case that covered by WebElement::IsEditable()
3. Node:hasEditableStyle() doesn't support InsertHTML("<div id=testNode role=textbox></div>"); test case that covered by WebElement::IsEditable()
This is my idea to solve this issue.
1. Make use WebNode::IsContentEditable() in callers instead of WebElement::IsEditable()
-> We can implement #2, #3 issues in callers using given APIs but there is no UpdateStyleAndLayoutTree() API and UpdateStyleAndLayoutTree() looks not exportable API.
Hence I suggest to use WebNode::IsContentEditable() that calls UpdateStyleAndLayoutTree() internally.
2. Remove WebElement:IsEditable() and move it's functionality to WebNode::IsContentEditable().
-> We can provide one way to check editable condition
3. Move TEST_F(WebElementTest, IsEditable) -> TEST_F(WebNodeTest, IsContentEditable)
,
Sep 17
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot |
|||
►
Sign in to add a comment |
|||
Comment 1 by tkent@chromium.org
, Jun 23 2016