New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 612558 link

Starred by 1 user
Status: Fixed
Owner:
ftang@chromium.org
Closed: May 2016
Cc:
█ juliecattiau@google.com
msw@chromium.org
█ groby@chromium.org
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug



Sign in to add a comment

Incorrect value of SET_STATE_OPTIONS introduced in cl/1923143003 (landed 5/4/2016)

Project Member Reported by ftang@chromium.org, May 17 2016 
Version: Any build after 5/4/2016
OS: ALL

In https://codereview.chromium.org/1923143003 I moved enum TranslateBubbleUiEvent from 
chrome/browser/ui/translate/translate_bubble_view_state_transition.cc
to
chrome/browser/ui/translate/translate_bubble_view_state_transition.h

but miss the " = 1;" for
SET_STATE_OPTIONS = 1;

and change the value for SET_STATE_OPTIONS . We need to change it back before the next release out.
Project Member

Comment 1 by bugdroid1@chromium.org, May 17 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a3ee02bc873cb815d4730786044209c4e15a73f4

commit a3ee02bc873cb815d4730786044209c4e15a73f4
Author: ftang <ftang@chromium.org>
Date: Tue May 17 23:03:50 2016

add additional description of enum for TranslateBubbleUievent

BUG= 612558 

Review-Url: https://codereview.chromium.org/1985973004
Cr-Commit-Position: refs/heads/master@{#394256}

[modify] https://crrev.com/a3ee02bc873cb815d4730786044209c4e15a73f4/tools/metrics/histograms/histograms.xml
Project Member

Comment 2 by bugdroid1@chromium.org, May 18 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4bda0372b8eae09293604a98c0c96b74ed23c4bf

commit 4bda0372b8eae09293604a98c0c96b74ed23c4bf
Author: ftang <ftang@chromium.org>
Date: Wed May 18 00:55:53 2016

in cl/1923143003 (landed 5/4/2016) I mistakenly change the value of SET_STATE_OPTIONS from 1 to 0. Need to change it back to 1 before the next release.

BUG= 612558 

Review-Url: https://codereview.chromium.org/1983133003
Cr-Commit-Position: refs/heads/master@{#394301}

[modify] https://crrev.com/4bda0372b8eae09293604a98c0c96b74ed23c4bf/chrome/browser/ui/translate/translate_bubble_view_state_transition.h

Comment 3 by ftang@chromium.org, May 19 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment