gles2_conform_tests incorrectly checks extension strings |
||
Issue descriptionIn the GLES2 conformance tests, extensions are checked by using strstr of the extension string and the GL_EXTENSIONS string (GTFIsExtensionSupported). This encouters problems when one extension is a substring of another extension. ANGLE has just added support for the GL_OES_image_external and GL_OES_image_external_essl3 extensions which caused the GLES2ConformTest.GL2ExtensionTests_egl_image_input_run test to start running because they are substrings of the GL_OES_EGL_image extension. I think the best fix is to simply skip the test on all platforms, especially since the command buffer has no intention of supporting EGL images.
,
May 18 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2151d0b3246856c17dd2e3a8ce6c33f083a57b7b commit 2151d0b3246856c17dd2e3a8ce6c33f083a57b7b Author: geofflang <geofflang@chromium.org> Date: Wed May 18 13:22:11 2016 Skip the GL2ExtensionTests_egl_image_input_run test on all platforms. The GLES2 conformance tests incorrectly detect that the GL_OES_EGL_image extension is available because it is a substring of the GL_OES_image_external extension. Since the command buffer service will never expose the EGL image extensions, skip this test on all platforms. BUG= 612551 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/1986153004 Cr-Commit-Position: refs/heads/master@{#394398} [modify] https://crrev.com/2151d0b3246856c17dd2e3a8ce6c33f083a57b7b/gpu/gles2_conform_support/gles2_conform_test_expectations.txt
,
May 18 2016
,
May 18 2016
Ken, this was a bug purely in the ES CTS. I figured it was easier to simply disable the test instead of fixing it in the third party repo and rolling, especially since we don't plan on supporting EGL images at the command buffer level. |
||
►
Sign in to add a comment |
||
Comment 1 by kbr@chromium.org
, May 17 2016