New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 1 user
Status: Fixed
Owner:
User never visited
Closed: Oct 2010
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug-Security
M-7

Restricted
  • Only users with EditIssue permission may comment.



Sign in to add a comment
Bad cast in PageClickTracker::handleEvent
Project Member Reported by infe...@chromium.org, Oct 29 2010 Back to list
Need to check the cast. Crash report here - http://crash/reportdetail?reportid=4589292662784d09. mouse_event is badly casted

void PageClickTracker::handleEvent(const WebDOMEvent& event) {
  last_node_clicked_.reset();

  DCHECK(event.isMouseEvent());
  const WebDOMMouseEvent mouse_event = event.toConst<WebDOMMouseEvent>();
  DCHECK(mouse_event.buttonDown());
  if (mouse_event.button() != 0)
    return;  // We are only interested in left clicks.

  // Remember which node has focus before the click is processed.
  // We'll get a notification once the mouse event has been processed
  // (DidHandleMouseEvent), we'll notify the listener at that point.
  last_node_clicked_ = mouse_event.target();
  was_focused_ = (GetFocusedNode() == last_node_clicked_);
}
 
Labels: SecSeverity-High
Comment 2 by bugdro...@gmail.com, Oct 29 2010
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=64510

------------------------------------------------------------------------
r64510 | cdn@chromium.org | Fri Oct 29 15:46:29 PDT 2010

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/page_click_tracker.cc?r1=64510&r2=64509&pathrev=64510

Added check in page click tracker to ensure events passed in are mouse events

BUG= 61255 
TEST=None

Review URL: http://codereview.chromium.org/4120011
------------------------------------------------------------------------
Status: WillMerge
Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Status: FixUnreleased
Comment 5 by bugdro...@gmail.com, Oct 29 2010
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=64515

------------------------------------------------------------------------
r64515 | cdn@google.com | Fri Oct 29 16:04:46 PDT 2010

Changed paths:
 M http://src.chromium.org/viewvc/chrome/branches/552/src/chrome/renderer/page_click_tracker.cc?r1=64515&r2=64514&pathrev=64515

Merge 64510 - Added check in page click tracker to ensure events passed in are mouse events

BUG= 61255 
TEST=None

Review URL: http://codereview.chromium.org/4120011

Review URL: http://codereview.chromium.org/4116015
------------------------------------------------------------------------
Comment 6 by bugdro...@gmail.com, Oct 29 2010
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=64514

------------------------------------------------------------------------
r64514 | cdn@google.com | Fri Oct 29 16:02:44 PDT 2010

Changed paths:
 M http://src.chromium.org/viewvc/chrome/branches/517/src/chrome/renderer/page_click_tracker.cc?r1=64514&r2=64513&pathrev=64514

Merge 64510 - Added check in page click tracker to ensure events passed in are mouse events

BUG= 61255 
TEST=None

Review URL: http://codereview.chromium.org/4120011

Review URL: http://codereview.chromium.org/4168008
------------------------------------------------------------------------
Comment 7 by jsc...@chromium.org, Mar 21 2011
Labels: Type-Security
Labels: SecImpacts-Stable
Batch update.
Comment 9 by jsc...@chromium.org, Apr 18 2012
Labels: -Restrict-View-SecurityNotify
Lifting view restrictions.
Status: Fixed
Project Member Comment 11 by bugdroid1@chromium.org, Oct 13 2012
Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Project Member Comment 12 by bugdroid1@chromium.org, Mar 10 2013
Labels: -Area-Internals -Mstone-7 -SecSeverity-High -Type-Security -SecImpacts-Stable Security-Impact-Stable M-7 Cr-Internals Security-Severity-High Type-Bug-Security
Project Member Comment 13 by bugdroid1@chromium.org, Mar 13 2013
Labels: -Restrict-AddIssueComment-Commit Restrict-AddIssueComment-EditIssue
Project Member Comment 14 by bugdroid1@chromium.org, Mar 21 2013
Labels: -Security-Severity-High Security_Severity-High
Project Member Comment 15 by bugdroid1@chromium.org, Mar 21 2013
Labels: -Security-Impact-Stable Security_Impact-Stable
Project Member Comment 16 by sheriffbot@chromium.org, Oct 1 2016
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member Comment 17 by sheriffbot@chromium.org, Oct 2 2016
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: allpublic
Sign in to add a comment